[Buildroot] [PATCH 0/1] Added keepalived package

[Buildroot] [PATCH 0/1] Added keepalived package

[Ilias Apalodimas]

Add Support for keepalived

Ilias Apalodimas (1):
  Added keepalived package

 package/Config.in                |  1 +
 package/keepalived/Config.in     | 13 +++++++++++++
 package/keepalived/keepalived.mk | 13 +++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/keepalived/Config.in
 create mode 100644 package/keepalived/keepalived.mk

-- 
1.9.1

[Buildroot] [PATCH 1/1] Added keepalived package

[Ilias Apalodimas]

Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
---
 package/Config.in                |  1 +
 package/keepalived/Config.in     | 13 +++++++++++++
 package/keepalived/keepalived.mk | 13 +++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/keepalived/Config.in
 create mode 100644 package/keepalived/keepalived.mk

diff --git a/package/Config.in b/package/Config.in
index 114a5ad..f0f1dec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1546,6 +1546,7 @@ menu "Networking applications"
 	source "package/irssi/Config.in"
 	source "package/iw/Config.in"
 	source "package/janus-gateway/Config.in"
+	source "package/keepalived/Config.in"
 	source "package/kismet/Config.in"
 	source "package/knock/Config.in"
 	source "package/leafnode2/Config.in"
diff --git a/package/keepalived/Config.in b/package/keepalived/Config.in
new file mode 100644
index 0000000..ee4ab7a
--- /dev/null
+++ b/package/keepalived/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_KEEPALIVED
+	bool "keepalived"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_POPT
+	help
+	  The main goal of the keepalived project is to add a strong & robust
+	  keepalive facility to the Linux Virtual Server project.
+	  It implements a multilayer TCP/IP stack checks. Keepalived implements
+	  a framework based on three family checks : Layer3, Layer4 & Layer5.
+	  This framework gives the daemon the ability of checking a LVS server
+	  pool states. Keepalived can be sumarize as a LVS driving daemon.
+
+	  http://www.keepalived.org/
diff --git a/package/keepalived/keepalived.mk b/package/keepalived/keepalived.mk
new file mode 100644
index 0000000..4f8a6b2
--- /dev/null
+++ b/package/keepalived/keepalived.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# keepalived
+#
+################################################################################
+
+KEEPALIVED_VERSION = 1.3.2
+KEEPALIVED_SITE = http://www.keepalived.org/software
+KEEPALIVED_DEPENDENCIES = popt openssl
+KEEPALIVED_LICENSE = GPLv2+
+KEEPALIVED_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
1.9.1

[Buildroot] [PATCH 1/1] Added keepalived package

[Thomas Petazzoni]

Hello,

On Tue,  7 Feb 2017 18:20:58 +0200, Ilias Apalodimas wrote:
> Signed-off-by: Ilias Apalodimas <apalos@gmail.com>

Thanks for this patch. This looks mostly good, so great for a first
contribution.

A few comments:

 - You don't need to send a series with a cover letter for just a
   single patch. Just send the patch itself.

 - Make a change to the DEVELOPERS file to associate your name/email to
   this package. This way, you'll get notified when/if this package
   fails to build, or when someone sends a patch touching this package.

 - You're missing a hash file. See other packages and the manual for
   the format/details.

> diff --git a/package/keepalived/Config.in b/package/keepalived/Config.in
> new file mode 100644
> index 0000000..ee4ab7a
> --- /dev/null
> +++ b/package/keepalived/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_KEEPALIVED
> +	bool "keepalived"
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_POPT

Are you sure this builds even for no-MMU platforms, static linking
scenario? It's pretty likely that keepalived uses fork() and therefore
will not work on no-MMU platforms.

Yann E. Morin has just submitted a script today to help checking a
package, you may want to use it. It will be merged soon, which will
make things easier.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] Added keepalived package

[Ilias Apalodimas]

Hello,

I'll add the hash file, totally forgot about it and i'll fix the
DEVELOPERS file.
I haven't tried it on no-mmu and i doubt it will build properly as you
pointed out.

Regards
Ilias

On Tue, Feb 7, 2017 at 6:46 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Tue,  7 Feb 2017 18:20:58 +0200, Ilias Apalodimas wrote:
>> Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
>
> Thanks for this patch. This looks mostly good, so great for a first
> contribution.
>
> A few comments:
>
>  - You don't need to send a series with a cover letter for just a
>    single patch. Just send the patch itself.
>
>  - Make a change to the DEVELOPERS file to associate your name/email to
>    this package. This way, you'll get notified when/if this package
>    fails to build, or when someone sends a patch touching this package.
>
>  - You're missing a hash file. See other packages and the manual for
>    the format/details.
>
>> diff --git a/package/keepalived/Config.in b/package/keepalived/Config.in
>> new file mode 100644
>> index 0000000..ee4ab7a
>> --- /dev/null
>> +++ b/package/keepalived/Config.in
>> @@ -0,0 +1,13 @@
>> +config BR2_PACKAGE_KEEPALIVED
>> +     bool "keepalived"
>> +     select BR2_PACKAGE_OPENSSL
>> +     select BR2_PACKAGE_POPT
>
> Are you sure this builds even for no-MMU platforms, static linking
> scenario? It's pretty likely that keepalived uses fork() and therefore
> will not work on no-MMU platforms.
>
> Yann E. Morin has just submitted a script today to help checking a
> package, you may want to use it. It will be merged soon, which will
> make things easier.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com