[Buildroot] [PATCH v3 1/2] Added keepalived

[Buildroot] [PATCH v3 1/2] Added keepalived

[Ilias Apalodimas]

Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/keepalived/Config.in       | 14 ++++++++++++++
 package/keepalived/keepalived.hash |  3 +++
 package/keepalived/keepalived.mk   | 30 ++++++++++++++++++++++++++++++
 5 files changed, 51 insertions(+)
 create mode 100644 package/keepalived/Config.in
 create mode 100644 package/keepalived/keepalived.hash
 create mode 100644 package/keepalived/keepalived.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 94f6804..eb02c4a 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -765,6 +765,9 @@ F:	package/python-rpi-gpio/
 N:	Ignacy Gaw?dzki <ignacy.gawedzki@green-communications.fr>
 F:	package/angularjs/
 
+N:	Ilias Apalodimas <apalos@gmail.com>
+F:	package/keepalived/
+
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
 F:	package/cairomm/
diff --git a/package/Config.in b/package/Config.in
index deff0fe..5b3871c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1546,6 +1546,7 @@ menu "Networking applications"
 	source "package/irssi/Config.in"
 	source "package/iw/Config.in"
 	source "package/janus-gateway/Config.in"
+	source "package/keepalived/Config.in"
 	source "package/kismet/Config.in"
 	source "package/knock/Config.in"
 	source "package/leafnode2/Config.in"
diff --git a/package/keepalived/Config.in b/package/keepalived/Config.in
new file mode 100644
index 0000000..721eed5
--- /dev/null
+++ b/package/keepalived/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_KEEPALIVED
+	bool "keepalived"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_POPT
+	depends on BR2_USE_MMU
+	help
+	  The main goal of the keepalived project is to add a strong & robust
+	  keepalive facility to the Linux Virtual Server project.
+	  It implements a multilayer TCP/IP stack checks. Keepalived implements
+	  a framework based on three family checks : Layer3, Layer4 & Layer5.
+	  This framework gives the daemon the ability of checking a LVS server
+	  pool states. Keepalived can be sumarize as a LVS driving daemon.
+
+	  http://www.keepalived.org/
diff --git a/package/keepalived/keepalived.hash b/package/keepalived/keepalived.hash
new file mode 100644
index 0000000..e868587
--- /dev/null
+++ b/package/keepalived/keepalived.hash
@@ -0,0 +1,3 @@
+# From http://www.keepalived.org/download.html
+md5 744025d57c7f065c42fe925b0283897e	keepalived-1.3.2.tar.gz
+sha1	449f06dfce07e05c1ebd516d0545182e1416f264  keepalived-1.3.2.tar.gz
diff --git a/package/keepalived/keepalived.mk b/package/keepalived/keepalived.mk
new file mode 100644
index 0000000..4a8f1b1
--- /dev/null
+++ b/package/keepalived/keepalived.mk
@@ -0,0 +1,30 @@
+################################################################################
+#
+# keepalived
+#
+################################################################################
+
+KEEPALIVED_VERSION = 1.3.2
+KEEPALIVED_SITE = http://www.keepalived.org/software
+KEEPALIVED_DEPENDENCIES = host-pkgconf openssl popt
+KEEPALIVED_LICENSE = GPLv2+
+KEEPALIVED_LICENSE_FILES = COPYING
+KEEPALIVED_CONF_OPTS += --disable-dbus
+
+ifeq ($(BR2_PACKAGE_LIBNL),y)
+KEEPALIVED_DEPENDENCIES += libnfnetlink
+endif
+
+ifeq ($(BR2_PACKAGE_IPSET),y)
+KEEPALIVED_CONF_OPTS += --enable-libipset
+else
+KEEPALIVED_CONF_OPTS += --disable-libipset
+endif
+
+ifeq ($(BR2_PACKAGE_IPTABLES),y)
+KEEPALIVED_CONF_OPTS += --enable-libiptc
+else
+KEEPALIVED_CONF_OPTS += --disable-libiptc
+endif
+
+$(eval $(autotools-package))
-- 
1.9.1

[Buildroot] [PATCH v3 2/2] Added keepalived

[Ilias Apalodimas]

Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
---
 package/ipset/ipset.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk
index db4952b..bb40fee 100644
--- a/package/ipset/ipset.mk
+++ b/package/ipset/ipset.mk
@@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no
 IPSET_AUTORECONF = YES
 IPSET_LICENSE = GPLv2
 IPSET_LICENSE_FILES = COPYING
+IPSET_INSTALL_STAGING = YES
 
 $(eval $(autotools-package))
-- 
1.9.1

[Buildroot] [PATCH v3 2/2] Added keepalived

[Thomas Petazzoni]

Hello,

On Thu,  9 Feb 2017 22:37:16 +0200, Ilias Apalodimas wrote:
> Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
> ---
>  package/ipset/ipset.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk
> index db4952b..bb40fee 100644
> --- a/package/ipset/ipset.mk
> +++ b/package/ipset/ipset.mk
> @@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no
>  IPSET_AUTORECONF = YES
>  IPSET_LICENSE = GPLv2
>  IPSET_LICENSE_FILES = COPYING
> +IPSET_INSTALL_STAGING = YES

Why? ipset installs some libraries used by other packages?

In any case, this shouldn't be a separate commit, it should be part of
the commit adding the keepalived package.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v3 1/2] Added keepalived

[Thomas Petazzoni]

Hello,

The title of the commit should be:

	keepalived: new package

Other comments below.

On Thu,  9 Feb 2017 22:37:15 +0200, Ilias Apalodimas wrote:

> +KEEPALIVED_VERSION = 1.3.2
> +KEEPALIVED_SITE = http://www.keepalived.org/software
> +KEEPALIVED_DEPENDENCIES = host-pkgconf openssl popt
> +KEEPALIVED_LICENSE = GPLv2+
> +KEEPALIVED_LICENSE_FILES = COPYING
> +KEEPALIVED_CONF_OPTS += --disable-dbus
> +
> +ifeq ($(BR2_PACKAGE_IPSET),y)
> +KEEPALIVED_CONF_OPTS += --enable-libipset

Missing dependency on the ipset package.


> +else
> +KEEPALIVED_CONF_OPTS += --disable-libipset


> +endif
> +
> +ifeq ($(BR2_PACKAGE_IPTABLES),y)
> +KEEPALIVED_CONF_OPTS += --enable-libiptc

Missing dependency on the iptables package.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v3 2/2] Added keepalived

[Thomas Petazzoni]

Hello,

On Thu, 9 Feb 2017 21:42:09 +0100, Thomas Petazzoni wrote:

> On Thu,  9 Feb 2017 22:37:16 +0200, Ilias Apalodimas wrote:
> > Signed-off-by: Ilias Apalodimas <apalos@gmail.com>
> > ---
> >  package/ipset/ipset.mk | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk
> > index db4952b..bb40fee 100644
> > --- a/package/ipset/ipset.mk
> > +++ b/package/ipset/ipset.mk
> > @@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no
> >  IPSET_AUTORECONF = YES
> >  IPSET_LICENSE = GPLv2
> >  IPSET_LICENSE_FILES = COPYING
> > +IPSET_INSTALL_STAGING = YES  
> 
> Why? ipset installs some libraries used by other packages?
> 
> In any case, this shouldn't be a separate commit, it should be part of
> the commit adding the keepalived package.

My bad: I didn't realize this was touching the ipset package, not
keepalived. So here are better comments for this patch:

 1. It should come as a first patch in the series, *before* the patch
    adding the keepalived package, since the keepalived package uses
    the fact that ipset installs a library.

 2. The commit title should not be "Added keepalived", because this is
    not at all what this patch is doing. Please use a sensible commit
    title, and a commit log that explains why this is needed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com