From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wavpack: needs wchar support
Date: Fri, 17 Feb 2017 08:12:02 +0100 [thread overview]
Message-ID: <1487315522.2111.1.camel@embedded.rocks> (raw)
In-Reply-To: <f0dindxjng.ln2@ID-313208.user.individual.net>
Hi Thomas,
Hi Bernd,
On Fri, 2017-02-17 at 06:06 +0100, Bernd Kuhls wrote:
> Hi Thomas,
>
> Am Thu, 16 Feb 2017 22:19:07 +0100 schrieb Thomas Petazzoni:
>
> > None of the places that select wavpack need to be fixed for the
> > wchar
> > dependency?
> >
> > package/gstreamer/gst-plugins-good/Config.in:???select
> > BR2_PACKAGE_WAVPACK
>
> "depends on BR2_USE_WCHAR" needs to be backported, same was valid
> for BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC.
>
> > package/gstreamer1/gst1-plugins-good/Config.in: select
> > BR2_PACKAGE_WAVPACK
>
> "depends on BR2_USE_WCHAR" needs to be backported, same was valid
> for BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB.
>
> > package/mpd/Config.in:??select BR2_PACKAGE_WAVPACK
>
> mpd itself depends on BR2_USE_WCHAR, no backport needed.
>
Upstream committed a fix [1] (thanks to Thomas for reporting the issue)
which drops the dependency on wchar. Maybe we should apply this to
remove BR2_USE_WCHAR?
[1] https://github.com/dbry/WavPack/commit/876fc3f3907e871d0938ac6c8c52
52f5f31abd1f
J?rg
next prev parent reply other threads:[~2017-02-17 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 20:41 [Buildroot] [PATCH 1/2] wavpack: needs wchar support Jörg Krause
2017-02-16 20:41 ` [Buildroot] [PATCH 2/2] wavpack: properly wrap help text Jörg Krause
2017-02-16 21:19 ` [Buildroot] [PATCH 1/2] wavpack: needs wchar support Thomas Petazzoni
2017-02-17 5:06 ` Bernd Kuhls
2017-02-17 7:12 ` Jörg Krause [this message]
2017-02-17 13:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487315522.2111.1.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox