From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wavpack: needs wchar support
Date: Thu, 16 Feb 2017 22:19:07 +0100 [thread overview]
Message-ID: <20170216221907.57ac4b8d@free-electrons.com> (raw)
In-Reply-To: <20170216204116.2212-1-joerg.krause@embedded.rocks>
Hello,
On Thu, 16 Feb 2017 21:41:15 +0100, J?rg Krause wrote:
> Building wavpack using a toolchain without wchar support fails:
>
> ```
> import_id3.c:37:34: error: unknown type name 'wchar_t'
> ```
>
> Fixes:
> http://autobuild.buildroot.net/results/9a6/9a693f5b798571917f36cfb7661e2f2638aac550/
> http://autobuild.buildroot.net/results/44c/44c8227043045baf4f043da44b8129e43dfff687/
> http://autobuild.buildroot.net/results/a80/a80221dcc0860046ebdf0bbf454e056b1e20df83/
> .. and more.
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
This dependency is only needed for one specific tool in wavpack added
by the recent bump to 5.1.0. So I've reported this issue upstream:
https://github.com/dbry/WavPack/issues/19
But OK, I agree we don't really care if wavpack needs wchar support, so
we certainly don't need to wait for the answer to this upstream bug
report.
> diff --git a/package/wavpack/Config.in b/package/wavpack/Config.in
> index 1ef3e420d..5a27b2e15 100644
> --- a/package/wavpack/Config.in
> +++ b/package/wavpack/Config.in
> @@ -1,8 +1,12 @@
> config BR2_PACKAGE_WAVPACK
> bool "wavpack"
> + depends on BR2_USE_WCHAR
None of the places that select wavpack need to be fixed for the wchar
dependency?
package/gstreamer/gst-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK
package/gstreamer1/gst1-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK
package/mpd/Config.in: select BR2_PACKAGE_WAVPACK
From a quick look, it seems to be OK, but it would have been to
indicate it in the commit log (and maybe update the comments in those
packages to explain why we have the wchar dependency).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-16 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 20:41 [Buildroot] [PATCH 1/2] wavpack: needs wchar support Jörg Krause
2017-02-16 20:41 ` [Buildroot] [PATCH 2/2] wavpack: properly wrap help text Jörg Krause
2017-02-16 21:19 ` Thomas Petazzoni [this message]
2017-02-17 5:06 ` [Buildroot] [PATCH 1/2] wavpack: needs wchar support Bernd Kuhls
2017-02-17 7:12 ` Jörg Krause
2017-02-17 13:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216221907.57ac4b8d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox