[Buildroot] [PATCH 4/4] bctoolbox: disable rpath

["Jörg Krause" <joerg.krause@embedded.rocks>]

Hi,

On Wed, 2017-02-15 at 09:56 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 15 Feb 2017 07:28:46 +0200, Baruch Siach wrote:
> > Hi J?rg,
> > 
> > On Tue, Feb 14, 2017 at 11:44:02PM +0100, J?rg Krause wrote:
> > > By default, bctoolbox adds the rpath to the shared library.
> > > Prevent this
> > > by setting `CMAKE_SKIP_RPATH` [1] to a true value.
> > > 
> > > [1] https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_RPATH
> > > .html
> > > 
> > > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > > ---
> > > ?package/bctoolbox/bctoolbox.mk | 5 ++++-
> > > ?1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/package/bctoolbox/bctoolbox.mk
> > > b/package/bctoolbox/bctoolbox.mk
> > > index 5eea0575f..76737aa3c 100644
> > > --- a/package/bctoolbox/bctoolbox.mk
> > > +++ b/package/bctoolbox/bctoolbox.mk
> > > @@ -11,11 +11,14 @@ BCTOOLBOX_LICENSE_FILES = COPYING
> > > ?BCTOOLBOX_DEPENDENCIES = mbedtls
> > > ?BCTOOLBOX_INSTALL_STAGING = YES
> > > ?
> > > +# Set CMAKE_SKIP_RPATH to prevent bctoolbox from adding the
> > > rpath to
> > > +# shared library.
> > > ?BCTOOLBOX_CONF_OPTS = \
> > > ?	-DENABLE_STRICT=OFF \
> > > ?	-DENABLE_TESTS_COMPONENT=OFF \
> > > ?	-DENABLE_TESTS=OFF \
> > > -	-DGIT_EXECUTABLE=OFF
> > > +	-DGIT_EXECUTABLE=OFF \
> > > +	-DCMAKE_SKIP_RPATH=ON??
> > 
> > Shouldn't we have this in package/pkg-cmake.mk? Samuel?
> 
> Indeed, it's a generic CMake option, so it should be in
> package/pkg-cmake.mk IMO.

opencv and opencv3 both set this option on a package level.

> Worth mentioning that there is both CMAKE_SKIP_RPATH and
> CMAKE_SKIP_INSTALL_RPATH. The former skips adding the rpath during
> both
> the build and install steps, which prevents from running the binary
> from the build directory. The latter only skips the rpath during the
> install step. But since we're cross-compiling, running on the host
> machine from the build directory anyway doesn't make sense. So
> CMAKE_SKIP_RPATH is OK.
> 
> See https://cmake.org/cmake/help/v3.0/variable/CMAKE_SKIP_RPATH.html.

Samuel argues not to force this option by the infrastructure. I am 	
not sure how do we handle this properly. So, what shall we do?

Best regards,
J?rg Krause