From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] bctoolbox: disable rpath
Date: Sun, 19 Feb 2017 18:44:32 +0100 [thread overview]
Message-ID: <20170219184432.58c82ea1@free-electrons.com> (raw)
In-Reply-To: <1487516855.17793.1.camel@embedded.rocks>
Hello,
On Sun, 19 Feb 2017 16:07:35 +0100, J?rg Krause wrote:
> > Worth mentioning that there is both CMAKE_SKIP_RPATH and
> > CMAKE_SKIP_INSTALL_RPATH. The former skips adding the rpath during
> > both
> > the build and install steps, which prevents from running the binary
> > from the build directory. The latter only skips the rpath during the
> > install step. But since we're cross-compiling, running on the host
> > machine from the build directory anyway doesn't make sense. So
> > CMAKE_SKIP_RPATH is OK.
> >
> > See https://cmake.org/cmake/help/v3.0/variable/CMAKE_SKIP_RPATH.html.
>
> Samuel argues not to force this option by the infrastructure. I am
> not sure how do we handle this properly. So, what shall we do?
As I said in my second e-mail (sent after reading Samuel's answer),
Samuel is probably correct. Skipping the rpath in *all* cases may not
be correct, so we have to do it at the per-package level, like your
patch does.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-19 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 22:43 [Buildroot] [PATCH 1/4] Revert "bctoolbox: fix typos and logic error" Jörg Krause
2017-02-14 22:44 ` [Buildroot] [PATCH 2/4] bctoolbox: add patch to fix static linking Jörg Krause
2017-02-14 22:44 ` [Buildroot] [PATCH 3/4] bctoolbox: fix mbedtls/polarssl dependency Jörg Krause
2017-02-14 22:44 ` [Buildroot] [PATCH 4/4] bctoolbox: disable rpath Jörg Krause
2017-02-15 5:28 ` Baruch Siach
2017-02-15 6:12 ` Samuel Martin
2017-02-15 8:58 ` Thomas Petazzoni
2017-02-15 8:56 ` Thomas Petazzoni
2017-02-19 15:07 ` Jörg Krause
2017-02-19 17:44 ` Thomas Petazzoni [this message]
2017-02-20 21:25 ` [Buildroot] [PATCH 1/4] Revert "bctoolbox: fix typos and logic error" Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170219184432.58c82ea1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox