[Buildroot] [PATCH] dependencies/cmake: blacklist cmake 3.7

["Jörg Krause" <joerg.krause@embedded.rocks>]

On Mon, 2017-02-27 at 21:53 +0100, Yann E. MORIN wrote:
> J?rg, All,
> 
> On 2017-02-27 19:30 +0100, Yann E. MORIN spake thusly:
> > On 2017-02-27 18:25 +0100, Yann E. MORIN spake thusly:
> > > On 2017-02-27 18:12 +0100, J?rg Krause spake thusly:
> > > > On Sun, 2017-02-26 at 23:42 +0100, Yann E. MORIN wrote:
> > > > > cmake-3.7 has a bug in how it handles rpath, linking with
> > > > > libraries
> > > > > from
> > > > > the host.
> > > > > 
> > > > > Until we completely understand the issue, just blacklist
> > > > > cmake-3.7.
> > > > > 
> > > > > The issue has been reported upstream:
> > > > > ????http://public.kitware.com/pipermail/cmake/2017-February/0
> > > > > 64970.ht
> > > > > ml
> > > > 
> > > > Brad King from Kitware replied today [1]. In short, Brad does
> > > > not think
> > > > there anything wrong about handling the rpath and supposes to
> > > > load a
> > > > custom platform cmake file instead of the Linux one.
> > > > 
> > > > [1] http://public.kitware.com/pipermail/cmake/2017-February/065
> > > > 063.html
> > > 
> > > OK, so what we would have to do (basically):
> > > 
> > > ? - copy Modules/Platform/Linux.cmake to
> > > Modules/Platform/Buildroot.cmake
> > > 
> > > ? - tweak that file so that the two settings (lib32 and lib64)
> > > are now
> > > ????FALSE in that file
> > > 
> > > ? - tweak our support/misc/toolchain.cmake to
> > > set(CMAKE_SYSTEM_NAME Buildroot)
> > > 
> > > and we'd be all good?
> > > 
> > > Or alternatively:
> > > 
> > > ? - add Modules/Platform/Buildroot.cmake, which:
> > > ????- includes Modules/Platform/Linux.cmake
> > > ????- sets the the two settings (lib32 and lib64) to FALSE
> > > 
> > > ? - tweak our support/misc/toolchain.cmake to
> > > set(CMAKE_SYSTEM_NAME Buildroot)
> > 
> > So I tested that last solution, and it indeed fixes the build.
> > Woot!
> > 
> > Of course, this is only for when we build out own cmake, not when
> > we use
> > the host pre-installed one. I'll try to see tonight if we can do
> > similar
> > for it, too.
> 
> It seems that we could set CMAKE_MODULE_PATH to that effect.

Sounds promising!

> More testing under way...

Thanks!