Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dependencies/cmake: blacklist cmake 3.7
Date: Mon, 27 Feb 2017 21:59:23 +0100	[thread overview]
Message-ID: <20170227205923.GE17670@free.fr> (raw)
In-Reply-To: <20170227183547.GA1242@megas.kitware.com>

Ben, All,

On 2017-02-27 13:35 -0500, Ben Boeckel spake thusly:
> On Mon, Feb 27, 2017 at 19:30:16 +0100, Yann E. MORIN wrote:
> > Of course, this is only for when we build out own cmake, not when we use
> > the host pre-installed one. I'll try to see tonight if we can do similar
> > for it, too.
> 
> It may make sense to support this upstream. CMake already has platform
> files for things such as Cray and Android (among others) which are just
> special kinds of Linux, like Buildroot.
> 
> How often does that toolchain file change? Or does it depend on
> Buildroot settings?

The toolchainfile.cmake is really specific to one build: it contains the
path to the compiler, linker... It contains place-holders that get
replaced by a sed invocation:

    https://git.buildroot.org/buildroot/tree/package/pkg-cmake.mk#n236

However, the Modules/Platform/Buildroot.cmake would be just as simple
as (which is what I use currently):

    include(Platform/Linux)
    set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB32_PATHS FALSE)
    set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB64_PATHS FALSE)

I don;t see that changing anytime soon. So, if that would be aceptable
for upstream, then we could submit it, yes.

However, I wonder if that's worth the effort...

After all, this is a setting specific to us. I would have a hard time
arguing that upstream cmake should carry all such files for all
imaginable buildsystems.

And if the solution is that simple and also works for host pre-installed
cmake, then we can carry that ourselves, I believe.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-02-27 20:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26 22:42 [Buildroot] [PATCH] dependencies/cmake: blacklist cmake 3.7 Yann E. MORIN
2017-02-27  4:43 ` Baruch Siach
2017-02-27 15:51   ` Yann E. MORIN
2017-02-27 17:12 ` Jörg Krause
2017-02-27 17:25   ` Yann E. MORIN
2017-02-27 17:31     ` Baruch Siach
2017-02-27 17:41       ` Yann E. MORIN
2017-02-27 18:30     ` Yann E. MORIN
2017-02-27 18:35       ` Ben Boeckel
2017-02-27 20:59         ` Yann E. MORIN [this message]
2017-02-27 21:13           ` Jörg Krause
2017-02-27 20:53       ` Yann E. MORIN
2017-02-27 21:02         ` Jörg Krause
2017-02-27 20:04     ` Jörg Krause
2017-02-27 20:08       ` Ben Boeckel
2017-02-27 20:24         ` Jörg Krause
2017-02-27 20:40           ` Ben Boeckel
2017-02-27 20:56         ` Jörg Krause
2017-02-28  8:51 ` Peter Korsgaard
2017-02-28 16:16   ` Yann E. MORIN
2017-02-28 16:38     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227205923.GE17670@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox