[Buildroot] [PATCH] libiio: Disable MATLAB Bindings on Target

[Buildroot] [PATCH] libiio: Disable MATLAB Bindings on Target

[Matthew Fornero]

If building on a machine with MATLAB installed, the MATLAB bindings will
default to ON, which is not the desired behavior for a cross build.

The bindings are designed to be called from within MATLAB, and we are
not currently running MATLAB on buildroot-generated targets.

This does not preclude the use of the bindings from a host connecting
over the network backend (assuming libiio on the host has the bindings
enabled).

Signed-off-by: Matthew Fornero <mfornero@mathworks.com>
---
 package/libiio/libiio.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libiio/libiio.mk b/package/libiio/libiio.mk
index 8977610..aaa6c70 100644
--- a/package/libiio/libiio.mk
+++ b/package/libiio/libiio.mk
@@ -14,6 +14,7 @@ LIBIIO_CONF_OPTS = -DENABLE_IPV6=ON \
 	-DWITH_LOCAL_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_LOCAL_BACKEND),ON,OFF) \
 	-DWITH_NETWORK_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_NETWORK_BACKEND),ON,OFF) \
 	-DWITH_MATLAB_BINDINGS_API=OFF \
+	-DMATLAB_BINDINGS=OFF \
 	-DINSTALL_UDEV_RULE=$(if $(BR2_PACKAGE_HAS_UDEV),ON,OFF) \
 	-DWITH_TESTS=$(if $(BR2_PACKAGE_LIBIIO_TESTS),ON,OFF) \
 	-DWITH_DOC=OFF
-- 
2.1.4

[Buildroot] [PATCH] libiio: Disable MATLAB Bindings on Target

[Cercueil, Paul]

Makes sense.

Acked-By: Paul Cercueil <paul.cercueil@analog.com>

-- 
???__????____??____
? /__\??(??_ \(_??_)??| Paul Cercueil        paul.cercueil at analog.com
?/(__)\??)(_) )_)(_???| Software Engineer    github.com/pcercuei
(__)(__)(____/(____)??| Analog Devices, S.L. Paterna (Valencia) SPAIN

Le lundi 13 mars 2017 ? 15:35 -0400, Matthew Fornero a ?crit?:
> If building on a machine with MATLAB installed, the MATLAB bindings
> will
> default to ON, which is not the desired behavior for a cross build.
> 
> The bindings are designed to be called from within MATLAB, and we are
> not currently running MATLAB on buildroot-generated targets.
> 
> This does not preclude the use of the bindings from a host connecting
> over the network backend (assuming libiio on the host has the
> bindings
> enabled).
> 
> Signed-off-by: Matthew Fornero <mfornero@mathworks.com>
> ---
> ?package/libiio/libiio.mk | 1 +
> ?1 file changed, 1 insertion(+)
> 
> diff --git a/package/libiio/libiio.mk b/package/libiio/libiio.mk
> index 8977610..aaa6c70 100644
> --- a/package/libiio/libiio.mk
> +++ b/package/libiio/libiio.mk
> @@ -14,6 +14,7 @@ LIBIIO_CONF_OPTS = -DENABLE_IPV6=ON \
> ?	-DWITH_LOCAL_BACKEND=$(if
> $(BR2_PACKAGE_LIBIIO_LOCAL_BACKEND),ON,OFF) \
> ?	-DWITH_NETWORK_BACKEND=$(if
> $(BR2_PACKAGE_LIBIIO_NETWORK_BACKEND),ON,OFF) \
> ?	-DWITH_MATLAB_BINDINGS_API=OFF \
> +	-DMATLAB_BINDINGS=OFF \
> ?	-DINSTALL_UDEV_RULE=$(if $(BR2_PACKAGE_HAS_UDEV),ON,OFF) \
> ?	-DWITH_TESTS=$(if $(BR2_PACKAGE_LIBIIO_TESTS),ON,OFF) \
> ?	-DWITH_DOC=OFF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170314/ce4dda88/attachment.asc>

[Buildroot] [PATCH] libiio: Disable MATLAB Bindings on Target

[Thomas Petazzoni]

Hello,

On Mon, 13 Mar 2017 15:35:02 -0400, Matthew Fornero wrote:
> If building on a machine with MATLAB installed, the MATLAB bindings will
> default to ON, which is not the desired behavior for a cross build.
> 
> The bindings are designed to be called from within MATLAB, and we are
> not currently running MATLAB on buildroot-generated targets.
> 
> This does not preclude the use of the bindings from a host connecting
> over the network backend (assuming libiio on the host has the bindings
> enabled).
> 
> Signed-off-by: Matthew Fornero <mfornero@mathworks.com>
> ---
>  package/libiio/libiio.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, after slightly tweaking the commit title. Thanks!

Peter: perhaps we want this for the LTS branch? Not sure.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] libiio: Disable MATLAB Bindings on Target

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Mon, 13 Mar 2017 15:35:02 -0400, Matthew Fornero wrote:
 >> If building on a machine with MATLAB installed, the MATLAB bindings will
 >> default to ON, which is not the desired behavior for a cross build.
 >> 
 >> The bindings are designed to be called from within MATLAB, and we are
 >> not currently running MATLAB on buildroot-generated targets.
 >> 
 >> This does not preclude the use of the bindings from a host connecting
 >> over the network backend (assuming libiio on the host has the bindings
 >> enabled).
 >> 
 >> Signed-off-by: Matthew Fornero <mfornero@mathworks.com>
 >> ---
 >> package/libiio/libiio.mk | 1 +
 >> 1 file changed, 1 insertion(+)

 > Applied to master, after slightly tweaking the commit title. Thanks!

 > Peter: perhaps we want this for the LTS branch? Not sure.

It seems pretty safe to add it. Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard