* [Buildroot] [PATCH 1/4] libscrypt: New package
@ 2017-02-09 13:45 Stefan Sørensen
2017-02-09 13:45 ` [Buildroot] [PATCH 2/4] cracklib: " Stefan Sørensen
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Stefan Sørensen @ 2017-02-09 13:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
---
package/Config.in | 1 +
package/libscrypt/Config.in | 7 +++++++
package/libscrypt/libscrypt.hash | 2 ++
package/libscrypt/libscrypt.mk | 33 +++++++++++++++++++++++++++++++++
4 files changed, 43 insertions(+)
create mode 100644 package/libscrypt/Config.in
create mode 100644 package/libscrypt/libscrypt.hash
create mode 100644 package/libscrypt/libscrypt.mk
diff --git a/package/Config.in b/package/Config.in
index 114a5ad..4a95749 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -928,6 +928,7 @@ menu "Crypto"
source "package/libmcrypt/Config.in"
source "package/libmhash/Config.in"
source "package/libnss/Config.in"
+ source "package/libscrypt/Config.in"
source "package/libsecret/Config.in"
source "package/libsha1/Config.in"
source "package/libsodium/Config.in"
diff --git a/package/libscrypt/Config.in b/package/libscrypt/Config.in
new file mode 100644
index 0000000..c443d0d
--- /dev/null
+++ b/package/libscrypt/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBSCRYPT
+ bool "libscrypt"
+ help
+ This is a library that implements the secure password
+ hashing function "scrypt".
+
+ http://www.lolware.net/libscrypt.html
diff --git a/package/libscrypt/libscrypt.hash b/package/libscrypt/libscrypt.hash
new file mode 100644
index 0000000..920d752
--- /dev/null
+++ b/package/libscrypt/libscrypt.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 68e377e79745c10d489b759b970e52d819dbb80dd8ca61f8c975185df3f457d3 v1.21.tar.gz
diff --git a/package/libscrypt/libscrypt.mk b/package/libscrypt/libscrypt.mk
new file mode 100644
index 0000000..5da9928
--- /dev/null
+++ b/package/libscrypt/libscrypt.mk
@@ -0,0 +1,33 @@
+################################################################################
+#
+# libscrypt
+#
+################################################################################
+
+LIBSCRYPT_VERSION = 1.21
+LIBSCRYPT_SOURCE = v$(LIBSCRYPT_VERSION).tar.gz
+LIBSCRYPT_SITE = https://github.com/technion/libscrypt/archive
+LIBSCRYPT_LICENSE = BSD
+LIBSCRYPT_INSTALL_STAGING = YES
+
+define LIBSCRYPT_DISABLE_STACK_PROTECTOR
+ $(SED) 's/-fstack-protector//g' $(@D)/Makefile
+endef
+
+ifeq ($(BR2_TOOLCHAIN_HAS_SSP),)
+LIBSCRYPT_POST_EXTRACT_HOOKS += LIBSCRYPT_DISABLE_STACK_PROTECTOR
+endif
+
+define LIBSCRYPT_BUILD_CMDS
+ $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
+endef
+
+define LIBSCRYPT_INSTALL_STAGING_CMDS
+ $(MAKE) -C $(@D) PREFIX=/usr DESTDIR=$(STAGING_DIR) install
+endef
+
+define LIBSCRYPT_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) PREFIX=/usr DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/4] cracklib: New package
2017-02-09 13:45 [Buildroot] [PATCH 1/4] libscrypt: New package Stefan Sørensen
@ 2017-02-09 13:45 ` Stefan Sørensen
2017-04-01 21:15 ` Thomas Petazzoni
2017-02-09 13:45 ` [Buildroot] [PATCH 3/4] libpwquality: " Stefan Sørensen
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Stefan Sørensen @ 2017-02-09 13:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
---
package/Config.in | 1 +
package/cracklib/Config.in | 28 ++++++++++++++++++++++++++++
package/cracklib/cracklib.hash | 3 +++
package/cracklib/cracklib.mk | 39 +++++++++++++++++++++++++++++++++++++++
4 files changed, 71 insertions(+)
create mode 100644 package/cracklib/Config.in
create mode 100644 package/cracklib/cracklib.hash
create mode 100644 package/cracklib/cracklib.mk
diff --git a/package/Config.in b/package/Config.in
index 4a95749..a149936 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1317,6 +1317,7 @@ menu "Other"
source "package/clapack/Config.in"
source "package/classpath/Config.in"
source "package/cppcms/Config.in"
+ source "package/cracklib/Config.in"
source "package/dawgdic/Config.in"
source "package/ding-libs/Config.in"
source "package/eigen/Config.in"
diff --git a/package/cracklib/Config.in b/package/cracklib/Config.in
new file mode 100644
index 0000000..cf428fd
--- /dev/null
+++ b/package/cracklib/Config.in
@@ -0,0 +1,28 @@
+config BR2_PACKAGE_CRACKLIB
+ bool "cracklib"
+ help
+ CrackLib tests passwords to determine whether they match
+ certain security-oriented characteristics, with the purpose
+ of stopping users from choosing passwords that are easy to
+ guess. CrackLib performs several tests on passwords: it
+ tries to generate words from a username and gecos entry and
+ checks those words against the password; it checks for
+ simplistic patterns in passwords; and it checks for the
+ password in a dictionary.
+
+ https://github.com/cracklib/cracklib
+
+if BR2_PACKAGE_CRACKLIB
+
+config BR2_PACKAGE_CRACKLIB_TOOLS
+ bool "install tools"
+ help
+ Install cracklib command line tools for creating dicts.
+
+config BR2_PACKAGE_CRACKLIB_FULL_DICT
+ bool "full dict"
+ help
+ Install the full cracklib dict (requires about 8Mb extra target
+ space).
+
+endif
diff --git a/package/cracklib/cracklib.hash b/package/cracklib/cracklib.hash
new file mode 100644
index 0000000..3038a47
--- /dev/null
+++ b/package/cracklib/cracklib.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 17cf76943de272fd579ed831a1fd85339b393f8d00bf9e0d17c91e972f583343 cracklib-2.9.6.tar.gz
+sha256 27973245225eeb9d0090e97f3dea4197dec99b64d9d3a791a60298f3b021824c cracklib-words-2.9.6.gz
diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
new file mode 100644
index 0000000..c8e7fd5
--- /dev/null
+++ b/package/cracklib/cracklib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# cracklib
+#
+################################################################################
+
+CRACKLIB_VERSION = 2.9.6
+CRACKLIB_SITE = https://github.com/cracklib/cracklib/releases/download/cracklib-$(CRACKLIB_VERSION)
+CRACKLIB_LICENSE = LGPLv2+
+CRACKLIB_LICENSE_FILES = COPYING.LIB README-LICENSE
+CRACKLIB_INSTALL_STAGING = YES
+CRACKLIB_DEPENDENCIES = host-cracklib
+ifeq ($(BR2_PACKAGE_CRACKLIB_FULL_DICT),y)
+CRACKLIB_EXTRA_DOWNLOADS = cracklib-words-$(CRACKLIB_VERSION).gz
+endif
+
+ifeq ($(BR2_PACKAGE_CRACKLIB_TOOLS),)
+define CRACKLIB_REMOVE_TOOLS
+ rm -f $(TARGET_DIR)/usr/sbin/*cracklib*
+endef
+
+CRACKLIB_POST_INSTALL_TARGET_HOOKS += CRACKLIB_REMOVE_TOOLS
+endif
+
+ifeq ($(BR2_PACKAGE_CRACKLIB_FULL_DICT),y)
+CRACKLIB_DICT_SOURCE = $(DL_DIR)/cracklib-words-$(CRACKLIB_VERSION).gz
+else
+CRACKLIB_DICT_SOURCE = $(@D)/dicts/cracklib-small
+endif
+
+define CRACKLIB_BUILD_DICT
+ cracklib-format $(CRACKLIB_DICT_SOURCE) | cracklib-packer $(TARGET_DIR)/usr/share/cracklib/pw_dict
+ rm $(TARGET_DIR)/usr/share/cracklib/cracklib-small
+endef
+
+CRACKLIB_POST_INSTALL_TARGET_HOOKS += CRACKLIB_BUILD_DICT
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/4] libpwquality: New package
2017-02-09 13:45 [Buildroot] [PATCH 1/4] libscrypt: New package Stefan Sørensen
2017-02-09 13:45 ` [Buildroot] [PATCH 2/4] cracklib: " Stefan Sørensen
@ 2017-02-09 13:45 ` Stefan Sørensen
2017-04-01 21:21 ` Thomas Petazzoni
2017-02-09 13:45 ` [Buildroot] [PATCH 4/4] DEVELOPERS: Add Stefan Sørensen for cracklib, libpwquality and libscrypt Stefan Sørensen
2017-03-12 22:57 ` [Buildroot] [PATCH 1/4] libscrypt: New package Thomas Petazzoni
3 siblings, 1 reply; 9+ messages in thread
From: Stefan Sørensen @ 2017-02-09 13:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
---
package/Config.in | 1 +
...ith-disable-nls-on-platforms-without-libi.patch | 42 ++++++++++++++++++++++
...leak-in-settings-when-using-bad-word-list.patch | 23 ++++++++++++
package/libpwquality/Config.in | 18 ++++++++++
package/libpwquality/libpwquality.hash | 2 ++
package/libpwquality/libpwquality.mk | 24 +++++++++++++
6 files changed, 110 insertions(+)
create mode 100644 package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch
create mode 100644 package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch
create mode 100644 package/libpwquality/Config.in
create mode 100644 package/libpwquality/libpwquality.hash
create mode 100644 package/libpwquality/libpwquality.mk
diff --git a/package/Config.in b/package/Config.in
index a149936..3b31eab 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1360,6 +1360,7 @@ menu "Other"
source "package/libplist/Config.in"
source "package/libpthread-stubs/Config.in"
source "package/libpthsem/Config.in"
+ source "package/libpwquality/Config.in"
source "package/libseccomp/Config.in"
source "package/libsigc/Config.in"
source "package/libsigsegv/Config.in"
diff --git a/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch b/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch
new file mode 100644
index 0000000..2ce79b9
--- /dev/null
+++ b/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch
@@ -0,0 +1,42 @@
+Status: Upstream
+
+Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
+
+# HG changeset patch
+# User Stefan S?rensen <stefan.sorensen@spectralink.com>
+# Date 1486030609 -3600
+# Thu Feb 02 11:16:49 2017 +0100
+# Node ID 3a716ca2bbf90cde4d86ef3c4597884d6a416525
+# Parent 79ca3b91513faf3bd03464808d107b71ba5d6c3b
+Fix build with --disable-nls on platforms without libintl included in libc.
+
+diff -r 79ca3b91513f -r 3a716ca2bbf9 src/pwmake.c
+--- a/src/pwmake.c Tue Nov 01 15:16:54 2016 +0100
++++ b/src/pwmake.c Thu Feb 02 11:16:49 2017 +0100
+@@ -33,9 +33,11 @@
+ int bits;
+ void *auxerror;
+
++#ifdef ENABLE_NLS
+ setlocale(LC_ALL, "");
+ bindtextdomain("libpwquality", "/usr/share/locale");
+ textdomain("libpwquality");
++#endif
+
+ if (argc != 2) {
+ usage(basename(argv[0]));
+diff -r 79ca3b91513f -r 3a716ca2bbf9 src/pwscore.c
+--- a/src/pwscore.c Tue Nov 01 15:16:54 2016 +0100
++++ b/src/pwscore.c Thu Feb 02 11:16:49 2017 +0100
+@@ -34,9 +34,11 @@
+ size_t len;
+ char *user = NULL;
+
++#ifdef ENABLE_NLS
+ setlocale(LC_ALL, "");
+ bindtextdomain("libpwquality", "/usr/share/locale");
+ textdomain("libpwquality");
++#endif
+
+ if (argc > 2) {
+ usage(basename(argv[0]));
diff --git a/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch b/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch
new file mode 100644
index 0000000..fe7b9e8
--- /dev/null
+++ b/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch
@@ -0,0 +1,23 @@
+Status: Upstream
+
+Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
+
+# HG changeset patch
+# User Stefan S?rensen <stefan.sorensen@spectralink.com>
+# Date 1486030646 -3600
+# Thu Feb 02 11:17:26 2017 +0100
+# Node ID 7d2ba499cbd538065931251042ce93b8e5f4edf2
+# Parent 3a716ca2bbf90cde4d86ef3c4597884d6a416525
+Fix memory leak in settings when using bad word list.
+
+diff -r 3a716ca2bbf9 -r 7d2ba499cbd5 src/settings.c
+--- a/src/settings.c Thu Feb 02 11:16:49 2017 +0100
++++ b/src/settings.c Thu Feb 02 11:17:26 2017 +0100
+@@ -46,6 +46,7 @@
+ {
+ if (pwq) {
+ free(pwq->dict_path);
++ free(pwq->bad_words);
+ free(pwq);
+ }
+ }
diff --git a/package/libpwquality/Config.in b/package/libpwquality/Config.in
new file mode 100644
index 0000000..da295f0
--- /dev/null
+++ b/package/libpwquality/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_LIBPWQUALITY
+ bool "libpwquality"
+ help
+ This is a library for password quality checks and generation
+ of random passwords that pass the checks. This library uses
+ the cracklib and cracklib dictionaries to perform some of
+ the checks.
+
+ https://fedorahosted.org/libpwquality/
+
+if BR2_PACKAGE_LIBPWQUALITY
+
+config BR2_PACKAGE_LIBPWQUALITY_TOOLS
+ bool "install tools"
+ help
+ Install libpwquality command line tools generating/checking passwords.
+
+endif
diff --git a/package/libpwquality/libpwquality.hash b/package/libpwquality/libpwquality.hash
new file mode 100644
index 0000000..0e3f9e3
--- /dev/null
+++ b/package/libpwquality/libpwquality.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 74d2ea90e103323c1f2d6a6cc9617cdae6877573eddb31aaf31a40f354cc2d2a libpwquality-1.3.0.tar.bz2
diff --git a/package/libpwquality/libpwquality.mk b/package/libpwquality/libpwquality.mk
new file mode 100644
index 0000000..aa08aff
--- /dev/null
+++ b/package/libpwquality/libpwquality.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# libpwquality
+#
+################################################################################
+
+LIBPWQUALITY_VERSION = 1.3.0
+LIBPWQUALITY_SOURCE = libpwquality-$(LIBPWQUALITY_VERSION).tar.bz2
+LIBPWQUALITY_SITE = https://fedorahosted.org/releases/l/i/libpwquality
+LIBPWQUALITY_LICENSE = BSD or LGPLv2+
+LIBPWQUALITY_INSTALL_STAGING = YES
+LIBPWQUALITY_DEPENDENCIES = cracklib
+LIBPWQUALITY_AUTORECONF = YES
+
+ifeq ($(BR2_PACKAGE_LIBPWQUALITY_TOOLS),)
+define LIBPWQUALITY_REMOVE_TOOLS
+ rm -f $(TARGET_DIR)/usr/bin/pwmake
+ rm -f $(TARGET_DIR)/usr/bin/pwscore
+endef
+
+LIBPWQUALITY_POST_INSTALL_TARGET_HOOKS += LIBPWQUALITY_REMOVE_TOOLS
+endif
+
+$(eval $(autotools-package))
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 4/4] DEVELOPERS: Add Stefan Sørensen for cracklib, libpwquality and libscrypt.
2017-02-09 13:45 [Buildroot] [PATCH 1/4] libscrypt: New package Stefan Sørensen
2017-02-09 13:45 ` [Buildroot] [PATCH 2/4] cracklib: " Stefan Sørensen
2017-02-09 13:45 ` [Buildroot] [PATCH 3/4] libpwquality: " Stefan Sørensen
@ 2017-02-09 13:45 ` Stefan Sørensen
2017-03-12 22:57 ` [Buildroot] [PATCH 1/4] libscrypt: New package Thomas Petazzoni
3 siblings, 0 replies; 9+ messages in thread
From: Stefan Sørensen @ 2017-02-09 13:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
---
DEVELOPERS | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/DEVELOPERS b/DEVELOPERS
index b8ccb46..c2b47a8 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1417,6 +1417,11 @@ F: package/libtasn1/
F: package/proxychains-ng/
F: package/yasm/
+N: Stefan S?rensen <stefan.sorensen@spectralink.com>
+F: package/cracklib/
+F: package/libpwquality/
+F: package/libscrypt/
+
N: Stephan Hoffmann <sho@relinux.de>
F: package/cache-calibrator/
F: package/gtest/
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/4] libscrypt: New package
2017-02-09 13:45 [Buildroot] [PATCH 1/4] libscrypt: New package Stefan Sørensen
` (2 preceding siblings ...)
2017-02-09 13:45 ` [Buildroot] [PATCH 4/4] DEVELOPERS: Add Stefan Sørensen for cracklib, libpwquality and libscrypt Stefan Sørensen
@ 2017-03-12 22:57 ` Thomas Petazzoni
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2017-03-12 22:57 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 9 Feb 2017 14:45:55 +0100, Stefan S?rensen wrote:
> Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
> ---
> package/Config.in | 1 +
> package/libscrypt/Config.in | 7 +++++++
> package/libscrypt/libscrypt.hash | 2 ++
> package/libscrypt/libscrypt.mk | 33 +++++++++++++++++++++++++++++++++
> 4 files changed, 43 insertions(+)
> create mode 100644 package/libscrypt/Config.in
> create mode 100644 package/libscrypt/libscrypt.hash
> create mode 100644 package/libscrypt/libscrypt.mk
Thanks for your contribution, I've applied to master, after doing the
following changes:
[Thomas:
- Add entry to DEVELOPERS file for the new package
- Add dependency on !BR2_STATIC_LIBS, because the Makefile
unconditionally builds a shared library
- Use the "github" helper function to define <pkg>_SITE, get rid of
<pkg>_SOURCE.
- License is BSD-2c, not just BSD.
- Add <pkg>_LICENSE_FILES variable.
- Define LIBSCRYPT_DISABLE_STACK_PROTECTOR inside the
BR2_TOOLCHAIN_HAS_SSP condition, and move from a
LIBSCRYPT_POST_EXTRACT_HOOKS to a LIBSCRYPT_POST_PATCH_HOOKS.
- Pass $(TARGET_CONFIGURE_OPTS) instead of just passing CC.
- Pass $(TARGET_MAKE_ENV) when calling $(MAKE).]
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/4] cracklib: New package
2017-02-09 13:45 ` [Buildroot] [PATCH 2/4] cracklib: " Stefan Sørensen
@ 2017-04-01 21:15 ` Thomas Petazzoni
2017-04-05 12:40 ` Sørensen, Stefan
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2017-04-01 21:15 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for your patch. It is almost ready for merging, but there are
a few issues, most notably an issue when the full dict is used. See
below for all comments.
On Thu, 9 Feb 2017 14:45:56 +0100, Stefan S?rensen wrote:
> Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
> ---
> package/Config.in | 1 +
> package/cracklib/Config.in | 28 ++++++++++++++++++++++++++++
> package/cracklib/cracklib.hash | 3 +++
> package/cracklib/cracklib.mk | 39 +++++++++++++++++++++++++++++++++++++++
Our policy has changed: the update to the DEVELOPERS file should now be
in the same patch as the one adding the package. Could you fix that in
your next version?
> diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
> new file mode 100644
> index 0000000..c8e7fd5
> --- /dev/null
> +++ b/package/cracklib/cracklib.mk
> @@ -0,0 +1,39 @@
> +################################################################################
> +#
> +# cracklib
> +#
> +################################################################################
> +
> +CRACKLIB_VERSION = 2.9.6
> +CRACKLIB_SITE = https://github.com/cracklib/cracklib/releases/download/cracklib-$(CRACKLIB_VERSION)
> +CRACKLIB_LICENSE = LGPLv2+
This doesn't seem correct to me:
- We've switched to SPDX license codes since today, so it should be
LGPL-2.0 or LGPL-2.1
- The license is not LGPLv2, but LGPLv2.1, so the license code to use
is LGPL-2.1.
- I don't see any indication of the "or later" that justifies the "+",
so I guess CRACKLIB_LICENSE = LGPL-2.1 is the correct thing here.
> +CRACKLIB_LICENSE_FILES = COPYING.LIB README-LICENSE
I believe README-LICENSE is very historical and just give details on
how the migration to LGPL licensing was done. Now that this relicensing
is done (since 2008), I don't think adding this file to the licensing
information adds much value.
> +CRACKLIB_INSTALL_STAGING = YES
> +CRACKLIB_DEPENDENCIES = host-cracklib
> +ifeq ($(BR2_PACKAGE_CRACKLIB_FULL_DICT),y)
> +CRACKLIB_EXTRA_DOWNLOADS = cracklib-words-$(CRACKLIB_VERSION).gz
> +endif
Unfortunately, this full dict thing doesn't work, at install time, I see:
cracklib-format /home/thomas/dl/cracklib-words-2.9.6.gz | cracklib-packer /home/thomas/projets/buildroot/output/target/usr/share/cracklib/pw_dict
skipping line: 1
4 3
and the generated files on the target are really, really small:
-rw-r--r-- 1 thomas thomas 1024 avril 1 23:04 output/target/usr/share/cracklib/pw_dict.hwm
-rw-r--r-- 1 thomas thomas 50 avril 1 23:04 output/target/usr/share/cracklib/pw_dict.pwd
-rw-r--r-- 1 thomas thomas 16 avril 1 23:04 output/target/usr/share/cracklib/pw_dict.pwi
Could you have a look into this, and submit an updated version that
fixes this issue?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/4] libpwquality: New package
2017-02-09 13:45 ` [Buildroot] [PATCH 3/4] libpwquality: " Stefan Sørensen
@ 2017-04-01 21:21 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2017-04-01 21:21 UTC (permalink / raw)
To: buildroot
Hello Stefan,
On Thu, 9 Feb 2017 14:45:57 +0100, Stefan S?rensen wrote:
> Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
Thanks for this patch. A few comments below.
> package/Config.in | 1 +
> ...ith-disable-nls-on-platforms-without-libi.patch | 42 ++++++++++++++++++++++
> ...leak-in-settings-when-using-bad-word-list.patch | 23 ++++++++++++
> package/libpwquality/Config.in | 18 ++++++++++
> package/libpwquality/libpwquality.hash | 2 ++
> package/libpwquality/libpwquality.mk | 24 +++++++++++++
As said on the cracklib review, we now want the update to the
DEVELOPERS file to be done as part of the patch adding the package. I
normally fix this up when applying, but I have other comments below.
> diff --git a/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch b/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch
> new file mode 100644
> index 0000000..2ce79b9
> --- /dev/null
> +++ b/package/libpwquality/0001-Fix-build-with-disable-nls-on-platforms-without-libi.patch
> @@ -0,0 +1,42 @@
> +Status: Upstream
> +
> +Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
Such information should go at the end of the patch description, ...
> +
> +# HG changeset patch
> +# User Stefan S?rensen <stefan.sorensen@spectralink.com>
> +# Date 1486030609 -3600
> +# Thu Feb 02 11:16:49 2017 +0100
> +# Node ID 3a716ca2bbf90cde4d86ef3c4597884d6a416525
> +# Parent 79ca3b91513faf3bd03464808d107b71ba5d6c3b
> +Fix build with --disable-nls on platforms without libintl included in libc.
... here.
Also, both of your patches have been submitted upstream. Has upstream
released a new version with your fixes?
> diff --git a/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch b/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch
> new file mode 100644
> index 0000000..fe7b9e8
> --- /dev/null
> +++ b/package/libpwquality/0002-Fix-memory-leak-in-settings-when-using-bad-word-list.patch
> @@ -0,0 +1,23 @@
> +Status: Upstream
> +
> +Signed-off-by: Stefan S?rensen <stefan.sorensen@spectralink.com>
Ditto formatting of the patch.
> diff --git a/package/libpwquality/Config.in b/package/libpwquality/Config.in
> new file mode 100644
> index 0000000..da295f0
> --- /dev/null
> +++ b/package/libpwquality/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_LIBPWQUALITY
> + bool "libpwquality"
> + help
> + This is a library for password quality checks and generation
> + of random passwords that pass the checks. This library uses
> + the cracklib and cracklib dictionaries to perform some of
> + the checks.
> +
> + https://fedorahosted.org/libpwquality/
fedorahosted.org is dead, so it is no longer possible to use this as an
upstream/download location. Has the project moved elsewhere?
> +if BR2_PACKAGE_LIBPWQUALITY
> +
> +config BR2_PACKAGE_LIBPWQUALITY_TOOLS
> + bool "install tools"
> + help
> + Install libpwquality command line tools generating/checking passwords.
Line too long.
> +LIBPWQUALITY_VERSION = 1.3.0
> +LIBPWQUALITY_SOURCE = libpwquality-$(LIBPWQUALITY_VERSION).tar.bz2
> +LIBPWQUALITY_SITE = https://fedorahosted.org/releases/l/i/libpwquality
As said above, this site is dead.
> +LIBPWQUALITY_LICENSE = BSD or LGPLv2+
BSD is not precise enough. Which BSD variant?
LGPLv2+ should now be LGPL-2.0+ or LGPL-2.1+, as we use SPDX license
codes.
No LIBPWQUALITY_LICENSE_FILES ?
> +LIBPWQUALITY_INSTALL_STAGING = YES
> +LIBPWQUALITY_DEPENDENCIES = cracklib
> +LIBPWQUALITY_AUTORECONF = YES
Why is an autoreconf needed?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/4] cracklib: New package
2017-04-01 21:15 ` Thomas Petazzoni
@ 2017-04-05 12:40 ` Sørensen, Stefan
2017-04-05 14:29 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Sørensen, Stefan @ 2017-04-05 12:40 UTC (permalink / raw)
To: buildroot
On Sat, 2017-04-01 at 23:15 +0200, Thomas Petazzoni wrote:
> +CRACKLIB_INSTALL_STAGING = YES
> > +CRACKLIB_DEPENDENCIES = host-cracklib
> > +ifeq ($(BR2_PACKAGE_CRACKLIB_FULL_DICT),y)
> > +CRACKLIB_EXTRA_DOWNLOADS = cracklib-words-$(CRACKLIB_VERSION).gz
> > +endif
>
> Unfortunately, this full dict thing doesn't work, at install time, I
> see:
>
> cracklib-format /home/thomas/dl/cracklib-words-2.9.6.gz | cracklib-
> packer
> /home/thomas/projets/buildroot/output/target/usr/share/cracklib/pw_di
> ct
> skipping line: 1
> 4 3
>
> and the generated files on the target are really, really small:
>
> -rw-r--r-- 1 thomas thomas 1024 avril??1 23:04
> output/target/usr/share/cracklib/pw_dict.hwm
> -rw-r--r-- 1 thomas thomas???50 avril??1 23:04
> output/target/usr/share/cracklib/pw_dict.pwd
> -rw-r--r-- 1 thomas thomas???16 avril??1 23:04
> output/target/usr/share/cracklib/pw_dict.pwi
>
> Could you have a look into this, and submit an updated version that
> fixes this issue?
I am not able to reproduce this, though I just notices that it uses the
cracklib tools from the PATH, not the ones built in host-cracklib, so
maybe that is what is causing the issue.
I will submit new patches with this and the other issues you mentioned
fixed.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/4] cracklib: New package
2017-04-05 12:40 ` Sørensen, Stefan
@ 2017-04-05 14:29 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2017-04-05 14:29 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 5 Apr 2017 12:40:02 +0000, S?rensen, Stefan wrote:
> > Could you have a look into this, and submit an updated version that
> > fixes this issue?
>
> I am not able to reproduce this, though I just notices that it uses the
> cracklib tools from the PATH, not the ones built in host-cracklib, so
> maybe that is what is causing the issue.
I'm not sure it's the problem, because I'm pretty sure I ran the
command manually by explicitly calling the tools built in
output/host/usr/bin.
But anyway, I'll test your next iteration, and see if I can still
reproduce the issue.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-04-05 14:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 13:45 [Buildroot] [PATCH 1/4] libscrypt: New package Stefan Sørensen
2017-02-09 13:45 ` [Buildroot] [PATCH 2/4] cracklib: " Stefan Sørensen
2017-04-01 21:15 ` Thomas Petazzoni
2017-04-05 12:40 ` Sørensen, Stefan
2017-04-05 14:29 ` Thomas Petazzoni
2017-02-09 13:45 ` [Buildroot] [PATCH 3/4] libpwquality: " Stefan Sørensen
2017-04-01 21:21 ` Thomas Petazzoni
2017-02-09 13:45 ` [Buildroot] [PATCH 4/4] DEVELOPERS: Add Stefan Sørensen for cracklib, libpwquality and libscrypt Stefan Sørensen
2017-03-12 22:57 ` [Buildroot] [PATCH 1/4] libscrypt: New package Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox