* [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure
@ 2017-05-31 21:40 Alexandre Esse
2017-06-01 11:49 ` Gary Bisson
2017-06-06 21:02 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Esse @ 2017-05-31 21:40 UTC (permalink / raw)
To: buildroot
The daemon service script associated with imx-uuc failed to stop the daemon
since the PID of the process wasn't stored at start time.
Adding -m option allowed to create the uuc.pid file as expected.
Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
---
package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/freescale-imx/imx-uuc/S80imx-uuc b/package/freescale-imx/imx-uuc/S80imx-uuc
index 8a02f88..9a92c98 100644
--- a/package/freescale-imx/imx-uuc/S80imx-uuc
+++ b/package/freescale-imx/imx-uuc/S80imx-uuc
@@ -6,7 +6,7 @@ DAEMON=/usr/bin/$NAME
case "$1" in
start)
printf "Starting $NAME: "
- start-stop-daemon -S -q -b -p /var/run/${NAME}.pid -x $DAEMON
+ start-stop-daemon -S -q -b -m -p /var/run/${NAME}.pid -x $DAEMON
[ $? = 0 ] && echo "OK" || echo "FAIL"
;;
stop)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure
2017-05-31 21:40 [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure Alexandre Esse
@ 2017-06-01 11:49 ` Gary Bisson
2017-06-06 21:02 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Gary Bisson @ 2017-06-01 11:49 UTC (permalink / raw)
To: buildroot
Hi Alexandre,
On Wed, May 31, 2017 at 11:40 PM, Alexandre Esse
<alexandre.esse.dev@gmail.com> wrote:
> The daemon service script associated with imx-uuc failed to stop the daemon
> since the PID of the process wasn't stored at start time.
>
> Adding -m option allowed to create the uuc.pid file as expected.
>
> Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Thanks for your patch.
Regards,
Gary
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure
2017-05-31 21:40 [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure Alexandre Esse
2017-06-01 11:49 ` Gary Bisson
@ 2017-06-06 21:02 ` Thomas Petazzoni
2017-06-06 21:28 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-06-06 21:02 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 31 May 2017 23:40:45 +0200, Alexandre Esse wrote:
> The daemon service script associated with imx-uuc failed to stop the daemon
> since the PID of the process wasn't stored at start time.
>
> Adding -m option allowed to create the uuc.pid file as expected.
>
> Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
> ---
> package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks. Peter: this should go in the LTS branch.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure
2017-06-06 21:02 ` Thomas Petazzoni
@ 2017-06-06 21:28 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-06-06 21:28 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Wed, 31 May 2017 23:40:45 +0200, Alexandre Esse wrote:
>> The daemon service script associated with imx-uuc failed to stop the daemon
>> since the PID of the process wasn't stored at start time.
>>
>> Adding -m option allowed to create the uuc.pid file as expected.
>>
>> Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
>> ---
>> package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Applied to master, thanks. Peter: this should go in the LTS branch.
Indeed. Committed to 2017.02.x and 2017.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-06 21:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 21:40 [Buildroot] [PATCH 1/1] imx-uuc: fix start-stop-daemon stop failure Alexandre Esse
2017-06-01 11:49 ` Gary Bisson
2017-06-06 21:02 ` Thomas Petazzoni
2017-06-06 21:28 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox