Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Linux: Clear CONFIG_INITRAMFS_SOURCE if BR2_TARGET_ROOTFS_INITRAMFS is not set
Date: Mon, 13 Nov 2017 17:07:14 +0000	[thread overview]
Message-ID: <1510592834.6361.73.camel@synopsys.com> (raw)
In-Reply-To: <878tfas2b6.fsf@dell.be.48ers.dk>

Hi Peter,

On Mon, 2017-11-13 at 15:03 +0100, Peter Korsgaard wrote:
> > 
> > > 
> > > > 
> > > > > 
> > > > > > 
> > > > > > "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:
> 
> ?> This patch makes sure CONFIG_INITRAMFS_SOURCE option gets reset
> ?> when BR2_TARGET_ROOTFS_INITRAMFS is not set. Some kernel defconfigs,?
> ?> for example for ARC processors, set CONFIG_INITRAMFS_SOURCE value, which cause such error:
> ?> "./scripts/gen_initramfs_list.sh: Cannot open '../../arc_initramfs_hs/'"
> 
> I'm not sure. I really would like to keep our "magic" .config fixups to
> a minimum as they are kind of hidden and force specific use cases
> without any options of disabling it (E.G. perhaps somebody has a
> prebuilt initramfs they would like to include even though buildroot
> builds the real rootfs (so BR2_TARGET_ROOTFS_INITRAMFS is not set). With
> this change, this is no longer possible.

Well a couple of things I was thinking about:
1. This would be [in my view] just a complimentary option to setting BR's rootfs.
2. Usage of prebuilt initramf with BR might be quite a tricky thing because
? ?different toolchain could be used with different ABI, libc etc so chances
? ?are quite high that user-space stuff built with BR will be incompatible with
? ?contents of prebuilt rootfs. But I guess we cannot stop people from doing that.

> Couldn't you fix these arc specific defconfig issues with a small
> kconfig fragment instead?

So maybe this is indeed a bit better solution even though we know nobody
who'd do such a trick with pre-built initramfs.

-Alexey

  reply	other threads:[~2017-11-13 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13  4:34 [Buildroot] [PATCH] Linux: Clear CONFIG_INITRAMFS_SOURCE if BR2_TARGET_ROOTFS_INITRAMFS is not set Evgeniy Didin
2017-11-13 14:03 ` Peter Korsgaard
2017-11-13 17:07   ` Alexey Brodkin [this message]
2017-11-13 21:03     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510592834.6361.73.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox