From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Linux: Clear CONFIG_INITRAMFS_SOURCE if BR2_TARGET_ROOTFS_INITRAMFS is not set
Date: Mon, 13 Nov 2017 15:03:57 +0100 [thread overview]
Message-ID: <878tfas2b6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171113043416.43750-1-didin@synopsys.com> (Evgeniy Didin's message of "Mon, 13 Nov 2017 07:34:16 +0300")
>>>>> "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:
> This patch makes sure CONFIG_INITRAMFS_SOURCE option gets reset
> when BR2_TARGET_ROOTFS_INITRAMFS is not set. Some kernel defconfigs,
> for example for ARC processors, set CONFIG_INITRAMFS_SOURCE value, which cause such error:
> "./scripts/gen_initramfs_list.sh: Cannot open '../../arc_initramfs_hs/'"
I'm not sure. I really would like to keep our "magic" .config fixups to
a minimum as they are kind of hidden and force specific use cases
without any options of disabling it (E.G. perhaps somebody has a
prebuilt initramfs they would like to include even though buildroot
builds the real rootfs (so BR2_TARGET_ROOTFS_INITRAMFS is not set). With
this change, this is no longer possible.
Couldn't you fix these arc specific defconfig issues with a small
kconfig fragment instead?
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> CC: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: arc-buildroot at synopsys.com
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> linux/linux.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 9c2aa77..0eee315 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -269,7 +269,8 @@ define LINUX_KCONFIG_FIXUP_CMDS
> touch $(BINARIES_DIR)/rootfs.cpio
> $(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_SOURCE,"$${BR_BINARIES_DIR}/rootfs.cpio",$(@D)/.config)
> $(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_ROOT_UID,0,$(@D)/.config)
> - $(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_ROOT_GID,0,$(@D)/.config))
> + $(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_ROOT_GID,0,$(@D)/.config),
> + $(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_SOURCE,"",$(@D)/.config))
> $(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
> $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> --
> 2.9.3
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-11-13 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 4:34 [Buildroot] [PATCH] Linux: Clear CONFIG_INITRAMFS_SOURCE if BR2_TARGET_ROOTFS_INITRAMFS is not set Evgeniy Didin
2017-11-13 14:03 ` Peter Korsgaard [this message]
2017-11-13 17:07 ` Alexey Brodkin
2017-11-13 21:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tfas2b6.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox