* [Buildroot] [PATCH] swupdate: remove empty line
@ 2018-01-14 17:53 Jörg Krause
2018-01-14 18:03 ` Yann E. MORIN
2018-01-15 14:19 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Jörg Krause @ 2018-01-14 17:53 UTC (permalink / raw)
To: buildroot
Reported by Yann E. Morin running:
```
$ ./utils/check-package package/swupdate/swupdate.mk
package/swupdate/swupdate.mk:42: consecutive empty lines
140 lines processed
1 warnings generated
```
Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
package/swupdate/swupdate.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
index d1afbc4882..aa232e5837 100644
--- a/package/swupdate/swupdate.mk
+++ b/package/swupdate/swupdate.mk
@@ -39,7 +39,6 @@ else
SWUPDATE_MAKE_ENV += HAVE_LIBCURL=n
endif
-
ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y)
SWUPDATE_DEPENDENCIES += luainterpreter host-pkgconf
# defines the base name for the pkg-config file ("lua" or "luajit")
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] swupdate: remove empty line
2018-01-14 17:53 [Buildroot] [PATCH] swupdate: remove empty line Jörg Krause
@ 2018-01-14 18:03 ` Yann E. MORIN
2018-01-14 18:16 ` Jörg Krause
2018-01-15 14:19 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2018-01-14 18:03 UTC (permalink / raw)
To: buildroot
J"org, All,
On 2018-01-14 18:53 +0100, J?rg Krause spake thusly:
> Reported by Yann E. Morin running:
>
> ```
> $ ./utils/check-package package/swupdate/swupdate.mk
> package/swupdate/swupdate.mk:42: consecutive empty lines
> 140 lines processed
> 1 warnings generated
> ```
Note: I could have very well done it myself, but by having other do it,
that spreads the knowledge, and people get used to running it before
submitting. Or so I hope! ;-)
Thanks! :-)
> Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/swupdate/swupdate.mk | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
> index d1afbc4882..aa232e5837 100644
> --- a/package/swupdate/swupdate.mk
> +++ b/package/swupdate/swupdate.mk
> @@ -39,7 +39,6 @@ else
> SWUPDATE_MAKE_ENV += HAVE_LIBCURL=n
> endif
>
> -
> ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y)
> SWUPDATE_DEPENDENCIES += luainterpreter host-pkgconf
> # defines the base name for the pkg-config file ("lua" or "luajit")
> --
> 2.15.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] swupdate: remove empty line
2018-01-14 18:03 ` Yann E. MORIN
@ 2018-01-14 18:16 ` Jörg Krause
0 siblings, 0 replies; 4+ messages in thread
From: Jörg Krause @ 2018-01-14 18:16 UTC (permalink / raw)
To: buildroot
Yann,
On Sun, 2018-01-14 at 19:03 +0100, Yann E. MORIN wrote:
> J"org, All,
>
> On 2018-01-14 18:53 +0100, J?rg Krause spake thusly:
> > Reported by Yann E. Morin running:
> >
> > ```
> > $ ./utils/check-package package/swupdate/swupdate.mk
> > package/swupdate/swupdate.mk:42: consecutive empty lines
> > 140 lines processed
> > 1 warnings generated
> > ```
>
> Note: I could have very well done it myself, but by having other do it,
> that spreads the knowledge, and people get used to running it before
> submitting. Or so I hope! ;-)
No problem! Mostly I am running check-package only when submitting a
new package. But, I will try next time to remember of running it every
time :-)
J?rg
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] swupdate: remove empty line
2018-01-14 17:53 [Buildroot] [PATCH] swupdate: remove empty line Jörg Krause
2018-01-14 18:03 ` Yann E. MORIN
@ 2018-01-15 14:19 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-01-15 14:19 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:
> Reported by Yann E. Morin running:
> ```
> $ ./utils/check-package package/swupdate/swupdate.mk
> package/swupdate/swupdate.mk:42: consecutive empty lines
> 140 lines processed
> 1 warnings generated
> ```
> Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-14 17:53 [Buildroot] [PATCH] swupdate: remove empty line Jörg Krause
2018-01-14 18:03 ` Yann E. MORIN
2018-01-14 18:16 ` Jörg Krause
2018-01-15 14:19 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox