Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] core/intrumetnation: don't spawn to get seconds-since-EPOCH
Date: Mon, 19 Mar 2018 16:15:17 +0000	[thread overview]
Message-ID: <1521476116.10662.130.camel@impinj.com> (raw)
In-Reply-To: <20180318161605.GB2478@scaer>

On Sun, 2018-03-18 at 17:16 +0100, Yann E. MORIN wrote:
> > >  define step_time
> > > -       printf "%s:%-5.5s:%-20.20s: %s\n"           \
> > > -              "$$(date +%s)" "$(1)" "$(2)" "$(3)"  \
> > > +       printf "%(%s)T:%-5.5s:%-20.20s: %s\n"           \
> > > +              -1 "$(1)" "$(2)" "$(3)"  \
> > 
> > Should you note somewhere that this needs bash 4.2? I remember some
> > re-working of bash patches in the past to avoid the use of associative arrays
> > as they were not supported in the oldest version of bash supported by
> > buildroot. Is bash 4.2 ok now?
> > 
> 
> OK, I'm dropping this change, then. Thanks for noticing. :-)

If it weren't for the space padding of the fields, you could go the
other way and avoid the printf call and just use date.

define step_time
	date +"%s.%N:$(1):$(2):$(3)"

Not as pretty to look at, but just as parsable to a script.

  reply	other threads:[~2018-03-19 16:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 20:35 [Buildroot] [PATCH 0/2] core/instrumentation: optimisations Yann E. MORIN
2018-03-15 20:35 ` [Buildroot] [PATCH 1/2] core/intrumetnation: don't spawn to get seconds-since-EPOCH Yann E. MORIN
2018-03-17 11:54   ` Cam Hutchison
2018-03-18 16:16     ` Yann E. MORIN
2018-03-19 16:15       ` Trent Piepho [this message]
2018-03-15 20:35 ` [Buildroot] [PATCH 2/2] core/instrumentation: shave minutes off the build time Yann E. MORIN
2018-03-18 14:14   ` Peter Korsgaard
2018-03-18 16:15     ` Yann E. MORIN
2018-03-18 16:33       ` Peter Korsgaard
2018-03-22 16:41         ` Thomas De Schampheleire
2018-03-22 16:50           ` Thomas Petazzoni
2018-03-22 17:11             ` Thomas De Schampheleire
2018-03-22 17:25               ` Trent Piepho
2018-03-22 22:39             ` Peter Korsgaard
2018-03-23 22:39           ` Arnout Vandecappelle
2018-03-23 23:03             ` Thomas Petazzoni
2018-03-19 16:30   ` Trent Piepho
2018-03-19 16:50     ` Thomas Petazzoni
2018-03-19 20:04       ` Peter Korsgaard
2018-03-20 21:47         ` Trent Piepho
2018-03-19 16:53     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521476116.10662.130.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox