Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Denis OSTERLAND <denis.osterland@diehl.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] u-boot: add option to generate env image from default env
Date: Tue, 4 Dec 2018 12:55:15 +0000	[thread overview]
Message-ID: <1543928115.6363.0.camel@diehl.com> (raw)
In-Reply-To: <20181112101748.24707-1-Denis.Osterland@diehl.com>

Hi,

any objections here?

Regards Denis

Am Montag, den 12.11.2018, 11:17 +0100 schrieb Denis OSTERLAND:
> From: Denis Osterland <Denis.Osterland@diehl.com>
> 
> This patch adds support to extract compiled in default env
> via u-boots get_default_envs script and generate env image from it.
> 
> Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
> ---
> v1 -> v2: use compiled in env if sources list is empty,
> ??????????as suggested by Arnout Vandecappelle
> 
> ?boot/uboot/Config.in | 2 ++
> ?boot/uboot/uboot.mk??| 8 ++++----
> ?2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index ac6f8bc8c1..2e3a112874 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -466,6 +466,8 @@ menuconfig BR2_TARGET_UBOOT_ENVIMAGE
> ?
> ?	??The environment image will be called uboot-env.bin.
> ?
> +	??Leave empty to generate image from compiled-in env.
> +
> ?if BR2_TARGET_UBOOT_ENVIMAGE
> ?
> ?config BR2_TARGET_UBOOT_ENVIMAGE_SOURCE
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index cbdfee6ac3..693fe69508 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -262,8 +262,11 @@ define UBOOT_BUILD_OMAP_IFT
> ?endef
> ?
> ?ifneq ($(BR2_TARGET_UBOOT_ENVIMAGE),)
> +UBOOT_GENERATE_ENV_FILE=$(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE))
> ?define UBOOT_GENERATE_ENV_IMAGE
> -	cat $(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE)) \
> +	$(if $(UBOOT_GENERATE_ENV_FILE), \
> +	cat $(UBOOT_GENERATE_ENV_FILE), \
> +	CROSS_COMPILE="$(TARGET_CROSS)" $(@D)/scripts/get_default_envs.sh $(@D)) \
> ?		>$(@D)/buildroot-env.txt
> ?	$(HOST_DIR)/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \
> ?		$(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \
> @@ -376,9 +379,6 @@ endef
> ?
> ?ifeq ($(BR2_TARGET_UBOOT_ENVIMAGE),y)
> ?ifeq ($(BR_BUILDING),y)
> -ifeq ($(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE)),)
> -$(error Please define a source file for Uboot environment (BR2_TARGET_UBOOT_ENVIMAGE_SOURCE setting))
> -endif
> ?ifeq ($(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SIZE)),)
> ?$(error Please provide Uboot environment size (BR2_TARGET_UBOOT_ENVIMAGE_SIZE setting))
> ?endif

Diehl Connectivity Solutions GmbH
Gesch?ftsf?hrung: Horst Leonberger
Sitz der Gesellschaft: N?rnberg - Registergericht: Amtsgericht
N?rnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 

  reply	other threads:[~2018-12-04 12:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  5:38 [Buildroot] [PATCH] u-boot: add option to generate env image from default env Denis OSTERLAND
2018-10-08 17:33 ` Arnout Vandecappelle
2018-10-09  7:07   ` Denis OSTERLAND
2018-10-09  8:01     ` Arnout Vandecappelle
2018-10-09  9:20       ` Denis OSTERLAND
2019-01-14 15:28 ` [Buildroot] [PATCH v2] " Denis OSTERLAND
2018-12-04 12:55   ` Denis OSTERLAND [this message]
2019-08-01 10:32   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543928115.6363.0.camel@diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox