Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sunil at amarulasolutions.com <sunil@amarulasolutions.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] boot/arm-trusted-firmware: Disable bin copy for rk3399
Date: Thu, 13 Feb 2020 11:22:28 +0530	[thread overview]
Message-ID: <1581573151-18943-2-git-send-email-sunil@amarulasolutions.com> (raw)
In-Reply-To: <1581573151-18943-1-git-send-email-sunil@amarulasolutions.com>

From: Jagan Teki <jagan@amarulasolutions.com>

Unlike other SoC platforms, rockchip platforms doesn't require a binary
generation on TF-A project.

This is due to rockchip platforms have non-continuous memory areas in
the linker script with a huge gap between them, so generating the binary
would require addition padding which indeed increases the size of the binary.

Interestingly this binary generation is disabled in v2.2 of TF-A on below
commit:
 commit <33218d2a8143> "rockchip: Disable binary generation for all SoCs."

So, select default binary boot images as *.bin only if it's not rk3399.

This fixes the atf build on rk3399 with v2.2.

Note: the same can be applied to rest of rockchip platforms if
they use v2.2 TF-A.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
---
 boot/arm-trusted-firmware/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
index 373591d..0006931 100644
--- a/boot/arm-trusted-firmware/Config.in
+++ b/boot/arm-trusted-firmware/Config.in
@@ -155,7 +155,7 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
 
 config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
 	string "Binary boot images"
-	default "*.bin"
+	default "*.bin" if BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM!=rk3399
 	help
 	  Names of generated image files that are installed in the
 	  output images/ directory.
-- 
2.7.4

  reply	other threads:[~2020-02-13  5:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  5:52 [Buildroot] [PATCH 0/4] Fix ATF v2.2 build for rk3399, add roc-rk3399-pc board sunil at amarulasolutions.com
2020-02-13  5:52 ` sunil at amarulasolutions.com [this message]
2020-02-13  7:23   ` [Buildroot] [PATCH 1/4] boot/arm-trusted-firmware: Disable bin copy for rk3399 Sergey Matyukevich
2020-02-13  8:06     ` Jagan Teki
2020-02-14  4:20       ` Thomas Petazzoni
2020-02-14  6:55         ` Jagan Teki
2020-02-14  7:26           ` Thomas Petazzoni
2020-02-14  7:34             ` Jagan Teki
2020-02-14 10:57             ` Sunil Kumar Mahesh
2020-02-14 12:33               ` Sunil Kumar Mahesh
2020-02-13  5:52 ` [Buildroot] [PATCH 2/4] package/arm-gnu-a-toolchain: new package sunil at amarulasolutions.com
2020-02-13  7:34   ` Sergey Matyukevich
2020-02-13  8:10     ` Jagan Teki
2020-02-13  9:20       ` Sergey Matyukevich
2020-02-13  9:43         ` Jagan Teki
2020-02-13 10:01         ` Sunil Kumar Mahesh
2020-02-14  4:19           ` Thomas Petazzoni
2020-02-14  4:17         ` Thomas Petazzoni
2020-02-13  5:52 ` [Buildroot] [PATCH 3/4] boot/arm-trusted-firmware: add support for rockchip rk3399 sunil at amarulasolutions.com
2020-02-14  8:25   ` Sergey Matyukevich
2020-02-14  9:35     ` Sunil Kumar Mahesh
2020-02-13  5:52 ` [Buildroot] [PATCH 4/4] configs/roc-rk3399-pc: new defconfig sunil at amarulasolutions.com
2020-02-13  8:22   ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581573151-18943-2-git-send-email-sunil@amarulasolutions.com \
    --to=sunil@amarulasolutions.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox