From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] boot/arm-trusted-firmware: Disable bin copy for rk3399
Date: Fri, 14 Feb 2020 08:26:25 +0100 [thread overview]
Message-ID: <20200214082625.4d114bc9@windsurf> (raw)
In-Reply-To: <CAMty3ZA3F6td2xwAqVLZvF5ZK+_G3kj-U89yccJCEEyM3tMzcQ@mail.gmail.com>
On Fri, 14 Feb 2020 12:25:37 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:
> > Sergey is right here: I don't think we want to encode platform-specific
> > stuff like this in Kconfig files.
> >
> > What is the problem if you leave this to the default of *.bin ?
>
> Is looking for *.bin in build/rk3399/release/*.bin but v2.2 is not
> creating any bin since rk3399 (or rockchip) doesn't need bins.
>
> .mk file change:
>
> define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> $(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
> cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
> )
>
> Build log:
>
> >>> arm-trusted-firmware v2.2 Installing to images directory
> cp -dpf /mnt/out/build/arm-trusted-firmware-v2.2/build/rk3399/release/*.bin
> /mnt/out/images/
> cp: cannot stat
> '/mnt/out/build/arm-trusted-firmware-v2.2/build/rk3399/release/*.bin':
> No such file or directory
> package/pkg-generic.mk:339: recipe for target
> '/mnt/out/build/arm-trusted-firmware-v2.2/.stamp_images_installed'
> failed
> make[1]: *** [/mnt/out/build/arm-trusted-firmware-v2.2/.stamp_images_installed]
> Error 1
> Makefile:23: recipe for target '_all' failed
> make: *** [_all] Error 2
What is your image name then? You don't install any image?
One possibility is to change:
- $(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
+ $(foreach f,$(wilard $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES))), \
But still, it would be nice to understand what is your image name. I
guess I could find that out by doing a build, though :)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-14 7:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 5:52 [Buildroot] [PATCH 0/4] Fix ATF v2.2 build for rk3399, add roc-rk3399-pc board sunil at amarulasolutions.com
2020-02-13 5:52 ` [Buildroot] [PATCH 1/4] boot/arm-trusted-firmware: Disable bin copy for rk3399 sunil at amarulasolutions.com
2020-02-13 7:23 ` Sergey Matyukevich
2020-02-13 8:06 ` Jagan Teki
2020-02-14 4:20 ` Thomas Petazzoni
2020-02-14 6:55 ` Jagan Teki
2020-02-14 7:26 ` Thomas Petazzoni [this message]
2020-02-14 7:34 ` Jagan Teki
2020-02-14 10:57 ` Sunil Kumar Mahesh
2020-02-14 12:33 ` Sunil Kumar Mahesh
2020-02-13 5:52 ` [Buildroot] [PATCH 2/4] package/arm-gnu-a-toolchain: new package sunil at amarulasolutions.com
2020-02-13 7:34 ` Sergey Matyukevich
2020-02-13 8:10 ` Jagan Teki
2020-02-13 9:20 ` Sergey Matyukevich
2020-02-13 9:43 ` Jagan Teki
2020-02-13 10:01 ` Sunil Kumar Mahesh
2020-02-14 4:19 ` Thomas Petazzoni
2020-02-14 4:17 ` Thomas Petazzoni
2020-02-13 5:52 ` [Buildroot] [PATCH 3/4] boot/arm-trusted-firmware: add support for rockchip rk3399 sunil at amarulasolutions.com
2020-02-14 8:25 ` Sergey Matyukevich
2020-02-14 9:35 ` Sunil Kumar Mahesh
2020-02-13 5:52 ` [Buildroot] [PATCH 4/4] configs/roc-rk3399-pc: new defconfig sunil at amarulasolutions.com
2020-02-13 8:22 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214082625.4d114bc9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox