From: Tian Yuanhao <tianyuanhao@aliyun.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/e2fsprogs: disable the e2scrub stuff
Date: Fri, 18 Sep 2020 09:57:30 +0800 [thread overview]
Message-ID: <1600394250.18560.2.camel@aliyun.com> (raw)
In-Reply-To: <20200917213935.67fc4894@windsurf.hq.k.grp>
On ?, 2020-09-17 at 21:39 +0200, Thomas Petazzoni wrote:
> On Thu, 17 Sep 2020 17:03:45 +0800
> Tian Yuanhao via buildroot <buildroot@busybox.net> wrote:
>?
> >
> > diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
> > index eb82a55..cf6579d 100644
> > --- a/package/e2fsprogs/e2fsprogs.mk
> > +++ b/package/e2fsprogs/e2fsprogs.mk
> > @@ -52,7 +52,10 @@ E2FSPROGS_CONF_OPTS = \
> > ? --disable-e2initrd-helper \
> > ? --disable-testio-debug \
> > ? --disable-rpath \
> > - --enable-symlink-install
> > + --enable-symlink-install \
> > + --with-crond-dir=no \
> > + --with-systemd-unit-dir=no \
> > + --with-udev-rules-dir=no
> I'm not sure this is really a good solution. Indeed, we probably do
> want to install udev rules or systemd services.
>
> Thomas
'--with-crond-dir=no --with-systemd-unit-dir=no --with-udev-rules-dir=no'
is approximately equal to '--disable-scrub' which does not exist.
Android [1], Yocto [2] and PTXdist [3] do not install e2scrub. Therefore,
I thought Buildroot should boldly use those options.
[1]: https://android.googlesource.com/platform/external/e2fsprogs/+/refs/heads/master/Android.bp
[2]: http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.45.6.bb
[3]: https://git.pengutronix.de/cgit/ptxdist/tree/rules/e2fsprogs.make
next prev parent reply other threads:[~2020-09-18 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 9:03 [Buildroot] [PATCH 1/1] package/e2fsprogs: disable the e2scrub stuff Tian Yuanhao
2020-09-17 19:39 ` Thomas Petazzoni
2020-09-18 1:57 ` Tian Yuanhao [this message]
2020-09-20 21:12 ` Yann E. MORIN
2020-09-21 2:48 ` [Buildroot] [PATCH v2 1/1] package/e2fsprogs: disable e2scrub Tian Yuanhao
2020-10-10 17:04 ` James Hilliard
2021-04-30 9:16 ` [Buildroot] [PATCH v3 1/1] package/e2fsprogs: disable e2scrub conditionally Tian Yuanhao
2021-04-30 22:03 ` Yann E. MORIN
2021-05-01 6:11 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600394250.18560.2.camel@aliyun.com \
--to=tianyuanhao@aliyun.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox