Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tian Yuanhao <tianyuanhao@aliyun.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/e2fsprogs: disable e2scrub
Date: Mon, 21 Sep 2020 10:48:54 +0800	[thread overview]
Message-ID: <1600656534.31411.3.camel@aliyun.com> (raw)
In-Reply-To: <20200920211236.GK2422@scaer>

e2scrub_all depends on coreutils' readlink. If you use busybox's
readlink, you will see the following error:

	readlink: invalid option -- 'e'

Embedded systems usually don't install e2scrub, which is useless without
LVM.

Signed-off-by: Tian Yuanhao <tianyuanhao@aliyun.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
?package/e2fsprogs/e2fsprogs.mk | 4 ++++
?1 file changed, 4 insertions(+)

diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index eb82a55..44413ba 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -73,6 +73,10 @@ E2FSPROGS_INSTALL_STAGING_OPTS = \
?	DESTDIR=$(STAGING_DIR) \
?	install-libs
?
+# Disable e2scrub as we don't need it.
+E2FSPROGS_MAKE_OPTS = E2SCRUB_DIR=
+E2FSPROGS_INSTALL_TARGET_OPTS = E2SCRUB_DIR= DESTDIR=$(TARGET_DIR) install
+
?# Package does not build in parallel due to improper make rules
?define HOST_E2FSPROGS_INSTALL_CMDS
?	$(HOST_MAKE_ENV) $(MAKE1) -C $(@D) install install-libs
--?
2.7.4

  reply	other threads:[~2020-09-21  2:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  9:03 [Buildroot] [PATCH 1/1] package/e2fsprogs: disable the e2scrub stuff Tian Yuanhao
2020-09-17 19:39 ` Thomas Petazzoni
2020-09-18  1:57   ` Tian Yuanhao
2020-09-20 21:12     ` Yann E. MORIN
2020-09-21  2:48       ` Tian Yuanhao [this message]
2020-10-10 17:04         ` [Buildroot] [PATCH v2 1/1] package/e2fsprogs: disable e2scrub James Hilliard
2021-04-30  9:16         ` [Buildroot] [PATCH v3 1/1] package/e2fsprogs: disable e2scrub conditionally Tian Yuanhao
2021-04-30 22:03           ` Yann E. MORIN
2021-05-01  6:11             ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1600656534.31411.3.camel@aliyun.com \
    --to=tianyuanhao@aliyun.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox