Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory
@ 2008-03-19  1:06 Hebbar
  2008-03-19 21:45 ` Ulf Samuelsson
  0 siblings, 1 reply; 5+ messages in thread
From: Hebbar @ 2008-03-19  1:06 UTC (permalink / raw)
  To: buildroot


Hi,

At present, Buildroot allows only 2 skeleton directory for root preparation
other than those for atmel,amd etc.

1. target/generic/target_busybox_skeleton
2. target/generic/target_skeleton

Below patch allows customers to define their own cutom skeleton directory
and patch.

I welcome comments and changes or updates required for the same.

Thanks and regards
Gururaja

Signed-off-by: Gururaja Hebbar <gururaja@sanyo.co.in>

buildroot/package/busybox/Config.in
buildroot/target/generic/Makefile.in

diff -purN buildroot/package/busybox/Config.in
buildroot_kboard/package/busybox/Config.in
--- buildroot/package/busybox/Config.in	2008-03-18 03:15:30.000000000 -0400
+++ buildroot_kboard/package/busybox/Config.in	2008-03-15 20:19:33.000000000
-0400
@@ -92,6 +92,18 @@ config BR2_PACKAGE_BUSYBOX_SKELETON
 	  Use a minimal target skeleton. Make sure to select mdev
 	  which is used to populate /dev/.
 
+config BR2_PACKAGE_CUSTOM_SKELETON
+	bool "use custom target skeleton"	
+	depends on !BR2_PACKAGE_BUSYBOX_SKELETON
+	help
+	  Use a Custom target skeleton. Make sure it includes all
+	  required directories and files.
+	  
+config BR2_PACKAGE_CUSTOM_SKELETON_PATH
+	string "custom target skeleton Path"
+	depends on BR2_PACKAGE_CUSTOM_SKELETON
+	default ""
+
 #config BR2_PACKAGE_BUSYBOX_INITRAMFS
 #	bool "initramfs perusing busybox"
 #	depends on BR2_PACKAGE_BUSYBOX

diff -purN buildroot/target/generic/Makefile.in
buildroot_kboard/target/generic/Makefile.in
--- buildroot/target/generic/Makefile.in	2008-03-18 03:15:20.000000000 -0400
+++ buildroot_kboard/target/generic/Makefile.in	2008-03-18
17:56:48.000000000 -0400
@@ -7,3 +7,6 @@ TARGET_SKELETON=target/generic/target_bu
 TARGET_DEVICE_TABLE=target/generic/mini_device_table.txt
 endif
 
+ifeq ($(BR2_PACKAGE_CUSTOM_SKELETON),y)
+TARGET_SKELETON=$(strip $(subst ",, $(BR2_PACKAGE_CUSTOM_SKELETON_PATH)))
+endif
-- 
View this message in context: http://www.nabble.com/-PATCH--Allow-users-to-choose-Custom-Skeleton-directory-tp16135129p16135129.html
Sent from the BuildRoot mailing list archive at Nabble.com.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory
  2008-03-19  1:06 [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory Hebbar
@ 2008-03-19 21:45 ` Ulf Samuelsson
  2008-03-20  4:15   ` Sean Perry
  0 siblings, 1 reply; 5+ messages in thread
From: Ulf Samuelsson @ 2008-03-19 21:45 UTC (permalink / raw)
  To: buildroot

> 
> Hi,
> 
> At present, Buildroot allows only 2 skeleton directory for root preparation
> other than those for atmel,amd etc.
> 
> 1. target/generic/target_busybox_skeleton
> 2. target/generic/target_skeleton
> 
> Below patch allows customers to define their own cutom skeleton directory
> and patch.
> 
> I welcome comments and changes or updates required for the same.
> 
> Thanks and regards
> Gururaja
> 

If someone wants to have a custom skeleton, why not
create support for a new board where the board makefile
specifies the target skeleton.

I can't really see why you want to be able to specify a non-existing skeleton.

Best Regards
Ulf Samuelsson

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory
  2008-03-19 21:45 ` Ulf Samuelsson
@ 2008-03-20  4:15   ` Sean Perry
  2008-03-20  4:46     ` Hebbar
  0 siblings, 1 reply; 5+ messages in thread
From: Sean Perry @ 2008-03-20  4:15 UTC (permalink / raw)
  To: buildroot

Ulf Samuelsson wrote:
> 
> If someone wants to have a custom skeleton, why not
> create support for a new board where the board makefile
> specifies the target skeleton.
> 
> I can't really see why you want to be able to specify a non-existing skeleton.
> 

because not all of us need or want to go through setting up a board, 
project, et al.

At work we use busybox on IA32 for IA32 and I have to use glibc, so I 
use crosstool as an external toolchain. It all works, and works quite 
well. I just hand hacked the config to use my skeleton, but this is 
definitely a better approach.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory
  2008-03-20  4:15   ` Sean Perry
@ 2008-03-20  4:46     ` Hebbar
  2008-04-01  0:12       ` Hebbar
  0 siblings, 1 reply; 5+ messages in thread
From: Hebbar @ 2008-03-20  4:46 UTC (permalink / raw)
  To: buildroot


Hi,

>
>Ulf Samuelsson wrote:
>> 
>> If someone wants to have a custom skeleton, why not
>> create support for a new board where the board makefile
>> specifies the target skeleton.
>> 
>> I can't really see why you want to be able to specify a non-existing
>> skeleton.
>> 
>
>because not all of us need or want to go through setting up a board, 
>project, et al.
>
>At work we use busybox on IA32 for IA32 and I have to use glibc, so I 
>use crosstool as an external toolchain. It all works, and works quite 
>well. I just hand hacked the config to use my skeleton, but this is 
>definitely a better approach.


shaleh, i 2nd you

Ulf Samuelsson, I use most of the stuff that comes with default config.in
but i want to use a different skeleton, with our own customs directories,
file, device nodes. I dont want to add code to all the places inside target,
with board specific parameters. i just want to have my own skeleton and use
default config  values. So adding this patch, would allow me to specify
custom skeleton instead of hacing the config files. 

Regards
Gururaja
-- 
View this message in context: http://www.nabble.com/-PATCH--Allow-users-to-choose-Custom-Skeleton-directory-tp16135129p16171529.html
Sent from the BuildRoot mailing list archive at Nabble.com.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory
  2008-03-20  4:46     ` Hebbar
@ 2008-04-01  0:12       ` Hebbar
  0 siblings, 0 replies; 5+ messages in thread
From: Hebbar @ 2008-04-01  0:12 UTC (permalink / raw)
  To: buildroot


Hi,

    can anyone update me about this patch. does this patch needs any
changes/updates/removals to be applied. 

Atleast can anyone tell y this hasnt made to the final version.

Regards
Gururaja

-- 
View this message in context: http://www.nabble.com/-PATCH--Allow-users-to-choose-Custom-Skeleton-directory-tp16135129p16400912.html
Sent from the BuildRoot mailing list archive at Nabble.com.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-04-01  0:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-19  1:06 [Buildroot] [PATCH] Allow users to choose Custom Skeleton directory Hebbar
2008-03-19 21:45 ` Ulf Samuelsson
2008-03-20  4:15   ` Sean Perry
2008-03-20  4:46     ` Hebbar
2008-04-01  0:12       ` Hebbar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox