Re: [Buildroot] [PATCH v2 1/4] package/wilc1000-firmware: bump to 15.6

[Kris Bahnsen via buildroot <buildroot@buildroot.org>]

On Mon, 2022-04-25 at 22:04 +0200, Arnout Vandecappelle wrote:

[snip]
>   Hash for the license file you added was missing.

[snip]
>   We actually use proprietary to mark any non-open-source license. The idea is 
> that SPDX is uses for the LICENSE variable (with an exception: adding + instead 
> of -or-later, and no -only). This is not done consistently, but I don't want to 
> go in the wrong direction :-). And maybe there's something to be said for using 
> a more descriptive license name than proprietary, but this shouldn't be snuck in 
> with a version bump.

I was not aware of either of these details. Thanks for the clarification, I'll
keep them in mind for the future!

-Kris

> 
> 
>   Regards,
>   Arnout
> 
> > +WILC1000_FIRMWARE_LICENSE_FILES = LICENSE.wilc_fw
> >   
> > -define WILC1000_FIRMWARE_EXTRACT_CMDS
> > -	$(UNZIP) -d $(BUILD_DIR) $(WILC1000_FIRMWARE_DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
> > -	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
> > -	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
> > +ifeq ($(BR2_PACKAGE_WILC1000_FIRMWARE),y)
> > +WILC1000_FIRMWARE_FILES += \
> > +	wilc1000_wifi_firmware.bin
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_WILC3000_FIRMWARE),y)
> > +WILC1000_FIRMWARE_FILES += \
> > +	wilc3000_ble_firmware.bin \
> > +	wilc3000_wifi_firmware.bin
> > +endif
> > +
> > +define WILC1000_FIRMWARE_INSTALL_FILES
> > +	cd $(@D) && \
> > +		$(TAR) cf install.tar $(sort $(WILC1000_FIRMWARE_FILES)) && \
> > +		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware/mchp
> >   endef
> >   
> >   define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
> > -	$(INSTALL) -D -m 0644 $(@D)/wilc1003_firmware.bin \
> > -		$(TARGET_DIR)/lib/firmware/atmel/wilc1003_firmware.bin
> > +	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/mchp/
> > +	$(WILC1000_FIRMWARE_INSTALL_FILES)
> >   endef
> >   
> >   $(eval $(generic-package))
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot