Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Bahnsen via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>, buildroot@buildroot.org
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mark Featherston <mark@embeddedTS.com>
Subject: Re: [Buildroot] [PATCH v2 3/4] configs: add WILC3000_FIRMWARE to compatible devices
Date: Mon, 25 Apr 2022 13:28:18 -0700	[thread overview]
Message-ID: <1650918498.6000.6.camel@embeddedTS.com> (raw)
In-Reply-To: <81c16e83-25d8-d047-4752-b33daa2e91f4@mind.be>

On Mon, 2022-04-25 at 22:07 +0200, Arnout Vandecappelle wrote:
> 
> On 23/04/2022 00:36, Kris Bahnsen via buildroot wrote:
> > The update to wilc-firmware added firmware files for WILC3000
> > devices as a separate config option. All Atmel/Microchip defconfigs
> > that previously only had WILC1000_FIRMWARE either have WILC3000
> > Wi-Fi hardware (WILC3000 is the same silicon but with BLE added)
> 
>   For the ones which have a WILC3000, there's no point to include the WILC1000 
> firmware, right?

I'm not familiar with the full Microchip lineup. Some have these modules soldered
down, others, however, can accept either module via some expansion/interconnect
system. I thought it safer to install both.

In Microchip's externally maintained tree, they just install all .bin files
together with their wilc-firmware package.

These defconfigs definitely need some maintenance though, as I said in the series
cover letter, the defconfig I tried failed to boot when built from master.

-Kris

> 
>   Anyway, applied to master as is, thanks. Can be fixed up later.
> 
>   Regards,
>   Arnout
> 
> > or have the capacity to have either WILC1000 or WILC3000 devices
> > added to the system. Install all firmware blobs to these devices
> > by default.
> > 
> > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
> > ---
> >   configs/at91sam9x5ek_dev_defconfig                     | 1 +
> >   configs/at91sam9x5ek_mmc_dev_defconfig                 | 1 +
> >   configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig       | 1 +
> >   configs/atmel_sama5d2_xplained_mmc_dev_defconfig       | 1 +
> >   configs/atmel_sama5d3_xplained_dev_defconfig           | 1 +
> >   configs/atmel_sama5d3_xplained_mmc_dev_defconfig       | 1 +
> >   configs/atmel_sama5d4_xplained_dev_defconfig           | 1 +
> >   configs/atmel_sama5d4_xplained_mmc_dev_defconfig       | 1 +
> >   configs/microchip_sam9x60ek_mmc_dev_defconfig          | 1 +
> >   configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig | 1 +
> >   configs/microchip_sama5d2_icp_mmc_dev_defconfig        | 1 +
> >   configs/microchip_sama7g5ek_mmc_dev_defconfig          | 1 +
> >   12 files changed, 12 insertions(+)
> > 
> > diff --git a/configs/at91sam9x5ek_dev_defconfig b/configs/at91sam9x5ek_dev_defconfig
> > index bfa8e95941..8714463d89 100644
> > --- a/configs/at91sam9x5ek_dev_defconfig
> > +++ b/configs/at91sam9x5ek_dev_defconfig
> > @@ -47,6 +47,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/at91sam9x5ek_mmc_dev_defconfig b/configs/at91sam9x5ek_mmc_dev_defconfig
> > index 2e1a5c7f59..9481594716 100644
> > --- a/configs/at91sam9x5ek_mmc_dev_defconfig
> > +++ b/configs/at91sam9x5ek_mmc_dev_defconfig
> > @@ -50,6 +50,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> > index ba2fa46790..38618a5732 100644
> > --- a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> > +++ b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> > @@ -39,6 +39,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_RNG_TOOLS=y
> > diff --git a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> > index a8b68ca0a2..1654408aa5 100644
> > --- a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> > +++ b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> > @@ -53,6 +53,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/atmel_sama5d3_xplained_dev_defconfig b/configs/atmel_sama5d3_xplained_dev_defconfig
> > index cdfd9de17e..64455cb2e0 100644
> > --- a/configs/atmel_sama5d3_xplained_dev_defconfig
> > +++ b/configs/atmel_sama5d3_xplained_dev_defconfig
> > @@ -49,6 +49,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> > index a2205aeefa..8f5724d631 100644
> > --- a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> > +++ b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> > @@ -52,6 +52,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/atmel_sama5d4_xplained_dev_defconfig b/configs/atmel_sama5d4_xplained_dev_defconfig
> > index f8783f5652..fab91cf0b3 100644
> > --- a/configs/atmel_sama5d4_xplained_dev_defconfig
> > +++ b/configs/atmel_sama5d4_xplained_dev_defconfig
> > @@ -50,6 +50,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> > index b4e99f658a..f9074e9862 100644
> > --- a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> > +++ b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> > @@ -53,6 +53,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/microchip_sam9x60ek_mmc_dev_defconfig b/configs/microchip_sam9x60ek_mmc_dev_defconfig
> > index 06e03967c4..2b4e234297 100644
> > --- a/configs/microchip_sam9x60ek_mmc_dev_defconfig
> > +++ b/configs/microchip_sam9x60ek_mmc_dev_defconfig
> > @@ -36,6 +36,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig b/configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig
> > index 3bcd5f0200..f9aa6cdc05 100644
> > --- a/configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig
> > +++ b/configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig
> > @@ -39,6 +39,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_I2C_TOOLS=y
> >   BR2_PACKAGE_SETSERIAL=y
> > diff --git a/configs/microchip_sama5d2_icp_mmc_dev_defconfig b/configs/microchip_sama5d2_icp_mmc_dev_defconfig
> > index 27d1d3409d..b1b22c1312 100644
> > --- a/configs/microchip_sama5d2_icp_mmc_dev_defconfig
> > +++ b/configs/microchip_sama5d2_icp_mmc_dev_defconfig
> > @@ -32,6 +32,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_SETSERIAL=y
> >   BR2_PACKAGE_SPI_TOOLS=y
> > diff --git a/configs/microchip_sama7g5ek_mmc_dev_defconfig b/configs/microchip_sama7g5ek_mmc_dev_defconfig
> > index 6eb6c282e0..d68846e553 100644
> > --- a/configs/microchip_sama7g5ek_mmc_dev_defconfig
> > +++ b/configs/microchip_sama7g5ek_mmc_dev_defconfig
> > @@ -30,6 +30,7 @@ BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> >   BR2_PACKAGE_MMC_UTILS=y
> >   BR2_PACKAGE_MTD=y
> >   BR2_PACKAGE_WILC1000_FIRMWARE=y
> > +BR2_PACKAGE_WILC3000_FIRMWARE=y
> >   BR2_PACKAGE_EVTEST=y
> >   BR2_PACKAGE_RNG_TOOLS=y
> >   # BR2_PACKAGE_RNG_TOOLS_JITTERENTROPY_LIBRARY is not set
> 
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-25 20:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 22:36 [Buildroot] [PATCH v2 0/4] Pull in WILC Wi-Fi updates Kris Bahnsen via buildroot
2022-04-22 22:36 ` [Buildroot] [PATCH v2 1/4] package/wilc1000-firmware: bump to 15.6 Kris Bahnsen via buildroot
2022-04-25 20:04   ` Arnout Vandecappelle
2022-04-25 20:16     ` Kris Bahnsen via buildroot
2022-04-22 22:36 ` [Buildroot] [PATCH v2 2/4] package/wilc-firmware: rename from wilc1000-firmware Kris Bahnsen via buildroot
2022-04-25 20:06   ` Arnout Vandecappelle
2022-04-22 22:36 ` [Buildroot] [PATCH v2 3/4] configs: add WILC3000_FIRMWARE to compatible devices Kris Bahnsen via buildroot
2022-04-25 20:07   ` Arnout Vandecappelle
2022-04-25 20:28     ` Kris Bahnsen via buildroot [this message]
2022-04-22 22:36 ` [Buildroot] [PATCH v2 4/4] package/wilc-driver: new package Kris Bahnsen via buildroot
2022-04-25 20:08   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650918498.6000.6.camel@embeddedTS.com \
    --to=buildroot@buildroot.org \
    --cc=arnout@mind.be \
    --cc=eugen.hristev@microchip.com \
    --cc=kris@embeddedTS.com \
    --cc=ludovic.desroches@microchip.com \
    --cc=mark@embeddedTS.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox