Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure up to Linux 6.1

[Kris Bahnsen via buildroot <buildroot@buildroot.org>]

On Wed, 2022-12-28 at 21:53 +0100, Giulio Benetti wrote:
> Add patches pending upstream[0] to handle various data types and api
> changes up to Linux 6.1.
> 
> [0]: https://github.com/embeddedTS/wilc3000-external-module/pull/2
> 
> Fixes:
> http://autobuild.buildroot.net/results/6aa7475a21a6060e9fce3552f73e6e7100a8b2aa
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  ...missing-prandom_u32-with-Linux-6.1.0.patch |  34 +++
>  ...fix-build-failure-on-remove-callback.patch |  44 ++++
>  ...uild-failure-with-Linux-5.19-and-6.1.patch |  98 ++++++++
>  ...on_parameters-Linux-6.1-build-failur.patch | 216 ++++++++++++++++++
>  4 files changed, 392 insertions(+)
>  create mode 100644 package/wilc-driver/0001-cfg80211.c-fix-missing-prandom_u32-with-Linux-6.1.0.patch
>  create mode 100644 package/wilc-driver/0002-spi.c-fix-build-failure-on-remove-callback.patch
>  create mode 100644 package/wilc-driver/0003-cfg80211.c-fix-build-failure-with-Linux-5.19-and-6.1.patch
>  create mode 100644 package/wilc-driver/0004-Fix-struct-station_parameters-Linux-6.1-build-failur.patch
> 

Giulio, all,

I figure this is the most appropriate place to have a discussion on
this topic as these patches were also pushed to our github repo:
https://github.com/embeddedTS/wilc3000-external-module/

I want to note that we are not intending on doing any maintenance
or patch work on this driver, except to keep this driver functional
on our platforms. It is maintained as a buildable external module
of this folder tree:
https://github.com/linux4sam/linux-at91/tree/master/drivers/net/wireless/microchip

We did this because during the Microchip takeover they abandoned
their maintained external tree as well as halted any plans to
bring WILC3000 support to the kernel upstream. Our fork gives us
easy access to building the modules without having to keep pulling
changes in to all of our kernels.

I'm not sure the best way to go about handling these patches as
Microchip is currently only maintaining support for 5.15 it
appears. I also don't want to pollute our external module tree
with fixes that arn't in the upstream we're pulling in.

Giulio, would you be willing to attempt pushing these changes
to the Microchip repo?

Does it make more sense to just leave these as patches to the
driver in Buildroot?

Would it make sense to instead apply some limits to the package
or external module to only build on already compatible kernel
versions?

-Kris
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot