Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32
Date: Fri, 22 Feb 2013 12:55:09 +0100 (CET)	[thread overview]
Message-ID: <1754953585.57239.1361534109750.JavaMail.root@advansee.com> (raw)
In-Reply-To: <CAHt8ZCNfxNTptRTohRX24h9Gbm89jWfaWAS89yGv6-B68AAjQA@mail.gmail.com>

On Friday, February 22, 2013 9:21:49 AM, Simon Dawson wrote:
> Hi Gilles,
> 
> On 22 February 2013 01:01, Gilles Talis <gilles.talis@gmail.com> wrote:
> > Fixes:
> > http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
> > http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d
> >
> > Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> 
> This looks fine, but wouldn't it be simpler to just do
> 
> config BR2_PACKAGE_LIBMAD
>   bool "libmad"
>   select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32
> 
> in the libmad Config.in?

I agree, all the more looking only at Config.in, one could think that this is
doing exactly the opposite.

Best regards,
Beno?t

  reply	other threads:[~2013-02-22 11:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22  1:01 [Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32 Gilles Talis
2013-02-22  8:21 ` Simon Dawson
2013-02-22 11:55   ` Benoît Thébaudeau [this message]
2013-02-22 13:24   ` Peter Korsgaard
2013-02-22 18:55     ` Gilles Talis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1754953585.57239.1361534109750.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox