From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32
Date: Fri, 22 Feb 2013 14:24:55 +0100 [thread overview]
Message-ID: <87vc9keb14.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAHt8ZCNfxNTptRTohRX24h9Gbm89jWfaWAS89yGv6-B68AAjQA@mail.gmail.com> (Simon Dawson's message of "Fri, 22 Feb 2013 08:21:49 +0000")
>>>>> "Simon" == Simon Dawson <spdawson@gmail.com> writes:
Simon> Hi Gilles,
Simon> On 22 February 2013 01:01, Gilles Talis <gilles.talis@gmail.com> wrote:
>> Fixes:
>> http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
>> http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d
>>
>> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
Simon> This looks fine, but wouldn't it be simpler to just do
Simon> config BR2_PACKAGE_LIBMAD
Simon> bool "libmad"
Simon> select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32
Simon> in the libmad Config.in?
Indeed. That or simply hiding (forcing) the option on avr32, E.G.:
config BR2_PACKAGE_LIBMAD_ASO
bool "Architecture-specific optimizations" if !BR2_avr32
default y
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-02-22 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 1:01 [Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32 Gilles Talis
2013-02-22 8:21 ` Simon Dawson
2013-02-22 11:55 ` Benoît Thébaudeau
2013-02-22 13:24 ` Peter Korsgaard [this message]
2013-02-22 18:55 ` Gilles Talis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc9keb14.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox