Re: [Buildroot] [RFC PATCH v1 1/2] package/sysdig: bump to version 0.31.4

[Francis Laniel <flaniel@linux.microsoft.com>]

Hi.

Le lundi 31 juillet 2023, 22:18:43 CEST Thomas Petazzoni a écrit :
> Hello Francis (and perhaps Angelo who can help?),
> 
> On Fri, 28 Apr 2023 16:22:10 +0100
> 
> Francis Laniel <flaniel@linux.microsoft.com> wrote:
> > - Remove upstream patch as it is no more needed.
> 
> Actually I had to remove it from current master, because sysdig was
> bumped to 0.29.3 already, which includes the patch... and so the patch
> in Buildroot doesn't apply anymore.
> 
> I tested your version bump, and it fails to build with:
> 
> CMake Error at
> /home/thomas/projets/buildroot/output/build/falcosecurity-libs-e5c53d648f3c
> 4694385bbe488e7d47eaa36c229a/userspace/libscap/CMakeLists.txt:131
> (add_subdirectory): The binary directory
> 
>    
> /home/thomas/projets/buildroot/output/build/sysdig-0.31.4/buildroot-build/d
> river
> 
>   is already used to build a source directory.  It cannot be used to build
>   source directory
> 
>    
> /home/thomas/projets/buildroot/output/build/falcosecurity-libs-e5c53d648f3c
> 4694385bbe488e7d47eaa36c229a/driver
> 
>   Specify a unique binary directory name.
> 
> during the configuration step of sysdig.
> 
> Configuration tested:
> 
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1"
> BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_SYSDIG=y
> BR2_PACKAGE_LUA=y
> BR2_PACKAGE_LUA_5_1=y
> # BR2_TARGET_ROOTFS_TAR is not set

> it would be good to have a runtime test for sysdig in support/testing/,
> as it's not trivial to build, and the autobuilders never caught the
> patching issue.

Good idea! I will check how I can do that!

> >  SYSDIG_CONF_OPTS +=
> >  -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR) \> 
> > +	-DDRIVER_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR)/driver \
> 
> So apparently something goes wrong with this. Perhaps because
> falcosecurity-libs needs to be bumped first?

As you advised, bumping first the libs then the binary removed the above 
problem, thank you!
Regarding this, I am wondering if I should bump both of them in the same 
commit, as they are tightly coupled. What do you think?

Note that, I had to make linux-menuconfig to add CONFIG_IPV6, to avoid some 
compile errors due to some missing IPv6 related fields while compiling the 
kernel module which is parts of the libs.

> >  	-DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson \
> 
> One thing that is a bit annoying with the packaging here is the fact
> that sysdig needs to look into the source directory of
> falcosecurity-libs and the source tree of valijson. Packages should
> normally not need to access the source/build tree of other packages.
> Not a strict requirement for this version bump, but would be good to
> address on the long run.
> 
> By the way
> -DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson is truly
> horrible, because if valijson gets updated to another version... like
> it has:
> 
> VALIJSON_VERSION = 0.7
> 
> then this doesn't work anymore.
> 
> It needs to be VALIJSON_SRCDIR.
> 
> Curious that we can build sysdig today (I verified, it builds) with
> this mistake. Probably means this option is irrelevant.
> 
> Could you have a look at all those issues?

I removed everything about VALIJSON and it builds fine.
Glad making it simpler permits to build it!

> Thanks!
> 
> Thomas




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot