From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Francis Laniel <flaniel@linux.microsoft.com>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH v1 1/2] package/sysdig: bump to version 0.31.4
Date: Mon, 31 Jul 2023 22:35:52 +0200 [thread overview]
Message-ID: <20230731223552.6d2187cf@windsurf> (raw)
In-Reply-To: <20230731221843.61feafea@windsurf>
On Mon, 31 Jul 2023 22:18:43 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> By the way
> -DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson is truly
> horrible, because if valijson gets updated to another version... like
> it has:
>
> VALIJSON_VERSION = 0.7
>
> then this doesn't work anymore.
>
> It needs to be VALIJSON_SRCDIR.
>
> Curious that we can build sysdig today (I verified, it builds) with
> this mistake. Probably means this option is irrelevant.
(1) There is no build dependency on valijson, so I don't see how it
could be relevant anyway.
(2) There is no reference to VALIJSON_INCLUDE anywhere in the code
base, as far as I can see
This really needs to be cleaned up. Very soon.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-31 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 15:22 [Buildroot] [RFC PATCH v1 0/2] Bump sysdig and falco libs Francis Laniel
2023-04-28 15:22 ` [Buildroot] [RFC PATCH v1 1/2] package/sysdig: bump to version 0.31.4 Francis Laniel
2023-07-31 20:18 ` Thomas Petazzoni via buildroot
2023-07-31 20:35 ` Thomas Petazzoni via buildroot [this message]
2023-08-11 15:18 ` Francis Laniel
2023-04-28 15:22 ` [Buildroot] [RFC PATCH v1 2/2] package/falcosecurity-libs: bump to version 0.10.5 Francis Laniel
2023-07-31 20:49 ` Thomas Petazzoni via buildroot
2023-08-11 15:18 ` Francis Laniel
2023-07-07 14:26 ` [Buildroot] [RFC PATCH v1 0/2] Bump sysdig and falco libs Francis Laniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731223552.6d2187cf@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo.compagnucci@gmail.com \
--cc=flaniel@linux.microsoft.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox