Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/util-linux: revert logic regarding pam_selinux module
Date: Sat, 21 Sep 2019 13:50:18 +0200	[thread overview]
Message-ID: <1d6447af-d4ae-0089-e757-946f6289729c@mind.be> (raw)
In-Reply-To: <20190914170922.26874-1-unixmania@gmail.com>



On 14/09/2019 19:09, unixmania at gmail.com wrote:
> From: Carlos Santos <unixmania@gmail.com>
> 
> Leave pam_selinux enabled by default in su.pam and remove it from the
> /etc/pam.d/su and /etc/pam.d/su-l files if libselinux is not selected.
> 
> This prevents leaving a misleading line, even commented, referencing a
> PAM module that does not exist.

 I've slightly reworded this and committed to master, thanks.

 Regards,
 Arnout

> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
>  package/util-linux/su.pam        | 4 ++--
>  package/util-linux/util-linux.mk | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/package/util-linux/su.pam b/package/util-linux/su.pam
> index 84b18605ce..69b2a40c45 100644
> --- a/package/util-linux/su.pam
> +++ b/package/util-linux/su.pam
> @@ -7,9 +7,9 @@ account		required	pam_unix.so
>  
>  password	required	pam_unix.so nullok
>  
> -# session	required	pam_selinux.so close
> +session		required	pam_selinux.so close
>  session		required	pam_limits.so
>  session		required	pam_env.so
>  session		required	pam_unix.so
>  session		optional	pam_lastlog.so
> -# session	required	pam_selinux.so open
> +session		required	pam_selinux.so open
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index cd69838046..35f9fc16ac 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -75,14 +75,14 @@ UTIL_LINUX_MAKE_OPTS += LIBS="$(UTIL_LINUX_LIBS)"
>  ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
>  UTIL_LINUX_DEPENDENCIES += libselinux
>  UTIL_LINUX_CONF_OPTS += --with-selinux
> +else
> +UTIL_LINUX_CONF_OPTS += --without-selinux
>  define UTIL_LINUX_SELINUX_PAMFILES_TWEAK
>  	$(foreach f,su su-l,
> -		$(SED) 's/^# \(.*pam_selinux.so.*\)$$/\1/' \
> +		$(SED) '/^.*pam_selinux.so.*$$/d' \
>  			$(TARGET_DIR)/etc/pam.d/$(f)
>  	)
>  endef
> -else
> -UTIL_LINUX_CONF_OPTS += --without-selinux
>  endif
>  
>  # Used by cramfs utils
> 

      parent reply	other threads:[~2019-09-21 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-14 17:09 [Buildroot] [PATCH] package/util-linux: revert logic regarding pam_selinux module unixmania at gmail.com
2019-09-15 14:00 ` Thomas Petazzoni
2019-09-15 14:16   ` Carlos Santos
2019-09-21 11:50 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d6447af-d4ae-0089-e757-946f6289729c@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox