From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/util-linux: revert logic regarding pam_selinux module
Date: Sun, 15 Sep 2019 16:00:36 +0200 [thread overview]
Message-ID: <20190915160036.5a86509e@windsurf.home> (raw)
In-Reply-To: <20190914170922.26874-1-unixmania@gmail.com>
Hello Carlos,
On Sat, 14 Sep 2019 14:09:22 -0300
unixmania at gmail.com wrote:
> From: Carlos Santos <unixmania@gmail.com>
>
> Leave pam_selinux enabled by default in su.pam and remove it from the
> /etc/pam.d/su and /etc/pam.d/su-l files if libselinux is not selected.
>
> This prevents leaving a misleading line, even commented, referencing a
> PAM module that does not exist.
Just to make sure I understand: the motivation for this patch is just
to avoid the pam_selinux.so lines that remain present (but commented)
in the file when SELinux support is disabled ?
I.e, it is just cosmetic, but functional, correct ?
(This is not a criticism of the proposal, just an attempt to make sure
I'm not missing the point.)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-15 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 17:09 [Buildroot] [PATCH] package/util-linux: revert logic regarding pam_selinux module unixmania at gmail.com
2019-09-15 14:00 ` Thomas Petazzoni [this message]
2019-09-15 14:16 ` Carlos Santos
2019-09-21 11:50 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915160036.5a86509e@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox