Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

["Eugen.Hristev--- via buildroot" <buildroot@buildroot.org>]

On 4/12/22 2:43 PM, Eugen Hristev - M18282 wrote:
> On 4/12/22 2:33 PM, Peter Korsgaard wrote:
>>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> Hi,
>>
>>>> Hello Peter, Fabrice,
>>    >>
>>    >> While your patch solves the isc/boolean.h problem, now I get several
>>    >> other problems when building an arm926 platform with this package :
>>    >> (sam9x60ek)
>>    >>
>>    >> Could you help please? 2022.01.1 is broken for me atm.
>>
>>    > You should apply:
>>    > https://git.buildroot.net/buildroot/commit/?id=789a08dac5808401629d6fc586b7377f54ebb316
>>
>> That is already in 202.02.1:
>>
>> https://git.buildroot.net/buildroot/commit/?h=2022.02.x&id=0397064a9a147903e9e0c16b2506319ea4a246fb
>>
>>> as well as
>>    > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>>
>> Is that an ack? ;)
> 
> I am testing that patch to see if it improves anything, but as you said
> Peter, the commit above is already in my tree.

It appears that with this patch, I am getting both errors :


 >>> dhcp 4.4.2-P1 Building
PATH="/home/eugen/buildroot-2022.02/buildroot/output/host/bin:/home/eugen/buildroot-2022.02/buildroot/output/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" 
  /usr/bin/make -j1  -C 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/
Making all in ./bind
Configuring BIND libraries for DHCP.
configure: WARNING: using cross tools not prefixed with host triplet
Building BIND libraries - this takes some time.
Building isc library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isc
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/bits/libc-header-start.h:33,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/limits.h:26,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/limits.h:195,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/syslimits.h:7,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/limits.h:34,
                  from ./include/isc/platform.h:218,
                  from ./include/isc/bind9.h:18,
                  from ./include/isc/types.h:19,
                  from ./include/isc/safe.h:20,
                  from ./safe.c:18:
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/features.h:412:4: 
warning: #warning _FORTIFY_SOURCE requires compiling with optimization 
(-O) [-Wcpp]
   412 | #  warning _FORTIFY_SOURCE requires compiling with optimization 
(-O)
       |    ^~~~~~~
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1
Building dns library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns
libtool:   error: cannot find the library '../../lib/isc/libisc.la' or 
unhandled argument '../../lib/isc/libisc.la'
make[4]: *** [Makefile:593: libdns.la] Error 1
Building isccfg library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg
libtool:   error: cannot find the library '../../lib/dns/libdns.la' or 
unhandled argument '../../lib/dns/libdns.la'
make[4]: *** [Makefile:482: libisccfg.la] Error 1
Building irs library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/irs
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
Installing BIND libraries to 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind.
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1
libtool:   error: cannot find the library '../../lib/isc/libisc.la' or 
unhandled argument '../../lib/isc/libisc.la'
make[4]: *** [Makefile:593: libdns.la] Error 1
libtool:   error: cannot find the library '../../lib/dns/libdns.la' or 
unhandled argument '../../lib/dns/libdns.la'
make[4]: *** [Makefile:482: libisccfg.la] Error 1
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include/irs
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/lib
Making all in includes
/usr/bin/make  all-am
Making all in tests
make[3]: Nothing to be done for 'all'.
Making all in common
Making all in .
/bin/bash ../libtool  --tag=CC   --mode=compile 
/home/eugen/buildroot-2022.02/buildroot/output/host/bin/arm-buildroot-linux-gnueabi-gcc 
-DHAVE_CONFIG_H -I. -I../includes  -I.. -DLOCALSTATEDIR='"/var"' 
-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" 
-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"  -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Ofast -g0 
-D_FORTIFY_SOURCE=1 -DISC_CHECK_NONE=1  -I../includes 
-I/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include 
-c -o alloc.lo alloc.c
libtool: compile: 
/home/eugen/buildroot-2022.02/buildroot/output/host/bin/arm-buildroot-linux-gnueabi-gcc 
-DHAVE_CONFIG_H -I. -I../includes -I.. -DLOCALSTATEDIR=\"/var\" 
-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" 
-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\" -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Ofast -g0 
-D_FORTIFY_SOURCE=1 -DISC_CHECK_NONE=1 -I../includes 
-I/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include 
-c alloc.c  -fPIC -DPIC -o .libs/alloc.o
In file included from ../includes/dhcpd.h:91,
                  from alloc.c:29:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such 
file or directory
    51 | #include <isc/boolean.h>
       |          ^~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:561: alloc.lo] Error 1
make[3]: *** [Makefile:619: all-recursive] Error 1
make[2]: *** [Makefile:495: all-recursive] Error 1
make[1]: *** [package/pkg-generic.mk:292: 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/.stamp_built] 
Error 2
make: *** [Makefile:84: _all] Error 2


>>
>>    > Having said that, I fear that dhcp will have to be removed soon due to
>>    > security concerns:
>>    > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233
>>
>> Yeah. Eugen, is there any specific reason why you use the dhcp package
>> over the other DHCP clients we provide?
> 
> Historical reasons, and the fact that people have working configurations
> using this package... I was unaware that it was due to be removed.
> We will try to switch to a different package in the future. Thanks for
> letting me know.
> However, if the package is still in this buildroot release, it has to
> work right ?
>>
>> --
>> Bye, Peter Korsgaard
>>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot