Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Seiderer <ps.report@gmx.net>]

Hello Tim,

On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:

> On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > Dear Tim,
> > 
> > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :  
> > >
> > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:  
> > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > doesn't plan to fix it any time soon:
> > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > >
> > > > In file included from ../includes/dhcpd.h:91,
> > > >                  from ctrace.c:29:
> > > > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> > > >    51 | #include <isc/boolean.h>
> > > >       |          ^~~~~~~~~~~~~~~
> > > >
> > > >   ...
> > > >
> > > >  # use libtool-enabled configure.ac
> > > >  define DHCP_LIBTOOL_AUTORECONF
> > > > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> > > >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> > > >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> > > >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > > > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> > > >  
> > >
> > > The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> > > So this should be the host compiler, not the target.
> > > I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...  
> > 
> > Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
> > The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).
> >   
> 
> This is why I said I do not know the correct way- when I use $(HOST_CC), I get
>      >>> dhcp 4.4.2-P1 Building  
>      PATH="/home/thammer/Public/buildroot/TEST/host/bin:/home/thammer/Public/buildroot/TEST/host/sbin:/home/thammer/.local/bin:/home/thammer/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/altera/nios2eds/bin/gnu/H-x86_64-pc-linux-gnu/bin:/opt/altera/nios2eds/sdk2/bin:/opt/altera/nios2eds/bin:/opt/altera/quartus/bin:/opt/altera/quartus/sopc_builder/bin"  /usr/bin/make -j1  -C /home/thammer/Public/buildroot/TEST/build/dhcp-4.4.2-P1/
>      Making all in ./bind
>      Configuring BIND libraries for DHCP.
>      configure: WARNING: using cross tools not prefixed with host triplet
>      configure: error: BUILD_CC not set
>      make[3]: *** [Makefile:42: bind1] Error 1
> 
> 
> > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > also be updated?  
> 
> I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> 
>      gen: gen.c
> 	${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> 	${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> 
> Perhaps we should be patching that file instead of the config?

See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch

Regards,
Peter


> 
> > 
> > Could you send those two patches (dhcp and bind) to the buildroot
> > mailing or do you prefer that I send them?
> >   
> 
> I can try out my other thought and send that in a while (if it seems to work).
> 
> > > ...
> > >  
> > 
> > Best Regards,
> > Fabrice  
> 
> .Tim
> Tim D. Hammer
> tim.hammer@orolia.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot