[Buildroot] [patch] mpg123 build issues

[Buildroot] [patch] mpg123 build issues

[Ulrich Hecht]

Hi!

The current mpg123 package

- ignores TARGET_CC (overwritten in Makefile)
- ignores TARGET_CFLAGS
- is hardcoded to use the i386 target

The attached patch fixes these issues.

CU
Uli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123.patch
Type: text/x-diff
Size: 2605 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20061214/2c169aab/attachment.bin 

[Buildroot] [patch] mpg123 build issues

[Bernhard Fischer]

On Thu, Dec 14, 2006 at 04:02:15PM +0100, Ulrich Hecht wrote:
>Hi!
>
>The current mpg123 package
>
>- ignores TARGET_CC (overwritten in Makefile)
>- ignores TARGET_CFLAGS
>- is hardcoded to use the i386 target
>
>The attached patch fixes these issues.

May i ask you to verify that a) an mpg123 bug exists in the bug-database
and if so b) incooperate possible additional fixes?

TIA,
Bernhard

[Buildroot] [patch] mpg123 build issues

[Bernhard Fischer]

On Thu, Dec 14, 2006 at 04:53:07PM +0100, Ulrich Hecht wrote:
>Hi!
>
>On Thursday 14 December 2006 16:29, Bernhard Fischer wrote:
>> On Thu, Dec 14, 2006 at 04:02:15PM +0100, Ulrich Hecht wrote:
>> >Hi!
>> >
>> >The current mpg123 package
>> >
>> >- ignores TARGET_CC (overwritten in Makefile)
>> >- ignores TARGET_CFLAGS
>> >- is hardcoded to use the i386 target
>> >
>> >The attached patch fixes these issues.
>>
>> May i ask you to verify that a) an mpg123 bug exists in the
>> bug-database and if so b) incooperate possible additional fixes?
>
>I couldn't find any.

Thanks for checking. Merged.

[Buildroot] [patch] mpg123 build issues

[Pavel Roskin]

On Thu, 2006-12-14 at 17:03 +0100, Bernhard Fischer wrote:
> >> May i ask you to verify that a) an mpg123 bug exists in the
> >> bug-database and if so b) incooperate possible additional fixes?
> >
> >I couldn't find any.

Actually, I sent a patch that upgrades mpg123 to the latest version that
uses an Autoconf generated configure script.  It's much better than to
tweak makefiles not to ignore our variables.  Unfortunately, I was asked
additional questions that I didn't have time to answer.

The current version is 0.61.  My old patch doesn't apply anymore.
Here's the thread in case anyone wants to continue my effort:
http://buildroot.uclibc.org/lists/buildroot/2006-November/thread.html#626

-- 
Regards,
Pavel Roskin