[Buildroot] svn commit: trunk/buildroot/package/hostap

[Buildroot] svn commit: trunk/buildroot/package/hostap

[ulf at uclibc.org]

Author: ulf
Date: 2007-07-08 21:59:45 -0700 (Sun, 08 Jul 2007)
New Revision: 19051

Log:
WGET_NOSPIDERS is not defined, use WGET for now

Modified:
   trunk/buildroot/package/hostap/hostap.mk


Changeset:
Modified: trunk/buildroot/package/hostap/hostap.mk
===================================================================
--- trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:40:53 UTC (rev 19050)
+++ trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:59:45 UTC (rev 19051)
@@ -9,7 +9,7 @@
 HOSTAP_DIR=$(BUILD_DIR)/hostapd-$(HOSTAP_VERSION)
 
 $(DL_DIR)/$(HOSTAP_SOURCE):
-	$(WGET_NOSPIDERS) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
+	$(WGET) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
 
 hostap-source: $(DL_DIR)/$(HOSTAP_SOURCE)
 

[Buildroot] svn commit: trunk/buildroot/package/hostap

[Cristian Ionescu-Idbohrn]

On Sun, 8 Jul 2007, ulf at uclibc.org wrote:

> Author: ulf
> Date: 2007-07-08 21:59:45 -0700 (Sun, 08 Jul 2007)
> New Revision: 19051
>
> Log:
> WGET_NOSPIDERS is not defined, use WGET for now
>
> Modified:
>    trunk/buildroot/package/hostap/hostap.mk
>
>
> Changeset:
> Modified: trunk/buildroot/package/hostap/hostap.mk
> ===================================================================
> --- trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:40:53 UTC (rev 19050)
> +++ trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:59:45 UTC (rev 19051)
> @@ -9,7 +9,7 @@
>  HOSTAP_DIR=$(BUILD_DIR)/hostapd-$(HOSTAP_VERSION)
>
>  $(DL_DIR)/$(HOSTAP_SOURCE):
> -	$(WGET_NOSPIDERS) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
> +	$(WGET) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
>
>  hostap-source: $(DL_DIR)/$(HOSTAP_SOURCE)

Alright.  The problem here is that the wget '--spider' option does just
what the man-page says:

  --spider
      When invoked with this option, Wget will behave as a Web spider,
      which means that it will not download the pages, just check that
      they are there.

and hostap.epitest.fi replies accordingly, saying the file is there and
shows its size too.

  # make hostap-source
  wget --passive-ftp -nd --spider -P /data/cii/buildroot/buildroot/dl
  http://hostap.epitest.fi/releases/hostapd-0.5.8.tar.gz
  --09:59:41--  http://hostap.epitest.fi/releases/hostapd-0.5.8.tar.gz
             => `/data/cii/buildroot/buildroot/dl/hostapd-0.5.8.tar.gz'
  Resolving hostap.epitest.fi... 204.152.186.63
  Connecting to hostap.epitest.fi|204.152.186.63|:80... connected.
  HTTP request sent, awaiting response... 200 OK
  Length: 459,253 (448K) [application/x-tar]
  200 OK

Nothing is downloaded.  Patch attached.


-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hostap.mk.patch
Type: text/x-diff
Size: 563 bytes
Desc: 
Url : http://busybox.net/lists/buildroot/attachments/20070709/d1189220/attachment.bin 

[Buildroot] svn commit: trunk/buildroot/package/hostap

[Bernhard Fischer]

On Mon, Jul 09, 2007 at 10:18:21AM +0200, Cristian Ionescu-Idbohrn wrote:
>On Sun, 8 Jul 2007, ulf at uclibc.org wrote:
>
>> Author: ulf
>> Date: 2007-07-08 21:59:45 -0700 (Sun, 08 Jul 2007)
>> New Revision: 19051
>>
>> Log:
>> WGET_NOSPIDERS is not defined, use WGET for now
>>
>> Modified:
>>    trunk/buildroot/package/hostap/hostap.mk
>>
>>
>> Changeset:
>> Modified: trunk/buildroot/package/hostap/hostap.mk
>> ===================================================================
>> --- trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:40:53 UTC (rev 19050)
>> +++ trunk/buildroot/package/hostap/hostap.mk	2007-07-09 04:59:45 UTC (rev 19051)
>> @@ -9,7 +9,7 @@
>>  HOSTAP_DIR=$(BUILD_DIR)/hostapd-$(HOSTAP_VERSION)
>>
>>  $(DL_DIR)/$(HOSTAP_SOURCE):
>> -	$(WGET_NOSPIDERS) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
>> +	$(WGET) -P $(DL_DIR) $(HOSTAP_SITE)/$(HOSTAP_SOURCE)
>>
>>  hostap-source: $(DL_DIR)/$(HOSTAP_SOURCE)
>
>Alright.  The problem here is that the wget '--spider' option does just
>what the man-page says:
>
>  --spider
>      When invoked with this option, Wget will behave as a Web spider,
>      which means that it will not download the pages, just check that
>      they are there.
>
>and hostap.epitest.fi replies accordingly, saying the file is there and
>shows its size too.
>
>  # make hostap-source
>  wget --passive-ftp -nd --spider -P /data/cii/buildroot/buildroot/dl
>  http://hostap.epitest.fi/releases/hostapd-0.5.8.tar.gz
>  --09:59:41--  http://hostap.epitest.fi/releases/hostapd-0.5.8.tar.gz
>             => `/data/cii/buildroot/buildroot/dl/hostapd-0.5.8.tar.gz'
>  Resolving hostap.epitest.fi... 204.152.186.63
>  Connecting to hostap.epitest.fi|204.152.186.63|:80... connected.
>  HTTP request sent, awaiting response... 200 OK
>  Length: 459,253 (448K) [application/x-tar]
>  200 OK
>
>Nothing is downloaded.  Patch attached.

No. Fix your BR2_WGET instead:
BR2_WGET="wget --passive-ftp"

PS: sounds a bit like you did a source-check and forgot to reinstate
your sane config afterwards.

[Buildroot] svn commit: trunk/buildroot/package/hostap

[Cristian Ionescu-Idbohrn]

On Mon, 9 Jul 2007, Bernhard Fischer wrote:


> No. Fix your BR2_WGET instead:
> BR2_WGET="wget --passive-ftp"
>
> PS: sounds a bit like you did a source-check and forgot to reinstate
> your sane config afterwards.

BR2_WGET in my .config is set to this:

BR2_WGET="wget --passive-ftp -nd"

and I did not do it myself (it was supplied as default) AFAIR.

The I might have understood this target in the main Makefile:

.config.check: dependencies
	$(SED) '/BR2_WGET/s/\"$$/ --spider\"/g' .config
	touch $@

and I might still failing to understand it, but it's one thing to
temporarilly change BR2_WGET to do the checks and another thing to
force edit .config behind my back.

Could you please explain?


-- 
Cristian

[Buildroot] svn commit: trunk/buildroot/package/hostap

[Bernhard Fischer]

On Mon, Jul 09, 2007 at 11:32:07AM +0200, Cristian Ionescu-Idbohrn wrote:
>On Mon, 9 Jul 2007, Bernhard Fischer wrote:
>
>
>> No. Fix your BR2_WGET instead:
>> BR2_WGET="wget --passive-ftp"
>>
>> PS: sounds a bit like you did a source-check and forgot to reinstate
>> your sane config afterwards.
>
>BR2_WGET in my .config is set to this:
>
>BR2_WGET="wget --passive-ftp -nd"
>
>and I did not do it myself (it was supplied as default) AFAIR.
>
>The I might have understood this target in the main Makefile:
>
>.config.check: dependencies
>	$(SED) '/BR2_WGET/s/\"$$/ --spider\"/g' .config
>	touch $@
>
>and I might still failing to understand it, but it's one thing to
>temporarilly change BR2_WGET to do the checks and another thing to
>force edit .config behind my back.
>
>Could you please explain?

$ svn log -r18769  
------------------------------------------------------------------------
r18769 | aldot | 2007-06-07 14:57:03 +0200 (Thu, 07 Jun 2007) | 5 lines

- provide a "source-check" target that tries to download all packages
  with
  wget's spider-mode (i.e. just see if the server says the file is there without
  actually downloading the files.
  Convenient to check for unavailable source-packages.

------------------------------------------------------------------------

This is ment for developers who want to check for unavailable packages.
If you're uncomfortable with it, Don't Do That Then. And no, i don't
bother to save the config away. That's your duty (you most likely also
don't want to set all and every config option to yes for a real rootfs).

friendly,

[Buildroot] svn commit: trunk/buildroot/package/hostap

[Cristian Ionescu-Idbohrn]

On Mon, 9 Jul 2007, Bernhard Fischer wrote:

> $ svn log -r18769
> ------------------------------------------------------------------------
> r18769 | aldot | 2007-06-07 14:57:03 +0200 (Thu, 07 Jun 2007) | 5 lines
>
> - provide a "source-check" target that tries to download all packages with
>   wget's spider-mode (i.e. just see if the server says the file is there without
>   actually downloading the files.
>   Convenient to check for unavailable source-packages.
>
> ------------------------------------------------------------------------
>
> This is ment for developers who want to check for unavailable packages.
> If you're uncomfortable with it, Don't Do That Then. And no, i don't
> bother to save the config away. That's your duty (you most likely also
> don't want to set all and every config option to yes for a real rootfs).

Thanks for opening my eyes :)

But, wouldn't you agree that doing the same thing witout changing the
.config could be a much more elegant way to do it?


-- 
Cristian

[Buildroot] make source-check

[Bernhard Fischer]

On Mon, Jul 09, 2007 at 12:01:08PM +0200, Cristian Ionescu-Idbohrn wrote:
>On Mon, 9 Jul 2007, Bernhard Fischer wrote:

>But, wouldn't you agree that doing the same thing witout changing the
>.config could be a much more elegant way to do it?

If you have a better impl than my quick-hack, i'm eager to see it, sure.

[Buildroot] make source-check

[Cristian Ionescu-Idbohrn]

On Mon, 9 Jul 2007, Bernhard Fischer wrote:

> On Mon, Jul 09, 2007 at 12:01:08PM +0200, Cristian Ionescu-Idbohrn wrote:
> >On Mon, 9 Jul 2007, Bernhard Fischer wrote:
>
> >But, wouldn't you agree that doing the same thing witout changing the
> >.config could be a much more elegant way to do it?
>
> If you have a better impl than my quick-hack, i'm eager to see it, sure.

Looks like there might be another way: see info-node "6.10 Target-specific
Variable Values" in a recent manual.  What do you think of something like:

--- Makefile	(revision 19052)
+++ Makefile	(working copy)
@@ -222,11 +222,8 @@

 source: $(TARGETS_SOURCE) $(HOST_SOURCE)

-.config.check: dependencies
-	$(SED) '/BR2_WGET/s/\"$$/ --spider\"/g' .config
-	touch $@
-
-_source-check: .config.check
+_source-check: WGET += --spider
+_source-check:
 	$(MAKE) source

That is, the wget option '--spider' will be used _only_ by target
'_source-check' and the '.config' won't have to be edited behind one's
back.


-- 
Cristian