[Buildroot] [PATCH] Fix sed fail when building qtopia

[Buildroot] [PATCH] Fix sed fail when building qtopia

[Thiago A. Corrêa]

Hi there,

   This patch should fix the error:
   sed: -e expression #1, char 21: unknown option to `s'

   I am sure there is a better way to do this, but I'm not comfortable
with shell scripts enough, so, if someone has a better solution, by
all means :)

Chears,
   Thiago A. Correa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-qtopia.patch
Type: application/octet-stream
Size: 1615 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070820/52757f95/attachment.obj 

[Buildroot] [PATCH] Fix sed fail when building qtopia

[Bernhard Fischer]

On Mon, Aug 20, 2007 at 07:00:17PM +0100, Thiago A. Corr?a wrote:
>Hi there,
>
>   This patch should fix the error:
>   sed: -e expression #1, char 21: unknown option to `s'
>
>   I am sure there is a better way to do this, but I'm not comfortable
>with shell scripts enough, so, if someone has a better solution, by
>all means :)

ergh, that's rather ugly.
Please try to use this instead and let me know if that works for you:
$(SED) 's,-O2,$(TARGET_CFLAGS),' \
$(QTOPIA4_TARGET_DIR)/mkspecs/qws/linux-$(BR2_PACKAGE_QTOPIA4_EMB_PLATFORM)-g++/qmake.conf

(i.e. use ',' instead if '/'.

[Buildroot] [PATCH] Fix sed fail when building qtopia

[Thiago A. Corrêa]

Ops, didn't send the msg to the list, sorry. Perhaps one could
consider changing the default reply to the list rather than to the
poster.

Oh, btw, this patch fixes bug 0001457, please apply and close the
issue on the bugtracker. Thanks :)

---------- Forwarded message ----------
From: Thiago A. Corr?a <thiago.correa@gmail.com>
Date: Aug 20, 2007 7:36 PM
Subject: Re: [Buildroot] [PATCH] Fix sed fail when building qtopia
To: Bernhard Fischer <rep.dot.nop@gmail.com>


Yes, much better indeed. And it works fine now. At least that part so far :)

After that, I get a link error building moc, haven't figured that one yet.

I have attached the patch updated, thanks.

Cheers,
    Thiago A. Correa


On 8/20/07, Bernhard Fischer <rep.dot.nop@gmail.com> wrote:
> On Mon, Aug 20, 2007 at 07:00:17PM +0100, Thiago A. Corr?a wrote:
> >Hi there,
> >
> >   This patch should fix the error:
> >   sed: -e expression #1, char 21: unknown option to `s'
> >
> >   I am sure there is a better way to do this, but I'm not comfortable
> >with shell scripts enough, so, if someone has a better solution, by
> >all means :)
>
> ergh, that's rather ugly.
> Please try to use this instead and let me know if that works for you:
> $(SED) 's,-O2,$(TARGET_CFLAGS),' \
> $(QTOPIA4_TARGET_DIR)/mkspecs/qws/linux-$(BR2_PACKAGE_QTOPIA4_EMB_PLATFORM)-g++/qmake.conf
>
> (i.e. use ',' instead if '/'.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-qtopia.patch
Type: application/octet-stream
Size: 1425 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070821/456632e0/attachment.obj 

[Buildroot] [PATCH] Fix sed fail when building qtopia

[Bernhard Fischer]

On Mon, Aug 20, 2007 at 07:36:16PM +0100, Thiago A. Corr?a wrote:
>Yes, much better indeed. And it works fine now. At least that part so far :)
>
>After that, I get a link error building moc, haven't figured that one yet.
>
>I have attached the patch updated, thanks.

Applied. Thanks!