* [Buildroot] Quotes needed in package/Makefile.in
@ 2007-09-29 3:48 Dimitry Golubovsky
2007-09-29 10:05 ` Bernhard Fischer
0 siblings, 1 reply; 8+ messages in thread
From: Dimitry Golubovsky @ 2007-09-29 3:48 UTC (permalink / raw)
To: buildroot
Hi,
Please add quotes in package/Makefile.in, like this:
=====================================
--- package/Makefile.in.orig 2007-09-28 23:46:36.000000000 -0400
+++ package/Makefile.in 2007-09-28 23:45:23.000000000 -0400
@@ -109,7 +109,7 @@
STRIP_STRIP_ALL:=--strip-all
REMOVE_SECTION_COMMENT:=--remove-section=.comment
REMOVE_SECTION_NOTE:=--remove-section=.note
-TARGET_STRIP=$(TARGET_CROSS)strip $(REMOVE_SECTION_COMMENT)
$(REMOVE_SECTION_NOTE)
+TARGET_STRIP="$(TARGET_CROSS)strip $(REMOVE_SECTION_COMMENT)
$(REMOVE_SECTION_NOTE)"
STRIP=$(TARGET_STRIP)
endif
ifeq ($(BR2_STRIP_sstrip),y)
=====================================
otherwise --remove-section=.note is treated as a separate command due
to preceding whitespace.
Thank you.
--
Dimitry Golubovsky
Anywhere on the Web
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 3:48 [Buildroot] Quotes needed in package/Makefile.in Dimitry Golubovsky
@ 2007-09-29 10:05 ` Bernhard Fischer
2007-09-29 12:35 ` Ivan Kuten
0 siblings, 1 reply; 8+ messages in thread
From: Bernhard Fischer @ 2007-09-29 10:05 UTC (permalink / raw)
To: buildroot
On Fri, Sep 28, 2007 at 11:48:28PM -0400, Dimitry Golubovsky wrote:
>Please add quotes in package/Makefile.in, like this:
Yes, sorry. Fixed now.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 10:05 ` Bernhard Fischer
@ 2007-09-29 12:35 ` Ivan Kuten
2007-09-29 13:53 ` Bernhard Fischer
0 siblings, 1 reply; 8+ messages in thread
From: Ivan Kuten @ 2007-09-29 12:35 UTC (permalink / raw)
To: buildroot
Bernhard Fischer ?????:
> On Fri, Sep 28, 2007 at 11:48:28PM -0400, Dimitry Golubovsky wrote:
>
>> Please add quotes in package/Makefile.in, like this:
>
> Yes, sorry. Fixed now.
> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot
Seems it's not final fix cause I get such error on some packeges such as dropbear, strace:
make[1]: Leaving directory `/opt/buildroot/build_arm/strace-4.5.15'
install -c /opt/buildroot/build_arm/strace-4.5.15/strace /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace
"/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note" /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace > /dev/null 2>&1
make: *** [/opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace] Error 127
BR,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 12:35 ` Ivan Kuten
@ 2007-09-29 13:53 ` Bernhard Fischer
2007-09-29 15:01 ` Ivan Kuten
0 siblings, 1 reply; 8+ messages in thread
From: Bernhard Fischer @ 2007-09-29 13:53 UTC (permalink / raw)
To: buildroot
On Sat, Sep 29, 2007 at 03:35:07PM +0300, Ivan Kuten wrote:
>Bernhard Fischer ??????????:
>> On Fri, Sep 28, 2007 at 11:48:28PM -0400, Dimitry Golubovsky wrote:
>>
>>> Please add quotes in package/Makefile.in, like this:
>>
>> Yes, sorry. Fixed now.
>> _______________________________________________
>> buildroot mailing list
>> buildroot at uclibc.org
>> http://busybox.net/mailman/listinfo/buildroot
>
>Seems it's not final fix cause I get such error on some packeges such as dropbear, strace:
>
>make[1]: Leaving directory `/opt/buildroot/build_arm/strace-4.5.15'
>install -c /opt/buildroot/build_arm/strace-4.5.15/strace /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace
>"/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note" /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace > /dev/null 2>&1
>make: *** [/opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace] Error 127
Do you have
/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 15:01 ` Ivan Kuten
@ 2007-09-29 14:05 ` Bernhard Fischer
2007-09-29 15:15 ` Ivan Kuten
0 siblings, 1 reply; 8+ messages in thread
From: Bernhard Fischer @ 2007-09-29 14:05 UTC (permalink / raw)
To: buildroot
On Sat, Sep 29, 2007 at 06:01:12PM +0300, Ivan Kuten wrote:
>Bernhard Fischer ??????????:
>> Do you have
>> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip ?
>
>Yes,
>ls -l /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
>-rwxr-xr-x 2 root root 2643719 Sep 29 14:35 /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
>
>But that problem is that "/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note"
>trying to execute by shell as a single binary and not as arm-linux-uclibc-strip with parameters.
Please try the attached patchlet.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: br2.flags-quote.00.diff
Type: text/x-diff
Size: 4142 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070929/5cb7822d/attachment.bin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 15:15 ` Ivan Kuten
@ 2007-09-29 14:28 ` Bernhard Fischer
0 siblings, 0 replies; 8+ messages in thread
From: Bernhard Fischer @ 2007-09-29 14:28 UTC (permalink / raw)
To: buildroot
On Sat, Sep 29, 2007 at 06:15:56PM +0300, Ivan Kuten wrote:
>At least strace and dropbear get fixed by this patch. Thanks!
Thanks for the notice and for checking. Applied as r20113
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 13:53 ` Bernhard Fischer
@ 2007-09-29 15:01 ` Ivan Kuten
2007-09-29 14:05 ` Bernhard Fischer
0 siblings, 1 reply; 8+ messages in thread
From: Ivan Kuten @ 2007-09-29 15:01 UTC (permalink / raw)
To: buildroot
Bernhard Fischer ?????:
> On Sat, Sep 29, 2007 at 03:35:07PM +0300, Ivan Kuten wrote:
>> Bernhard Fischer ??????????:
>>> On Fri, Sep 28, 2007 at 11:48:28PM -0400, Dimitry Golubovsky wrote:
>>>
>>>> Please add quotes in package/Makefile.in, like this:
>>> Yes, sorry. Fixed now.
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at uclibc.org
>>> http://busybox.net/mailman/listinfo/buildroot
>> Seems it's not final fix cause I get such error on some packeges such as dropbear, strace:
>>
>> make[1]: Leaving directory `/opt/buildroot/build_arm/strace-4.5.15'
>> install -c /opt/buildroot/build_arm/strace-4.5.15/strace /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace
>> "/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note" /opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace > /dev/null 2>&1
>> make: *** [/opt/buildroot/project_build_arm/uclibc/root/usr/bin/strace] Error 127
>
> Do you have
> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip ?
Yes,
ls -l /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
-rwxr-xr-x 2 root root 2643719 Sep 29 14:35 /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
But that problem is that "/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note"
trying to execute by shell as a single binary and not as arm-linux-uclibc-strip with parameters.
BR,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] Quotes needed in package/Makefile.in
2007-09-29 14:05 ` Bernhard Fischer
@ 2007-09-29 15:15 ` Ivan Kuten
2007-09-29 14:28 ` Bernhard Fischer
0 siblings, 1 reply; 8+ messages in thread
From: Ivan Kuten @ 2007-09-29 15:15 UTC (permalink / raw)
To: buildroot
Bernhard Fischer ?????:
> On Sat, Sep 29, 2007 at 06:01:12PM +0300, Ivan Kuten wrote:
>> Bernhard Fischer ??????????:
>
>>> Do you have
>>> /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip ?
>> Yes,
>> ls -l /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
>> -rwxr-xr-x 2 root root 2643719 Sep 29 14:35 /opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip
>>
>> But that problem is that "/opt/buildroot/build_arm/staging_dir/usr/bin/arm-linux-uclibc-strip --remove-section=.comment --remove-section=.note"
>> trying to execute by shell as a single binary and not as arm-linux-uclibc-strip with parameters.
>
> Please try the attached patchlet.
At least strace and dropbear get fixed by this patch. Thanks!
BR,
Ivan
--------------------------------
Embedded Linux engineer,
Promwad Company: http://www.promwad.com/
Homepage : http://www.ivankuten.com/
--------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-09-29 15:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-29 3:48 [Buildroot] Quotes needed in package/Makefile.in Dimitry Golubovsky
2007-09-29 10:05 ` Bernhard Fischer
2007-09-29 12:35 ` Ivan Kuten
2007-09-29 13:53 ` Bernhard Fischer
2007-09-29 15:01 ` Ivan Kuten
2007-09-29 14:05 ` Bernhard Fischer
2007-09-29 15:15 ` Ivan Kuten
2007-09-29 14:28 ` Bernhard Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox