Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] svn commit: trunk/buildroot/package/database
@ 2008-06-01 21:17 antab at uclibc.org
  2008-06-01 21:20 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: antab at uclibc.org @ 2008-06-01 21:17 UTC (permalink / raw)
  To: buildroot

Author: antab
Date: 2008-06-01 14:17:28 -0700 (Sun, 01 Jun 2008)
New Revision: 22170

Log:
Change to menuconfig and make it right.


Modified:
   trunk/buildroot/package/database/Config.in


Changeset:
Modified: trunk/buildroot/package/database/Config.in
===================================================================
--- trunk/buildroot/package/database/Config.in	2008-06-01 21:01:14 UTC (rev 22169)
+++ trunk/buildroot/package/database/Config.in	2008-06-01 21:17:28 UTC (rev 22170)
@@ -1,5 +1,5 @@
-menuconfig "Database"
+menuconfig BR2_DATABASE_SUPPORT
+	bool "Database"
+	default n
 
 source "package/database/mysql_client/Config.in"
-
-endmenu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/database
  2008-06-01 21:17 [Buildroot] svn commit: trunk/buildroot/package/database antab at uclibc.org
@ 2008-06-01 21:20 ` Peter Korsgaard
  2008-06-01 21:35   ` Arnar Mar Sig
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2008-06-01 21:20 UTC (permalink / raw)
  To: buildroot

>>>>> "antab" == antab  <antab@uclibc.org> writes:

 antab> Author: antab
 antab> Date: 2008-06-01 14:17:28 -0700 (Sun, 01 Jun 2008)
 antab> New Revision: 22170

 antab> Log:
 antab> Change to menuconfig and make it right.

Unfortunately not :/

 antab> Modified:
 antab>    trunk/buildroot/package/database/Config.in


 antab> Changeset:
 antab> Modified: trunk/buildroot/package/database/Config.in
 antab> ===================================================================
 antab> --- trunk/buildroot/package/database/Config.in	2008-06-01 21:01:14 UTC (rev 22169)
 antab> +++ trunk/buildroot/package/database/Config.in	2008-06-01 21:17:28 UTC (rev 22170)
 antab> @@ -1,5 +1,5 @@
 antab> -menuconfig "Database"
 antab> +menuconfig BR2_DATABASE_SUPPORT
 antab> +	bool "Database"
 antab> +	default n
 
You're still missing the if BR2_DATABASE_SUPPORT / endif around the
source line(s).

Again, please have a look at package/editors/Config.in.

 antab>  source "package/database/mysql_client/Config.in"
 antab> -
 antab> -endmenu

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/database
@ 2008-06-01 21:35 antab at uclibc.org
  0 siblings, 0 replies; 4+ messages in thread
From: antab at uclibc.org @ 2008-06-01 21:35 UTC (permalink / raw)
  To: buildroot

Author: antab
Date: 2008-06-01 14:35:14 -0700 (Sun, 01 Jun 2008)
New Revision: 22171

Log:
Fix my own broken mistakes


Modified:
   trunk/buildroot/package/database/Config.in


Changeset:
Modified: trunk/buildroot/package/database/Config.in
===================================================================
--- trunk/buildroot/package/database/Config.in	2008-06-01 21:17:28 UTC (rev 22170)
+++ trunk/buildroot/package/database/Config.in	2008-06-01 21:35:14 UTC (rev 22171)
@@ -1,5 +1,7 @@
 menuconfig BR2_DATABASE_SUPPORT
 	bool "Database"
-	default n
+	default y
 
+if BR2_DATABASE_SUPPORT
 source "package/database/mysql_client/Config.in"
+endif

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/database
  2008-06-01 21:20 ` Peter Korsgaard
@ 2008-06-01 21:35   ` Arnar Mar Sig
  0 siblings, 0 replies; 4+ messages in thread
From: Arnar Mar Sig @ 2008-06-01 21:35 UTC (permalink / raw)
  To: buildroot



On Jun 1, 2008, at 9:20 PM, Peter Korsgaard wrote:

>>> Please don't add the version number to the help text.
> Arnar> Removed from the helptext, Keeping it in the menu text, There  
> are so
> Arnar> many changes between the 4.x - 5.x versions that one needs to  
> know the
> Arnar> major version number.
>
> The maybe simply call it MYSQL5 or 5.x ?
5.0 to 5.1 added a lot of new stuff, not sure if its ABI compatible,  
most systems i'm using have different packages for 5.0 and 5.1.

> antab> Author: antab
> antab> Date: 2008-06-01 14:17:28 -0700 (Sun, 01 Jun 2008)
> antab> New Revision: 22170
>
> antab> Log:
> antab> Change to menuconfig and make it right.
>
> Unfortunately not :/
>
> antab> Modified:
> antab>    trunk/buildroot/package/database/Config.in
>
>
> antab> Changeset:
> antab> Modified: trunk/buildroot/package/database/Config.in
> antab>  
> ===================================================================
> antab> --- trunk/buildroot/package/database/Config.in	2008-06-01  
> 21:01:14 UTC (rev 22169)
> antab> +++ trunk/buildroot/package/database/Config.in	2008-06-01  
> 21:17:28 UTC (rev 22170)
> antab> @@ -1,5 +1,5 @@
> antab> -menuconfig "Database"
> antab> +menuconfig BR2_DATABASE_SUPPORT
> antab> +	bool "Database"
> antab> +	default n
>
> You're still missing the if BR2_DATABASE_SUPPORT / endif around the
> source line(s).
Crap, the first time i was in a hurry and touch i had fixed it and  
tested, but damn, this day is not going well.

> Again, please have a look at package/editors/Config.in.
Sorry about that. Funny thing, i also created that file along time ago:P

>
> antab>  source "package/database/mysql_client/Config.in"
> antab> -
> antab> -endmenu
>
> -- 
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot


Greets
	Arnar Mar Sig
	Valka ehf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-06-01 21:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-01 21:17 [Buildroot] svn commit: trunk/buildroot/package/database antab at uclibc.org
2008-06-01 21:20 ` Peter Korsgaard
2008-06-01 21:35   ` Arnar Mar Sig
  -- strict thread matches above, loose matches on Subject: below --
2008-06-01 21:35 antab at uclibc.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox