[Buildroot] [PATCH 1/1] busybox: fix missing dependencies in unpacked and config rules

[Buildroot] [PATCH 1/1] busybox: fix missing dependencies in unpacked and config rules

[Hans-Christian Egtvedt]

This patch adds depedency to host-sed and $(PROJECT_BUILD_DIR) when running
make busybox-config and busybox-unpacked.

Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
---
 package/busybox/busybox.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index c616e45..969502b 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -127,9 +127,9 @@ busybox: uclibc $(TARGET_DIR)/bin/busybox
 
 busybox-source: $(DL_DIR)/$(BUSYBOX_SOURCE)
 
-busybox-unpacked: $(BUSYBOX_DIR)/.unpacked
+busybox-unpacked: host-sed $(PROJECT_BUILD_DIR) $(BUSYBOX_DIR)/.unpacked
 
-busybox-config: $(BUSYBOX_DIR)/.configured
+busybox-config: host-sed $(PROJECT_BUILD_DIR) $(BUSYBOX_DIR)/.configured
 
 busybox-menuconfig: host-sed $(PROJECT_BUILD_DIR) busybox-source $(BUSYBOX_DIR)/.configured
 	$(MAKE) __TARGET_ARCH=$(ARCH) -C $(BUSYBOX_DIR) menuconfig
-- 
1.5.4.3

[Buildroot] [PATCH 1/1] busybox: fix missing dependencies in unpacked and config rules

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

 Hans-Christian> This patch adds depedency to host-sed and
 Hans-Christian> $(PROJECT_BUILD_DIR) when running make busybox-config
 Hans-Christian> and busybox-unpacked.

Thanks, committed as r23065.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] busybox: fix missing dependencies in unpacked and config rules

[Bernhard Fischer]

On Wed, Aug 06, 2008 at 02:57:08PM +0200, Peter Korsgaard wrote:
>>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:
>
> Hans-Christian> This patch adds depedency to host-sed and
> Hans-Christian> $(PROJECT_BUILD_DIR) when running make busybox-config
> Hans-Christian> and busybox-unpacked.
>
>Thanks, committed as r23065.

Does that really work?

Please
$ chmod -x $(which sed)
on your build host, so that host-sed has to be actually be built (ISTR
that we rightfully use the busybox sed in this case)
then wipe your obj trees and
$ cp -a my_toplevel_config.BAK .config
$ make busybox-menuconfig

I think that if you had a pristine tree and copyied a backed-up
br2.config to the toplevel, that you could (previously) run all
menuconfig targets (with a disfunctional sed on your host).

[Buildroot] [PATCH 1/1] busybox: fix missing dependencies inunpacked and config rules

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

CC'ed list - Please keep buildroot stuff on the buildroot list.

 Ulf> You are aware that you broke the script downloading the linux image to
 Ulf> the target
 Ulf> by removing $(DATE) from the image name in Config.in?

I take it that you are referring to r23254? If so, why don't you just
set ROOTFS_SUFFIX to what you need?

 Ulf> A fix may be needed, but this should keep $(DATE) in the image name
 Ulf> if the Atmel specific U-boot is used.

-- 
Bye, Peter Korsgaard