From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] u-boot: fix wrong syntax in Makefile
Date: Sat, 9 Aug 2008 14:03:44 +0200 [thread overview]
Message-ID: <200808091403.44855.markus.heidelberg@web.de> (raw)
u-boot: fix wrong syntax in Makefile
Some $(call insert_define, ..., ...) calls were lacking the comma after the
variable. That didn't lead to a syntax error but it didn't have any effect on
the output u-boot/include/config.h
---
target/u-boot/Makefile.in | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/u-boot/Makefile.in b/target/u-boot/Makefile.in
index d7af24c..9148e05 100644
--- a/target/u-boot/Makefile.in
+++ b/target/u-boot/Makefile.in
@@ -98,16 +98,16 @@ ifneq ($(strip $(BR2_TARGET_UBOOT_ETHADDR)),"")
$(call insert_define, "CONFIG_ETHADDR", $(BR2_TARGET_UBOOT_ETHADDR))
endif
ifneq ($(strip $(BR2_TARGET_UBOOT_ETH1ADDR)),"")
- $(call insert_define "CONFIG_ETH2ADDR", $(BR2_TARGET_UBOOT_ETH1ADDR))
+ $(call insert_define, "CONFIG_ETH2ADDR", $(BR2_TARGET_UBOOT_ETH1ADDR))
endif
ifneq ($(strip $(BR2_TARGET_UBOOT_BOOTARGS)),"")
- $(call insert_define "CONFIG_BOOTARGS", $(BR2_TARGET_UBOOT_BOOTARGS))
+ $(call insert_define, "CONFIG_BOOTARGS", $(BR2_TARGET_UBOOT_BOOTARGS))
endif
ifneq ($(strip $(BR2_TARGET_UBOOT_BOOTCMD)),"")
- $(call insert_define "CONFIG_BOOTCOMMAND", $(BR2_TARGET_UBOOT_BOOTCMD))
+ $(call insert_define, "CONFIG_BOOTCOMMAND", $(BR2_TARGET_UBOOT_BOOTCMD))
endif
ifneq ($(strip $(BR2_TARGET_UBOOT_SILENT)),"")
- $(call insert_define "CONFIG_SILENT_CONSOLE", "")
+ $(call insert_define, "CONFIG_SILENT_CONSOLE", "")
endif
@echo "#endif /* __BR2_ADDED_CONFIG_H */" >> $(U_BOOT_INC_CONF_FILE)
touch $@
next reply other threads:[~2008-08-09 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 12:03 Markus Heidelberg [this message]
2008-08-11 20:09 ` [Buildroot] [PATCH] u-boot: fix wrong syntax in Makefile Markus Heidelberg
2008-08-20 20:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808091403.44855.markus.heidelberg@web.de \
--to=markus.heidelberg@web.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox