[Buildroot] Patch files with Makefile.autotools.in

[Buildroot] Patch files with Makefile.autotools.in

[hartleys]

Hello all,

Does anything have to be added to a FOO.mk file to get patches in the
FOO directory applied?

Thanks,
Hartley

[Buildroot] Patch files with Makefile.autotools.in

[Hans-Christian Egtvedt]

On Mon, 18 Aug 2008 12:42:41 -0400
"hartleys" <hartleys@visionengravers.com> wrote:

> Hello all,
> 
> Does anything have to be added to a FOO.mk file to get patches in the
> FOO directory applied?
> 

No, but the patch name should preferably be on the form:
<package name>-<version>-<something descriptive>.patch {.gz,.bz2}

See the stamp_patched rule in package/Makefile.autotools.in

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] Patch files with Makefile.autotools.in

[hartleys]

Monday, August 18, 2008 10:56 PM, Hans-Christian Egtvedt wrote:
>> Does anything have to be added to a FOO.mk file to get patches in the

>> FOO directory applied?
>> 
>
> No, but the patch name should preferably be on the form:
> <package name>-<version>-<something descriptive>.patch {.gz,.bz2}
>
> See the stamp_patched rule in package/Makefile.autotools.in

Well, that's how I have it setup but the patch does not get applied.

I see the "Patching $($(PKG)_DIR_PREFIX)/$($PKG)_NAME)" message but when
I examine the source the patch is not present.

I think the problem is related to the FIXME note above the rule. I'm
trying to apply a patch to a package that is not supplied in buildroot.
To keep it separate I have the package in package/customize/<package
name>.

Any ideas on how to fix the FIXME?

Thanks for the reply,
Hartley

[Buildroot] Patch files with Makefile.autotools.in

[Hans-Christian Egtvedt]

On Tue, 19 Aug 2008 19:45:21 -0400
"hartleys" <hartleys@visionengravers.com> wrote:

> Monday, August 18, 2008 10:56 PM, Hans-Christian Egtvedt wrote:

<snipp problems with patching a custom package>

> I see the "Patching $($(PKG)_DIR_PREFIX)/$($PKG)_NAME)" message but
> when I examine the source the patch is not present.
> 
> I think the problem is related to the FIXME note above the rule. I'm
> trying to apply a patch to a package that is not supplied in
> buildroot. To keep it separate I have the package in
> package/customize/<package
> name>.
> 

Yes, you are indeed a victim of the FIXME, since you do not use the
"standard" package/<package name> directory structure.

> Any ideas on how to fix the FIXME?
> 

A quick fix would be to just symlink package/customize/<package name>
to package/<package name>.

I'll do a mental note of the problem, it is likely to show up in the
future as well.

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] Patch files with Makefile.autotools.in

[Bernhard Reutner-Fischer]

On Wed, Aug 20, 2008 at 09:05:29AM +0200, Hans-Christian Egtvedt wrote:
>On Tue, 19 Aug 2008 19:45:21 -0400
>"hartleys" <hartleys@visionengravers.com> wrote:
>
>> Monday, August 18, 2008 10:56 PM, Hans-Christian Egtvedt wrote:
>
><snipp problems with patching a custom package>
>
>> I see the "Patching $($(PKG)_DIR_PREFIX)/$($PKG)_NAME)" message but
>> when I examine the source the patch is not present.
>> 
>> I think the problem is related to the FIXME note above the rule. I'm
>> trying to apply a patch to a package that is not supplied in
>> buildroot. To keep it separate I have the package in
>> package/customize/<package
>> name>.
>> 
>
>Yes, you are indeed a victim of the FIXME, since you do not use the
>"standard" package/<package name> directory structure.
>
>> Any ideas on how to fix the FIXME?
>> 
>
>A quick fix would be to just symlink package/customize/<package name>
>to package/<package name>.
>
>I'll do a mental note of the problem, it is likely to show up in the
>future as well.

heh, that was exactly the reason why i added that nice FIXME in the
first place ;)

What secret package is this about anyway? If it's of general use, it
should be added to the tree..

[Buildroot] Patch files with Makefile.autotools.in

[Hans-Christian Egtvedt]

On Wed, 20 Aug 2008 10:03:27 +0200
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:

> On Wed, Aug 20, 2008 at 09:05:29AM +0200, Hans-Christian Egtvedt
> wrote:

<snippy custom package patching when using Makefile.autotools.in>

> >I'll do a mental note of the problem, it is likely to show up in the
> >future as well.
> 
> heh, that was exactly the reason why i added that nice FIXME in the
> first place ;)
> 

It was more inside my brain, actually looking into it at some time(tm).

> What secret package is this about anyway? If it's of general use, it
> should be added to the tree..
>

Agreed (-:

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] Patch files with Makefile.autotools.in

[hartleys]

Wednesday, August 20, 2008 1:22 AM, Bernhard Reutner-Fischer wrote:
>> On Wed, Aug 20, 2008 at 09:05:29AM +0200, Hans-Christian Egtvedt
>> wrote:
>
> <snippy custom package patching when using Makefile.autotools.in>
>
>>> I'll do a mental note of the problem, it is likely to show up in the

>>> future as well.
>> 
>> heh, that was exactly the reason why i added that nice FIXME in the 
>> first place ;)
>> 
>
> It was more inside my brain, actually looking into it at some
time(tm).
>
>> What secret package is this about anyway? If it's of general use, it 
>> should be added to the tree..
>>
>
> Agreed (-:

Nothing secret. It's the ESE Key Daemon
http://www.burghardt.pl/2007/12/ese-key-daemon/. I posted a question
about it last week and had no response so figured nobody was interested.
I actually see that a lot on the list when "non-buildroot" packages are
named in the subject. Oh well...

I've been communicating with the developer, Krzysztof Burghardt, trying
to fix a problem with the make when cross compiling. He has sent me a
patch to try and I couldn't get it applied through the normal
Makefile.autotools.in route. Hence this email...

I've basically hijacked the packages/customize directory for stuff I'm
playing with outside of the normal buildroot packages. That way if I
have a problem it's a quick mental note to not bother the list about it.
But, if this package is of any use to the group I'm more than willing to
submit it. I just need to test Krzysztof's patch first.

Thanks for the replies,
Hartley Sweeten