* [Buildroot] svn commit: trunk/buildroot/package/popt
@ 2008-08-26 21:05 jacmet at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2008-08-26 21:05 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2008-08-26 14:05:01 -0700 (Tue, 26 Aug 2008)
New Revision: 23223
Log:
popt: cleanup redundant configure args
Modified:
trunk/buildroot/package/popt/popt.mk
Changeset:
Modified: trunk/buildroot/package/popt/popt.mk
===================================================================
--- trunk/buildroot/package/popt/popt.mk 2008-08-26 20:47:23 UTC (rev 23222)
+++ trunk/buildroot/package/popt/popt.mk 2008-08-26 21:05:01 UTC (rev 23223)
@@ -7,13 +7,8 @@
POPT_SITE = http://rpm5.org/files/popt
POPT_INSTALL_STAGING = YES
-
POPT_CONF_ENV = ac_cv_va_copy=yes
-
-POPT_CONF_OPT = --target=$(GNU_TARGET_NAME) --host=$(REAL_GNU_TARGET_NAME) \
- --build=$(GNU_HOST_NAME) --prefix=/usr
-
POPT_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
@ 2008-08-26 21:05 jacmet at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2008-08-26 21:05 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2008-08-26 14:05:05 -0700 (Tue, 26 Aug 2008)
New Revision: 23224
Log:
popt: use install-strip for target install
Modified:
trunk/buildroot/package/popt/popt.mk
Changeset:
Modified: trunk/buildroot/package/popt/popt.mk
===================================================================
--- trunk/buildroot/package/popt/popt.mk 2008-08-26 21:05:01 UTC (rev 23223)
+++ trunk/buildroot/package/popt/popt.mk 2008-08-26 21:05:05 UTC (rev 23224)
@@ -6,10 +6,10 @@
POPT_VERSION = 1.14
POPT_SITE = http://rpm5.org/files/popt
POPT_INSTALL_STAGING = YES
-
+POPT_INSTALL_TARGET:=YES
POPT_CONF_ENV = ac_cv_va_copy=yes
-POPT_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install
+POPT_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install-strip
$(eval $(call AUTOTARGETS,package,popt))
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
@ 2008-08-26 21:05 jacmet at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2008-08-26 21:05 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2008-08-26 14:05:10 -0700 (Tue, 26 Aug 2008)
New Revision: 23225
Log:
popt: use := assignments
Modified:
trunk/buildroot/package/popt/popt.mk
Changeset:
Modified: trunk/buildroot/package/popt/popt.mk
===================================================================
--- trunk/buildroot/package/popt/popt.mk 2008-08-26 21:05:05 UTC (rev 23224)
+++ trunk/buildroot/package/popt/popt.mk 2008-08-26 21:05:10 UTC (rev 23225)
@@ -3,13 +3,13 @@
# popt
#
#############################################################
-POPT_VERSION = 1.14
-POPT_SITE = http://rpm5.org/files/popt
-POPT_INSTALL_STAGING = YES
+POPT_VERSION:=1.14
+POPT_SITE:=http://rpm5.org/files/popt
+POPT_INSTALL_STAGING:=YES
POPT_INSTALL_TARGET:=YES
-POPT_CONF_ENV = ac_cv_va_copy=yes
+POPT_CONF_ENV:=ac_cv_va_copy=yes
+POPT_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) install-strip
-POPT_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install-strip
+POPT_DEPENDENCIES:=uclibc
-
$(eval $(call AUTOTARGETS,package,popt))
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
@ 2009-01-25 20:50 ulf at uclibc.org
2009-01-25 21:02 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: ulf at uclibc.org @ 2009-01-25 20:50 UTC (permalink / raw)
To: buildroot
Author: ulf
Date: 2009-01-25 20:50:59 +0000 (Sun, 25 Jan 2009)
New Revision: 25019
Log:
Support libiconv option for popt
Modified:
trunk/buildroot/package/popt/popt.mk
Changeset:
Modified: trunk/buildroot/package/popt/popt.mk
===================================================================
--- trunk/buildroot/package/popt/popt.mk 2009-01-25 20:44:23 UTC (rev 25018)
+++ trunk/buildroot/package/popt/popt.mk 2009-01-25 20:50:59 UTC (rev 25019)
@@ -5,10 +5,16 @@
#############################################################
POPT_VERSION:=1.14
POPT_SITE:=http://rpm5.org/files/popt
-POPT_INSTALL_STAGING:=YES
-POPT_INSTALL_TARGET:=YES
-POPT_CONF_ENV:=ac_cv_va_copy=yes
+POPT_INSTALL_STAGING = YES
+POPT_INSTALL_TARGET = YES
+POPT_CONF_ENV = ac_cv_va_copy=yes
+
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+POPT_CONF_ENV += am_cv_lib_iconv=yes
+POPT_CONF_OPT += --with-libiconv-prefix=$(STAGING_DIR)/usr
+endif
+
POPT_DEPENDENCIES:=uclibc
$(eval $(call AUTOTARGETS,package,popt))
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
2009-01-25 20:50 ulf at uclibc.org
@ 2009-01-25 21:02 ` Peter Korsgaard
2009-01-25 23:28 ` Ulf Samuelsson
0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2009-01-25 21:02 UTC (permalink / raw)
To: buildroot
>>>>> "ulf" == ulf <ulf@uclibc.org> writes:
ulf> Author: ulf
ulf> Date: 2009-01-25 20:50:59 +0000 (Sun, 25 Jan 2009)
ulf> New Revision: 25019
ulf> Log:
ulf> Support libiconv option for popt
ulf> Modified:
ulf> trunk/buildroot/package/popt/popt.mk
ulf> Changeset:
ulf> Modified: trunk/buildroot/package/popt/popt.mk
ulf> ===================================================================
ulf> --- trunk/buildroot/package/popt/popt.mk 2009-01-25 20:44:23 UTC (rev 25018)
ulf> +++ trunk/buildroot/package/popt/popt.mk 2009-01-25 20:50:59 UTC (rev 25019)
ulf> @@ -5,10 +5,16 @@
ulf> #############################################################
ulf> POPT_VERSION:=1.14
ulf> POPT_SITE:=http://rpm5.org/files/popt
ulf> -POPT_INSTALL_STAGING:=YES
ulf> -POPT_INSTALL_TARGET:=YES
ulf> -POPT_CONF_ENV:=ac_cv_va_copy=yes
ulf> +POPT_INSTALL_STAGING = YES
ulf> +POPT_INSTALL_TARGET = YES
What's wrong with := ?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
2009-01-25 21:02 ` Peter Korsgaard
@ 2009-01-25 23:28 ` Ulf Samuelsson
2009-01-26 6:01 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Ulf Samuelsson @ 2009-01-25 23:28 UTC (permalink / raw)
To: buildroot
s?n 2009-01-25 klockan 22:02 +0100 skrev Peter Korsgaard:
> >>>>> "ulf" == ulf <ulf@uclibc.org> writes:
>
> ulf> Author: ulf
> ulf> Date: 2009-01-25 20:50:59 +0000 (Sun, 25 Jan 2009)
> ulf> New Revision: 25019
>
> ulf> Log:
> ulf> Support libiconv option for popt
>
> ulf> Modified:
> ulf> trunk/buildroot/package/popt/popt.mk
>
>
> ulf> Changeset:
> ulf> Modified: trunk/buildroot/package/popt/popt.mk
> ulf> ===================================================================
> ulf> --- trunk/buildroot/package/popt/popt.mk 2009-01-25 20:44:23 UTC (rev 25018)
> ulf> +++ trunk/buildroot/package/popt/popt.mk 2009-01-25 20:50:59 UTC (rev 25019)
> ulf> @@ -5,10 +5,16 @@
> ulf> #############################################################
> ulf> POPT_VERSION:=1.14
> ulf> POPT_SITE:=http://rpm5.org/files/popt
> ulf> -POPT_INSTALL_STAGING:=YES
> ulf> -POPT_INSTALL_TARGET:=YES
> ulf> -POPT_CONF_ENV:=ac_cv_va_copy=yes
> ulf> +POPT_INSTALL_STAGING = YES
> ulf> +POPT_INSTALL_TARGET = YES
>
> What's wrong with := ?
90%+ of the Autotools packages use "=" and the rest use ":="
when I did a quick grep
Feel free to argue pro/con.
BR
Ulf Samuelsson
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/popt
2009-01-25 23:28 ` Ulf Samuelsson
@ 2009-01-26 6:01 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2009-01-26 6:01 UTC (permalink / raw)
To: buildroot
>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:
>> What's wrong with := ?
Ulf> 90%+ of the Autotools packages use "=" and the rest use ":="
Ulf> when I did a quick grep
Ulf> Feel free to argue pro/con.
They are basic variables. We normally use := where possible for
performance reasons and to not have surprises later, but I know the
Makefile.autotoos.in "style" is = instead.
Just leave it for now, but please stick "cleanups" in seperate commits
from funcional changes.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-01-26 6:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-26 21:05 [Buildroot] svn commit: trunk/buildroot/package/popt jacmet at uclibc.org
-- strict thread matches above, loose matches on Subject: below --
2008-08-26 21:05 jacmet at uclibc.org
2008-08-26 21:05 jacmet at uclibc.org
2009-01-25 20:50 ulf at uclibc.org
2009-01-25 21:02 ` Peter Korsgaard
2009-01-25 23:28 ` Ulf Samuelsson
2009-01-26 6:01 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox