From: Grant Likely <grant.likely@secretlab.ca>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 8/9] RFC: Remove HOSTCFLAGS from kernel compile
Date: Thu, 16 Oct 2008 14:32:56 -0600 [thread overview]
Message-ID: <20081016203256.15826.17375.stgit@localhost.localdomain> (raw)
In-Reply-To: <20081016203220.15826.26173.stgit@localhost.localdomain>
From: Grant Likely <grant.likely@secretlab.ca>
Setting HOSTCFLAGS when calling make for the kernel compile messes up
the tools that the kernel builds for itself. Specifically, the
building of the device tree compiler (dtc) in arch/powerpc adds some
required flags to HOSTCFLAGS. However, if HOSTCFLAGS= is specified
when calling make, then the local flags are never added and the kernel
compile fails.
This patch removes the HOSTCFLAGS= from $(LINUX26_MAKE_FLAGS). I've
marked this patch as an RFC because I don't know what is really required
here. Removing it works for me (of course), but it may break other users.
I just don't know if there is a better way to set HOSTCFLAGS so that it
doesn't override the settings that the kernel uses itself.
---
target/linux/Makefile.in.advanced | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target/linux/Makefile.in.advanced b/target/linux/Makefile.in.advanced
index 42384f1..9c6df1f 100644
--- a/target/linux/Makefile.in.advanced
+++ b/target/linux/Makefile.in.advanced
@@ -186,7 +186,7 @@ LINUX_KERNEL:=$(LINUX26_KERNEL)
LINUX26_BZCAT:=$(BZCAT)
__LINUX26_NO_PIC=-fPIC -fpic -DPIC -fwrapv -ftrapv
-LINUX26_MAKE_FLAGS = HOSTCC="$(HOSTCC)" HOSTCFLAGS="$(HOSTCFLAGS)" \
+LINUX26_MAKE_FLAGS = HOSTCC="$(HOSTCC)" \
ARCH=$(KERNEL_ARCH) \
CFLAGS_KERNEL="$(filter-out $(__LINUX26_NO_PIC),$(TARGET_CFLAGS))" \
INSTALL_MOD_PATH=$(TARGET_DIR) \
next prev parent reply other threads:[~2008-10-16 20:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 20:32 [Buildroot] [PATCH 1/9] Typo fix in toolchain/external-toolchain/ext-tool.mk Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 2/9] Fix link flags of mtdutils Grant Likely
2008-10-16 20:51 ` Thomas Petazzoni
2008-10-16 21:15 ` hartleys
2008-10-16 21:22 ` Bernhard Reutner-Fischer
2008-10-16 21:38 ` Thomas Petazzoni
2008-10-16 21:47 ` Thomas Petazzoni
2008-10-16 20:32 ` [Buildroot] [PATCH 3/9] Add support for multilib external toolchains Grant Likely
2008-10-17 16:40 ` Shinya Kuribayashi
2010-01-12 11:06 ` Thomas Petazzoni
2010-01-12 19:15 ` Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 4/9] Add Xilinx UARTLITE and MPC5200 PSC device files (serial ports) Grant Likely
2008-10-17 10:24 ` Peter Korsgaard
2008-10-16 20:32 ` [Buildroot] [PATCH 5/9] Refactor invocation of make for kernel compiles Grant Likely
2008-10-16 21:55 ` Markus Heidelberg
2008-10-16 23:03 ` Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will install modules Grant Likely
2008-10-30 9:52 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will installmodules Hans-Christian Egtvedt
2008-10-30 11:57 ` Hans-Christian Egtvedt
2008-10-30 13:20 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will install modules Thomas Petazzoni
2008-10-30 13:23 ` Grant Likely
2008-10-30 13:44 ` Thomas Petazzoni
2008-10-30 13:27 ` Hans-Christian Egtvedt
2008-10-30 14:04 ` Hans-Christian Egtvedt
2008-10-16 20:32 ` [Buildroot] [PATCH 7/9] Add last resort setting of $(LINUX26_BINLOC) for kernel image filename Grant Likely
2008-10-16 20:32 ` Grant Likely [this message]
2008-10-16 21:09 ` [Buildroot] [PATCH 8/9] RFC: Remove HOSTCFLAGS from kernel compile Bernhard Reutner-Fischer
2008-10-16 23:11 ` Grant Likely
2008-10-16 20:33 ` [Buildroot] [PATCH 9/9] Add support for cloning Linux git trees Grant Likely
2008-10-16 21:14 ` Bernhard Reutner-Fischer
2008-10-16 23:09 ` Grant Likely
2008-10-17 7:38 ` Bernhard Reutner-Fischer
2008-10-17 10:20 ` [Buildroot] [PATCH 1/9] Typo fix in toolchain/external-toolchain/ext-tool.mk Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016203256.15826.17375.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox