From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/9] Refactor invocation of make for kernel compiles
Date: Thu, 16 Oct 2008 23:55:34 +0200 [thread overview]
Message-ID: <200810162355.34911.markus.heidelberg@web.de> (raw)
In-Reply-To: <20081016203240.15826.97856.stgit@localhost.localdomain>
Grant Likely, 16.10.2008:
>
> - $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) modules
> - $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) \
> + $(LINUX26_MAKE) modules
> + $(LINUX26_MAKE) \
> DEPMOD=$(STAGING_DIR)/bin/$(GNU_TARGET_NAME)-depmod26 \
> INSTALL_MOD_PATH=$(TARGET_DIR) modules_install
DEPMOD could be defined in LINUX26_MAKE_FLAGS, INSTALL_MOD_PATH is already
there. Then it would be a small line here.
> @@ -240,6 +242,9 @@ linux26-force:
> # This has been renamed so we do _NOT_ by default run this on 'make clean'
> linux26clean:
> rm -f $(LINUX26_KERNEL) $(LINUX26_DIR)/.configured
> + # Note; this invocation of make is different from the rest. Why
> + # does 'PATH' need to be assigned here? Can this be replaced with
> + # $(LINUX26_MAKE) like all the others?
> -$(MAKE) PATH=$(TARGET_PATH) -C $(LINUX26_DIR) clean
I think so, maybe a leftover, but I don't know. Git-grepping for TARGET_PATH
through the repository shows some uses of this in 4 devices but not restricted
to the clean target.
> - $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) modules
> - $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) \
> + $(LINUX26_MAKE) modules
> + $(LINUX26_MAKE) \
> DEPMOD=$(STAGING_DIR)/bin/$(GNU_TARGET_NAME)-depmod26 \
> INSTALL_MOD_PATH=$(TARGET_DIR) modules_install
Same as above.
> @@ -461,6 +463,9 @@ linux26-force:
> # This has been renamed so we do _NOT_ by default run this on 'make clean'
> linux26clean:
> rm -f $(LINUX26_KERNEL) $(LINUX26_DIR)/.configured
> + # Note; this invocation of make is different from the rest. Why
> + # does 'PATH' need to be assigned here? Can this be replaced with
> + # $(LINUX26_MAKE) like all the others?
> -$(MAKE) PATH=$(TARGET_PATH) -C $(LINUX26_DIR) clean
Same as above.
Markus
next prev parent reply other threads:[~2008-10-16 21:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 20:32 [Buildroot] [PATCH 1/9] Typo fix in toolchain/external-toolchain/ext-tool.mk Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 2/9] Fix link flags of mtdutils Grant Likely
2008-10-16 20:51 ` Thomas Petazzoni
2008-10-16 21:15 ` hartleys
2008-10-16 21:22 ` Bernhard Reutner-Fischer
2008-10-16 21:38 ` Thomas Petazzoni
2008-10-16 21:47 ` Thomas Petazzoni
2008-10-16 20:32 ` [Buildroot] [PATCH 3/9] Add support for multilib external toolchains Grant Likely
2008-10-17 16:40 ` Shinya Kuribayashi
2010-01-12 11:06 ` Thomas Petazzoni
2010-01-12 19:15 ` Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 4/9] Add Xilinx UARTLITE and MPC5200 PSC device files (serial ports) Grant Likely
2008-10-17 10:24 ` Peter Korsgaard
2008-10-16 20:32 ` [Buildroot] [PATCH 5/9] Refactor invocation of make for kernel compiles Grant Likely
2008-10-16 21:55 ` Markus Heidelberg [this message]
2008-10-16 23:03 ` Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will install modules Grant Likely
2008-10-30 9:52 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will installmodules Hans-Christian Egtvedt
2008-10-30 11:57 ` Hans-Christian Egtvedt
2008-10-30 13:20 ` [Buildroot] [PATCH 6/9] Ask the kernel source where it will install modules Thomas Petazzoni
2008-10-30 13:23 ` Grant Likely
2008-10-30 13:44 ` Thomas Petazzoni
2008-10-30 13:27 ` Hans-Christian Egtvedt
2008-10-30 14:04 ` Hans-Christian Egtvedt
2008-10-16 20:32 ` [Buildroot] [PATCH 7/9] Add last resort setting of $(LINUX26_BINLOC) for kernel image filename Grant Likely
2008-10-16 20:32 ` [Buildroot] [PATCH 8/9] RFC: Remove HOSTCFLAGS from kernel compile Grant Likely
2008-10-16 21:09 ` Bernhard Reutner-Fischer
2008-10-16 23:11 ` Grant Likely
2008-10-16 20:33 ` [Buildroot] [PATCH 9/9] Add support for cloning Linux git trees Grant Likely
2008-10-16 21:14 ` Bernhard Reutner-Fischer
2008-10-16 23:09 ` Grant Likely
2008-10-17 7:38 ` Bernhard Reutner-Fischer
2008-10-17 10:20 ` [Buildroot] [PATCH 1/9] Typo fix in toolchain/external-toolchain/ext-tool.mk Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810162355.34911.markus.heidelberg@web.de \
--to=markus.heidelberg@web.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox