[Buildroot] [PATCH] FIx libpng, directfb, dbus, fontconfig, etc. builds

[Buildroot] [PATCH] FIx libpng, directfb, dbus, fontconfig, etc. builds

[Thomas Petazzoni]

Hi,

The following patch fixes two types of build failures that I
encountered with different packages :

 * Some configure scripts were not able to compile the test programs
   used to test whether zlib was properly installed. The configure
   scripts are properly using -lz, but the
   -L/path/to/staging_dir/usr/lib option was not present, leading to
   build failure.

   The solution I've found is to set a -L option in LDFLAGS.

   See
   http://buildroot.uclibc.org/lists/buildroot/2008-October/010909.html
   for details.

 * While linking applications, for example the applications included in
   the fontconfig package, I had build failures like :

/usr/local/uclibc-0.9.28-2/arm/lib/gcc/arm-linux-uclibc/3.4.5/../../../../arm-linux-uclibc/bin/ld.real:
warning: libfreetype.so.6, needed by ../src/.libs/libfontconfig.so, not
found (try using -rpath or -rpath-link)

    this is due to the fact that ld is not able to find the other
    already installed shared libraries.

    The solution I've found is to add a -Wl,--rpath-link
    -Wl,/path/to/staging_dir/usr/lib option in LDFLAGS.

    See the thread at
    http://buildroot.uclibc.org/lists/buildroot/2008-October/010917.html
    for details.

For both of the problems, I'm not sure about the solutions, but I'm
sure that the problems exist.

Thanks,

Thomas

---

Make sure libraries are visible when building packages

This patch adds an LDFLAGS variable before calling the configure
script of any package, in order to fix two problems :

 * Some configure scripts were not able to compile the test programs
   used to test whether zlib was properly installed. The configure
   scripts are properly using -lz, but the
   -L/path/to/staging_dir/usr/lib option was not present, leading to
   build failure.

 * While linking applications, for example the applications included in
   the fontconfig package, I had build failures like :

/usr/local/uclibc-0.9.28-2/arm/lib/gcc/arm-linux-uclibc/3.4.5/../../../../arm-linux-uclibc/bin/ld.real:
warning: libfreetype.so.6, needed by ../src/.libs/libfontconfig.so, not
found (try using -rpath or -rpath-link)

    this is due to the fact that ld is not able to find the other
    already installed shared libraries.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/Makefile.in |    1 +
 1 file changed, 1 insertion(+)

Index: buildroot/package/Makefile.in
===================================================================
--- buildroot.orig/package/Makefile.in
+++ buildroot/package/Makefile.in
@@ -224,6 +224,7 @@
 		NM_FOR_TARGET="$(TARGET_NM)" \
 		DEFAULT_ASSEMBLER="$(TARGET_AS)" \
 		DEFAULT_LINKER="$(TARGET_LD)" \
+		LDFLAGS="$(TARGET_LDFLAGS) -Wl,--rpath-link -Wl,$(STAGING_DIR)/usr/lib" \
 		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 		PKG_CONFIG="$(STAGING_DIR)/usr/bin/pkg-config" \
 		PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig:$(PKG_CONFIG_PATH)" \


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] Feedback ?

[Thomas Petazzoni]

Le Wed, 15 Oct 2008 16:47:37 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> Make sure libraries are visible when building packages
> 
> This patch adds an LDFLAGS variable before calling the configure
> script of any package, in order to fix two problems :
> 
>  * Some configure scripts were not able to compile the test programs
>    used to test whether zlib was properly installed. The configure
>    scripts are properly using -lz, but the
>    -L/path/to/staging_dir/usr/lib option was not present, leading to
>    build failure.
> 
>  * While linking applications, for example the applications included
> in the fontconfig package, I had build failures like :
> 
> /usr/local/uclibc-0.9.28-2/arm/lib/gcc/arm-linux-uclibc/3.4.5/../../../../arm-linux-uclibc/bin/ld.real:
> warning: libfreetype.so.6, needed by ../src/.libs/libfontconfig.so,
> not found (try using -rpath or -rpath-link)
> 
>     this is due to the fact that ld is not able to find the other
>     already installed shared libraries.

May I have some feedback on this patch ? Without this, Buildroot is
just unusable here.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] Feedback ?

[Daniel Laird]

I would like this patch as I have a number of packages that have this change added also (but on a package by package patch).

I am slightly afraid to just throw it into buildroot.  
If anyone has any feedback on this, that would be appreciated before I submit the change into buildroot as I think this is a good change.

Many thanks 
Daniel Laird

-----Original Message-----
From: buildroot-bounces@uclibc.org [mailto:buildroot-bounces at uclibc.org] On Behalf Of Thomas Petazzoni
Sent: 2008 Oct 20 14:48
To: buildroot at uclibc.org
Subject: [Buildroot] Feedback ?

Le Wed, 15 Oct 2008 16:47:37 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> Make sure libraries are visible when building packages
> 
> This patch adds an LDFLAGS variable before calling the configure
> script of any package, in order to fix two problems :
> 
>  * Some configure scripts were not able to compile the test programs
>    used to test whether zlib was properly installed. The configure
>    scripts are properly using -lz, but the
>    -L/path/to/staging_dir/usr/lib option was not present, leading to
>    build failure.
> 
>  * While linking applications, for example the applications included
> in the fontconfig package, I had build failures like :
> 
> /usr/local/uclibc-0.9.28-2/arm/lib/gcc/arm-linux-uclibc/3.4.5/../../../../arm-linux-uclibc/bin/ld.real:
> warning: libfreetype.so.6, needed by ../src/.libs/libfontconfig.so,
> not found (try using -rpath or -rpath-link)
> 
>     this is due to the fact that ld is not able to find the other
>     already installed shared libraries.

May I have some feedback on this patch ? Without this, Buildroot is
just unusable here.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at uclibc.org
http://busybox.net/mailman/listinfo/buildroot

[Buildroot] Feedback ?

[Grant Likely]

On Mon, Oct 20, 2008 at 03:48:14PM +0200, Thomas Petazzoni wrote:
> Le Wed, 15 Oct 2008 16:47:37 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
> 
> > Make sure libraries are visible when building packages
> > 
> > This patch adds an LDFLAGS variable before calling the configure
> > script of any package, in order to fix two problems :
> > 
> >  * Some configure scripts were not able to compile the test programs
> >    used to test whether zlib was properly installed. The configure
> >    scripts are properly using -lz, but the
> >    -L/path/to/staging_dir/usr/lib option was not present, leading to
> >    build failure.
> > 
> >  * While linking applications, for example the applications included
> > in the fontconfig package, I had build failures like :
> > 
> > /usr/local/uclibc-0.9.28-2/arm/lib/gcc/arm-linux-uclibc/3.4.5/../../../../arm-linux-uclibc/bin/ld.real:
> > warning: libfreetype.so.6, needed by ../src/.libs/libfontconfig.so,
> > not found (try using -rpath or -rpath-link)
> > 
> >     this is due to the fact that ld is not able to find the other
> >     already installed shared libraries.
> 
> May I have some feedback on this patch ? Without this, Buildroot is
> just unusable here.

FWIW, this patch looks good to me, but I'm far from the most
knowledgable person to comment.

g.