From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Create zlib installation directory in the staging dir
Date: Fri, 31 Oct 2008 14:26:48 +0100 [thread overview]
Message-ID: <20081031132648.GE27517@mx.loc> (raw)
In-Reply-To: <d6cda7730810310544s6a93c58v18206bd17e58a72f@mail.gmail.com>
On Fri, Oct 31, 2008 at 10:44:20AM -0200, Thiago A. Corr?a wrote:
>On Fri, Oct 31, 2008 at 10:15 AM, Bernhard Reutner-Fischer
><rep.dot.nop@gmail.com> wrote:
>> On Fri, Oct 31, 2008 at 10:11:04AM -0200, Thiago A. Corr?a wrote:
>>>Applied in r23879.
>>
>> You applied something different, fwiw. But it doesn't matter much,
>> you're building zlib incorrectly anyway *shrug* i've fixed this now..
>>
>
>Diff between svn and git gives me:
>
>-$(TARGET_DIR)/usr/lib/libz.a: $(STAGING_DIR)/usr/lib/libz.so
>- $(INSTALL) -D $(STAGING_DIR)/usr/include/zlib.h
>$(TARGET_DIR)/usr/include/
>- $(INSTALL) $(STAGING_DIR)/usr/include/zconf.h $(TARGET_DIR)/usr/include/
>- $(INSTALL) -D $(STAGING_DIR)/usr/lib/libz.a $(TARGET_DIR)/usr/lib/
>+$(TARGET_DIR)/usr/lib/libz.a: $(STAGING_DIR)/usr/lib/libz.so.$(ZLIB_VERSION)
>+ mkdir -p $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/lib
>+ cp -dpf $(STAGING_DIR)/usr/include/zlib.h $(TARGET_DIR)/usr/include/
>+ cp -dpf $(STAGING_DIR)/usr/include/zconf.h $(TARGET_DIR)/usr/include/
>+ cp -dpf $(STAGING_DIR)/usr/lib/libz.a $(TARGET_DIR)/usr/lib/
>+ rm -f $(TARGET_DIR)/lib/libz.so $(TARGET_DIR)/usr/lib/libz.so
>+ ln -sf libz.so.$(ZLIB_VERSION) $(TARGET_DIR)/usr/lib/libz.so
> touch -c $@
>
>Why not use $(INSTALL) here? That's what I did in addition to that
>point where you and Thomas pointed out.
I overlooked that you creaded the dirs before installing the files, so
this is ok, sorry.
prev parent reply other threads:[~2008-10-31 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 16:00 [Buildroot] [PATCH] Create zlib installation directory in the staging dir Thomas Petazzoni
2008-10-31 8:37 ` Bernhard Reutner-Fischer
2008-10-31 12:11 ` Thiago A. Corrêa
2008-10-31 12:15 ` Bernhard Reutner-Fischer
2008-10-31 12:44 ` Thiago A. Corrêa
2008-10-31 13:26 ` Bernhard Reutner-Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031132648.GE27517@mx.loc \
--to=rep.dot.nop@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox