[Buildroot] kernel patch not applied

[Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>]

On Tue, Nov 04, 2008 at 07:19:32PM +0100, Julien Boibessot wrote:
>Hi,
>
>It's quite a long time now, since first email, but I was faced to the
>problem today, when updating my old buildroot to the latest svn one.
>
>Bernhard Fischer a ?crit :
>> On Mon, May 14, 2007 at 07:21:25AM +0200, Hans-Christian Egtvedt wrote:
>>   
>>> On Fri, 2007-05-11 at 17:40 +0200, Bernhard Fischer wrote:
>>>     
>>>> On Fri, May 11, 2007 at 04:31:49PM +0200, Hans-Christian Egtvedt wrote:
>>>>       
>>> <cut>
>>>
>>>     
>>>>> $(LINUX_HEADERS_UNPACK_DIR)/.patched:
>>>>> $(LINUX_HEADERS_UNPACK_DIR)/.unpacked
>>>>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR)
>>>>> toolchain/kernel-headers \
>>>>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch.\*
>>>>> ifeq ($(BR2_PACKAGE_OPENSWAN),y)
>>>>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR) package/openswan \
>>>>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch.\*
>>>>>         
>>>> which means that your shell just doesn't expand ba{r,z}
>>>>       
>>> Weird, I tried zsh, bash and sh. I am building on Ubuntu 7.04.
>>>     
>>
>> IIRC ubuntu defaults to dash as sh, so make sure that
>> a) SHELL points to /bin/bash (ash may work too)
>> or,
>> b) symlink sh to be bash
>>
>> a) is of course the preferred solution, didn't look if there are direct
>> references to /bin/sh instead of $SHELL in the makefiles, though.
>>   
>I'm working on KUbuntu 7.10. (yes, I know it's bad :-) ).
>a) doesn't work for me (even if my SHELL env is pointing to /bin/bash)
>
>only b) or "make SHELL=/bin/bash" are working.

yes. Note that there is also CONFIG_SHELL (which should be used in a
consistent manner everywhere) for $(shell ....) invocations.
>
>It's just a 2 cents feedback, so I'm not waiting for an answer ;-)

Thanks for the feedback, I could imagine that it proves helpful
for somebody.

cheers,