Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Claffey <david.claffey@rcn.com>
To: buildroot@busybox.net
Subject: [Buildroot] kernel patch not applied
Date: Fri, 11 May 2007 12:29:53 -0400	[thread overview]
Message-ID: <46449A01.6010701@rcn.com> (raw)
In-Reply-To: <20070511154059.GA4710@aon.at>

The braces expansion issue is different.

kernel-headers-new.makefile and linux26.mk .patched targets overlap.

$(LINUX_HEADERS_UNPACK_DIR)/.patched:
$(LINUX26_DIR)/.patched:

The kernel-headers target pulls in linux-$(LINUX_HEADERS_VERSION)-* patches,
while the linux26.mk is explicitly pulling in any patches placed in the
$(BR2_BOARD_PATH)/kernel-patches directory.

The latter does not occur because the kernel-headers rule satisfies the
dependency early on.

Bernhard Fischer wrote:
> On Fri, May 11, 2007 at 04:31:49PM +0200, Hans-Christian Egtvedt wrote:
>>> This actually causes an override of the .patched target in
>>> toolchain/kernel-headers/kernel-headers-new.makefile.
>>>
>>> Suggestions?
>> I just bumped into the same issue myself.
>>
>> in toolchain/kernel-headers/kernel-headers-new.makefile
>>
>> I had to change
>>
>> $(LINUX_HEADERS_UNPACK_DIR)/.patched:
>> $(LINUX_HEADERS_UNPACK_DIR)/.unpacked
>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR)
>> toolchain/kernel-headers \
>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch{,.gz,.bz2}
>> ifeq ($(BR2_PACKAGE_OPENSWAN),y)
>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR) package/openswan \
>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch{,.gz,.bz2}
>> endif
>>        touch $@
>>
>>
>> to
>>
>> $(LINUX_HEADERS_UNPACK_DIR)/.patched:
>> $(LINUX_HEADERS_UNPACK_DIR)/.unpacked
>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR)
>> toolchain/kernel-headers \
>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch.\*
>> ifeq ($(BR2_PACKAGE_OPENSWAN),y)
>>        toolchain/patch-kernel.sh $(LINUX_HEADERS_UNPACK_DIR) package/openswan \
>>                linux-$(LINUX_HEADERS_VERSION)-\*.patch.\*
> 
> which means that your shell just doesn't expand ba{r,z}
> 
> We use patterns also to specify targets we intend to strip, so either
> use a different shell or fix all occurances, i'd say.
> 

  reply	other threads:[~2007-05-11 16:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 14:21 [Buildroot] kernel patch not applied David Claffey
2007-05-10 15:34 ` David Claffey
2007-05-11 14:31   ` Hans-Christian Egtvedt
2007-05-11 15:40     ` Bernhard Fischer
2007-05-11 16:29       ` David Claffey [this message]
2007-05-12 10:31         ` Bernhard Fischer
2007-05-29 20:52           ` David Claffey
2007-05-14  5:21       ` Hans-Christian Egtvedt
2007-05-14  7:11         ` Bernhard Fischer
2007-05-14 12:41           ` [Buildroot] Matchbox Support Christopher Reder
2007-05-15  8:46             ` Assen Stoyanov
2007-05-15 10:55               ` Peter Korsgaard
2007-05-14 15:25           ` [Buildroot] kernel patch not applied Hans-Christian Egtvedt
2007-05-14 15:34             ` Bernhard Fischer
2007-05-15  7:47               ` Hans-Christian Egtvedt
2007-05-15  8:53                 ` Bernhard Fischer
2007-05-15 10:35                   ` [Buildroot] Whats happened to Eric? Ulf Samuelsson
2007-05-15 19:04                     ` Erik Andersen
2008-11-04 18:19           ` [Buildroot] kernel patch not applied Julien Boibessot
2008-11-04 19:54             ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46449A01.6010701@rcn.com \
    --to=david.claffey@rcn.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox