* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
@ 2008-08-04 19:08 jacmet at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2008-08-04 19:08 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2008-08-04 12:08:41 -0700 (Mon, 04 Aug 2008)
New Revision: 23040
Log:
i2c-tools: cleanup clean target
Modified:
trunk/buildroot/package/i2c-tools/i2c-tools.mk
Changeset:
Modified: trunk/buildroot/package/i2c-tools/i2c-tools.mk
===================================================================
--- trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-04 19:08:38 UTC (rev 23039)
+++ trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-04 19:08:41 UTC (rev 23040)
@@ -34,10 +34,7 @@
i2c-tools-source: $(DL_DIR)/$(I2C_TOOLS_SOURCE)
i2c-tools-clean:
- for i in i2cdump i2cget i2cset i2cdetect; \
- do \
- rm -f $(TARGET_DIR)/usr/bin/$$i; \
- done
+ rm -f $(addprefix $(TARGET_DIR)/usr/bin/,i2cdump i2cget i2cset i2cdetect)
-$(MAKE) -C $(I2C_TOOLS_DIR) clean
i2c-tools-dirclean:
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
@ 2008-08-26 13:03 laird at uclibc.org
2008-08-26 13:36 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: laird at uclibc.org @ 2008-08-26 13:03 UTC (permalink / raw)
To: buildroot
Author: laird
Date: 2008-08-26 06:03:05 -0700 (Tue, 26 Aug 2008)
New Revision: 23205
Log:
The changes below move i2c-tools.mk to use Makefile.autotools.in
package/i2c-tools/i2c-tools.mk
Use Makefile.autotools.in
Modified:
trunk/buildroot/package/i2c-tools/i2c-tools.mk
Changeset:
Modified: trunk/buildroot/package/i2c-tools/i2c-tools.mk
===================================================================
--- trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-26 12:19:29 UTC (rev 23204)
+++ trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-26 13:03:05 UTC (rev 23205)
@@ -6,45 +6,22 @@
I2C_TOOLS_VERSION:=3.0.1
I2C_TOOLS_SOURCE:=i2c-tools-$(I2C_TOOLS_VERSION).tar.bz2
I2C_TOOLS_SITE:=http://dl.lm-sensors.org/i2c-tools/releases/
-I2C_TOOLS_DIR:=$(BUILD_DIR)/i2c-tools-$(I2C_TOOLS_VERSION)
-I2C_TOOLS_BINARY:=tools/i2cdetect
-I2C_TOOLS_TARGET_BINARY:=usr/bin/i2cdetect
+I2C_TOOLS_AUTORECONF = NO
+I2C_TOOLS_INSTALL_STAGING = YES
+I2C_TOOLS_CONF_ENV =
+I2C_TOOLS_CONF_OPT =
+I2C_TOOLS_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
+I2C_TOOLS_DEPENDENCIES =
-$(DL_DIR)/$(I2C_TOOLS_SOURCE):
- $(WGET) -P $(DL_DIR) $(I2C_TOOLS_SITE)/$(I2C_TOOLS_SOURCE)
+$(eval $(call AUTOTARGETS,package,i2c-tools))
-$(I2C_TOOLS_DIR)/.unpacked: $(DL_DIR)/$(I2C_TOOLS_SOURCE)
- $(BZCAT) $(DL_DIR)/$(I2C_TOOLS_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
- toolchain/patch-kernel.sh $(I2C_TOOLS_DIR) package/i2c-tools/ i2c-tools-$(I2C_TOOLS_VERSION)\*.patch
+$(I2C_TOOLS_TARGET_CONFIGURE):
touch $@
-$(I2C_TOOLS_DIR)/$(I2C_TOOLS_BINARY): $(I2C_TOOLS_DIR)/.unpacked
- $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(I2C_TOOLS_DIR)
-
-$(TARGET_DIR)/$(I2C_TOOLS_TARGET_BINARY): $(I2C_TOOLS_DIR)/$(I2C_TOOLS_BINARY)
- $(INSTALL) -m 755 -d $(@D)
+$(I2C_TOOLS_TARGET_INSTALL_TARGET):
for i in i2cdump i2cget i2cset i2cdetect; \
do \
- $(INSTALL) -m 755 $(<D)/$$i $(@D); \
- $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(@D)/$$i; \
+ $(INSTALL) -m 755 $(I2C_TOOLS_DIR)/tools/$$i $(TARGET_DIR)/usr/bin; \
+ $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/$$i; \
done
-
-i2c-tools: uclibc $(TARGET_DIR)/$(I2C_TOOLS_TARGET_BINARY)
-
-i2c-tools-source: $(DL_DIR)/$(I2C_TOOLS_SOURCE)
-
-i2c-tools-clean:
- rm -f $(addprefix $(TARGET_DIR)/usr/bin/,i2cdump i2cget i2cset i2cdetect)
- -$(MAKE) -C $(I2C_TOOLS_DIR) clean
-
-i2c-tools-dirclean:
- rm -rf $(I2C_TOOLS_DIR)
-
-#############################################################
-#
-# Toplevel Makefile options
-#
-#############################################################
-ifeq ($(strip $(BR2_PACKAGE_I2C_TOOLS)),y)
-TARGETS+=i2c-tools
-endif
+ touch $@
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
2008-08-26 13:03 laird at uclibc.org
@ 2008-08-26 13:36 ` Peter Korsgaard
2008-08-26 14:03 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2008-08-26 13:36 UTC (permalink / raw)
To: buildroot
>>>>> "laird" == laird <laird@uclibc.org> writes:
laird> Author: laird
laird> Date: 2008-08-26 06:03:05 -0700 (Tue, 26 Aug 2008)
laird> New Revision: 23205
laird> Log:
laird> The changes below move i2c-tools.mk to use Makefile.autotools.in
But i2c-tools doesn't use autotools!
laird> @@ -6,45 +6,22 @@
laird> I2C_TOOLS_VERSION:=3.0.1
laird> I2C_TOOLS_SOURCE:=i2c-tools-$(I2C_TOOLS_VERSION).tar.bz2
laird> I2C_TOOLS_SITE:=http://dl.lm-sensors.org/i2c-tools/releases/
laird> -I2C_TOOLS_DIR:=$(BUILD_DIR)/i2c-tools-$(I2C_TOOLS_VERSION)
laird> -I2C_TOOLS_BINARY:=tools/i2cdetect
laird> -I2C_TOOLS_TARGET_BINARY:=usr/bin/i2cdetect
laird> +I2C_TOOLS_AUTORECONF = NO
laird> +I2C_TOOLS_INSTALL_STAGING = YES
Why install into staging (usr/local even)?
laird> +$(I2C_TOOLS_TARGET_INSTALL_TARGET):
laird> for i in i2cdump i2cget i2cset i2cdetect; \
laird> do \
laird> - $(INSTALL) -m 755 $(<D)/$$i $(@D); \
laird> - $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(@D)/$$i; \
laird> + $(INSTALL) -m 755 $(I2C_TOOLS_DIR)/tools/$$i $(TARGET_DIR)/usr/bin; \
laird> + $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/$$i; \
laird> done
You don't remove these files on -clean.
Sorry, I don't really see this as an improvement.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
@ 2008-08-26 14:01 laird at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: laird at uclibc.org @ 2008-08-26 14:01 UTC (permalink / raw)
To: buildroot
Author: laird
Date: 2008-08-26 07:01:37 -0700 (Tue, 26 Aug 2008)
New Revision: 23207
Log:
reverse changes to i2c-tools.mk until I tidy it up (get clean working for example)
Still feel a good change to make as some of the suggestions recently made it look
like Makefile.autotools.in might add support for installing a list of binaries etc
and this would benefit this package.
Modified:
trunk/buildroot/package/i2c-tools/i2c-tools.mk
Changeset:
Modified: trunk/buildroot/package/i2c-tools/i2c-tools.mk
===================================================================
--- trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-26 13:45:39 UTC (rev 23206)
+++ trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-08-26 14:01:37 UTC (rev 23207)
@@ -6,22 +6,45 @@
I2C_TOOLS_VERSION:=3.0.1
I2C_TOOLS_SOURCE:=i2c-tools-$(I2C_TOOLS_VERSION).tar.bz2
I2C_TOOLS_SITE:=http://dl.lm-sensors.org/i2c-tools/releases/
-I2C_TOOLS_AUTORECONF = NO
-I2C_TOOLS_INSTALL_STAGING = YES
-I2C_TOOLS_CONF_ENV =
-I2C_TOOLS_CONF_OPT =
-I2C_TOOLS_MAKE_OPT = $(TARGET_CONFIGURE_OPTS)
-I2C_TOOLS_DEPENDENCIES =
+I2C_TOOLS_DIR:=$(BUILD_DIR)/i2c-tools-$(I2C_TOOLS_VERSION)
+I2C_TOOLS_BINARY:=tools/i2cdetect
+I2C_TOOLS_TARGET_BINARY:=usr/bin/i2cdetect
-$(eval $(call AUTOTARGETS,package,i2c-tools))
+$(DL_DIR)/$(I2C_TOOLS_SOURCE):
+ $(WGET) -P $(DL_DIR) $(I2C_TOOLS_SITE)/$(I2C_TOOLS_SOURCE)
-$(I2C_TOOLS_TARGET_CONFIGURE):
+$(I2C_TOOLS_DIR)/.unpacked: $(DL_DIR)/$(I2C_TOOLS_SOURCE)
+ $(BZCAT) $(DL_DIR)/$(I2C_TOOLS_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+ toolchain/patch-kernel.sh $(I2C_TOOLS_DIR) package/i2c-tools/ i2c-tools-$(I2C_TOOLS_VERSION)\*.patch
touch $@
-$(I2C_TOOLS_TARGET_INSTALL_TARGET):
+$(I2C_TOOLS_DIR)/$(I2C_TOOLS_BINARY): $(I2C_TOOLS_DIR)/.unpacked
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(I2C_TOOLS_DIR)
+
+$(TARGET_DIR)/$(I2C_TOOLS_TARGET_BINARY): $(I2C_TOOLS_DIR)/$(I2C_TOOLS_BINARY)
+ $(INSTALL) -m 755 -d $(@D)
for i in i2cdump i2cget i2cset i2cdetect; \
do \
- $(INSTALL) -m 755 $(I2C_TOOLS_DIR)/tools/$$i $(TARGET_DIR)/usr/bin; \
- $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/$$i; \
+ $(INSTALL) -m 755 $(<D)/$$i $(@D); \
+ $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(@D)/$$i; \
done
- touch $@
+
+i2c-tools: uclibc $(TARGET_DIR)/$(I2C_TOOLS_TARGET_BINARY)
+
+i2c-tools-source: $(DL_DIR)/$(I2C_TOOLS_SOURCE)
+
+i2c-tools-clean:
+ rm -f $(addprefix $(TARGET_DIR)/usr/bin/,i2cdump i2cget i2cset i2cdetect)
+ -$(MAKE) -C $(I2C_TOOLS_DIR) clean
+
+i2c-tools-dirclean:
+ rm -rf $(I2C_TOOLS_DIR)
+
+#############################################################
+#
+# Toplevel Makefile options
+#
+#############################################################
+ifeq ($(strip $(BR2_PACKAGE_I2C_TOOLS)),y)
+TARGETS+=i2c-tools
+endif
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
2008-08-26 13:36 ` Peter Korsgaard
@ 2008-08-26 14:03 ` Bernhard Reutner-Fischer
2008-08-26 14:15 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Bernhard Reutner-Fischer @ 2008-08-26 14:03 UTC (permalink / raw)
To: buildroot
On Tue, Aug 26, 2008 at 03:36:16PM +0200, Peter Korsgaard wrote:
>>>>>> "laird" == laird <laird@uclibc.org> writes:
>
> laird> Author: laird
> laird> Date: 2008-08-26 06:03:05 -0700 (Tue, 26 Aug 2008)
> laird> New Revision: 23205
>
> laird> Log:
> laird> The changes below move i2c-tools.mk to use Makefile.autotools.in
>
>But i2c-tools doesn't use autotools!
> laird> @@ -6,45 +6,22 @@
> laird> I2C_TOOLS_VERSION:=3.0.1
> laird> I2C_TOOLS_SOURCE:=i2c-tools-$(I2C_TOOLS_VERSION).tar.bz2
> laird> I2C_TOOLS_SITE:=http://dl.lm-sensors.org/i2c-tools/releases/
> laird> -I2C_TOOLS_DIR:=$(BUILD_DIR)/i2c-tools-$(I2C_TOOLS_VERSION)
> laird> -I2C_TOOLS_BINARY:=tools/i2cdetect
> laird> -I2C_TOOLS_TARGET_BINARY:=usr/bin/i2cdetect
> laird> +I2C_TOOLS_AUTORECONF = NO
> laird> +I2C_TOOLS_INSTALL_STAGING = YES
>
>Why install into staging (usr/local even)?
>
> laird> +$(I2C_TOOLS_TARGET_INSTALL_TARGET):
> laird> for i in i2cdump i2cget i2cset i2cdetect; \
> laird> do \
> laird> - $(INSTALL) -m 755 $(<D)/$$i $(@D); \
> laird> - $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(@D)/$$i; \
> laird> + $(INSTALL) -m 755 $(I2C_TOOLS_DIR)/tools/$$i $(TARGET_DIR)/usr/bin; \
> laird> + $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/$$i; \
> laird> done
>
>You don't remove these files on -clean.
>
>Sorry, I don't really see this as an improvement.
Folks,
Please think about $(STRIP_STRIP_UNNEEDED) vs. $(STRIP_STRIP_ALL).
Ask yourself:
1) Do i want my libraries be able to load?
If you answer Y here, then use _UNNEEDED
2) Do i want my binaries small?
If you answer Y here, then use _ALL
Read the corresponding manpage for details and try to correct the
incorrectly stripped stuff that accumulated during the last months.
HTH,
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
2008-08-26 14:03 ` Bernhard Reutner-Fischer
@ 2008-08-26 14:15 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2008-08-26 14:15 UTC (permalink / raw)
To: buildroot
>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
Him
Bernhard> Please think about $(STRIP_STRIP_UNNEEDED) vs. $(STRIP_STRIP_ALL).
Bernhard> Ask yourself:
Bernhard> 1) Do i want my libraries be able to load?
Bernhard> If you answer Y here, then use _UNNEEDED
Bernhard> 2) Do i want my binaries small?
Bernhard> If you answer Y here, then use _ALL
Bernhard> Read the corresponding manpage for details and try to correct the
Bernhard> incorrectly stripped stuff that accumulated during the last months.
Yeah. Maybe we should simply have called them STRIP_BIN / STRIP_LIB
instead to make it completely clear. The issue is kinda moot though
with Makefile.autotools.in as make install-strip doesn't differenciate
between binaries and libs.
Perhaps we should simply add $(STRIP_STRIP_UNNEEDED) to $(STRIPCMD)
and run $(STRIP_STRIP_ALL) on all files in
$(TARGET_DIR)/{bin,sbin,usr/bin,sbin} as a post processing step?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/i2c-tools
@ 2008-12-01 9:07 jacmet at uclibc.org
0 siblings, 0 replies; 7+ messages in thread
From: jacmet at uclibc.org @ 2008-12-01 9:07 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2008-12-01 01:07:58 -0800 (Mon, 01 Dec 2008)
New Revision: 24198
Log:
i2c-tools: bump version
Modified:
trunk/buildroot/package/i2c-tools/i2c-tools.mk
Changeset:
Modified: trunk/buildroot/package/i2c-tools/i2c-tools.mk
===================================================================
--- trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-12-01 08:40:30 UTC (rev 24197)
+++ trunk/buildroot/package/i2c-tools/i2c-tools.mk 2008-12-01 09:07:58 UTC (rev 24198)
@@ -3,7 +3,7 @@
# i2c-tools
#
#############################################################
-I2C_TOOLS_VERSION:=3.0.1
+I2C_TOOLS_VERSION:=3.0.2
I2C_TOOLS_SOURCE:=i2c-tools-$(I2C_TOOLS_VERSION).tar.bz2
I2C_TOOLS_SITE:=http://dl.lm-sensors.org/i2c-tools/releases/
I2C_TOOLS_DIR:=$(BUILD_DIR)/i2c-tools-$(I2C_TOOLS_VERSION)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-12-01 9:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 9:07 [Buildroot] svn commit: trunk/buildroot/package/i2c-tools jacmet at uclibc.org
-- strict thread matches above, loose matches on Subject: below --
2008-08-26 14:01 laird at uclibc.org
2008-08-26 13:03 laird at uclibc.org
2008-08-26 13:36 ` Peter Korsgaard
2008-08-26 14:03 ` Bernhard Reutner-Fischer
2008-08-26 14:15 ` Peter Korsgaard
2008-08-04 19:08 jacmet at uclibc.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox