Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] target/makedev: fix compile breakage from unused result warning
@ 2008-11-24 23:41 Jeremy Kerr
  2008-12-02 22:26 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Kerr @ 2008-11-24 23:41 UTC (permalink / raw)
  To: buildroot

Compiling current SVN fails with the following error for me:

 cc1: warnings being treated as errors
 buildroot/buildroot/build_powerpc/makedevs/makedevs.c: In function ???main???:
 buildroot/buildroot/build_powerpc/makedevs/makedevs.c:531: error:
 ignoring return value of ???system???, declared with attribute
 warn_unused_result

This change adds a simple warning if system() fails.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

---

 target/makedevs/makedevs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: buildroot/target/makedevs/makedevs.c
===================================================================
--- buildroot.orig/target/makedevs/makedevs.c	2008-11-24 11:25:03.000000000 +1100
+++ buildroot/target/makedevs/makedevs.c	2008-11-24 11:34:51.000000000 +1100
@@ -528,7 +528,8 @@ loop:
 	}
 	fclose(table);
 
-	system("/bin/sync");
+	if (system("/bin/sync"))
+		bb_error_msg("sync failed, continuing anyway");
 
 	return 0;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-02 22:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-24 23:41 [Buildroot] [PATCH] target/makedev: fix compile breakage from unused result warning Jeremy Kerr
2008-12-02 22:26 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox