[Buildroot] [PATCH] target/cramfs/cramfs.mk: Fix device table not being passed to mkcramfs

[Buildroot] [PATCH] target/cramfs/cramfs.mk: Fix device table not being passed to mkcramfs

[Jared Holzman]

While mkcramfs was being patched to support a device table, the target device table was not being passed to the mkcramfs options. This patch fixes that

Signed-off-by: Jared Holzman <j.holzman@genesysdesign.com.au>

Index: target/cramfs/cramfs.mk
===================================================================
--- target/cramfs/cramfs.mk	(revision 24069)
+++ target/cramfs/cramfs.mk	(working copy)
@@ -40,11 +40,15 @@
 #
 #############################################################
 ifeq ($(BR2_ENDIAN),"BIG")
-CRAMFS_ENDIANNESS=-b
+CRAMFS_OPTS=-b
 else
-CRAMFS_ENDIANNESS=-l
+CRAMFS_OPTS=-l
 endif
 
+ifneq ($(TARGET_DEVICE_TABLE),)
+CRAMFS_OPTS += -D $(TARGET_DEVICE_TABLE)
+endif
+
 CRAMFS_TARGET=$(IMAGE).cramfs
 
 cramfsroot: host-fakeroot makedevs cramfs
@@ -68,7 +72,7 @@
 		>> $(PROJECT_BUILD_DIR)/_fakeroot.$(notdir $(CRAMFS_TARGET))
 endif
 	# Use fakeroot so mkcramfs believes the previous fakery
-	echo "$(CRAMFS_DIR)/mkcramfs -q $(CRAMFS_ENDIANNESS) " \
+	echo "$(CRAMFS_DIR)/mkcramfs -q $(CRAMFS_OPTS) " \
 		"$(TARGET_DIR) $(CRAMFS_TARGET)" >> $(PROJECT_BUILD_DIR)/_fakeroot.$(notdir $(CRAMFS_TARGET))
 	chmod a+x $(PROJECT_BUILD_DIR)/_fakeroot.$(notdir $(CRAMFS_TARGET))
 	$(STAGING_DIR)/usr/bin/fakeroot -- $(PROJECT_BUILD_DIR)/_fakeroot.$(notdir $(CRAMFS_TARGET))

---

Regards,

Jared Holzman

------------------------------------------------------------------------

*Electronics Design Engineer*

*Genesys Electronics Design Pty Ltd*

Unit 5, 33 Ryde Rd Pymble

NSW, Australia 2073

Direct: +612 9496 8924

Phone: +612 9496 8900

Fax: +612 9496 8999


j.holzman at genesysdesign.com.au <mailto:j.holzman@genesysdesign.com.au>

www.genesysdesign.com.au <http://www.genesysdesign.com.au>

------------------------------------------------------------------------

[Buildroot] [PATCH] target/cramfs/cramfs.mk: Fix device table not being passed to mkcramfs

[Peter Korsgaard]

>>>>> "Jared" == Jared Holzman <j.holzman@genesysdesign.com.au> writes:

Hi,

 Jared> While mkcramfs was being patched to support a device table,
 Jared> the target device table was not being passed to the mkcramfs
 Jared> options. This patch fixes that

Thanks, committed as r24228.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] target/cramfs/cramfs.mk: Fix device table not being passed to mkcramfs

[Hamish Moffatt]

On Tue, Dec 02, 2008 at 10:15:24AM +0100, Peter Korsgaard wrote:
> >>>>> "Jared" == Jared Holzman <j.holzman@genesysdesign.com.au> writes:
> 
> Hi,
> 
>  Jared> While mkcramfs was being patched to support a device table,
>  Jared> the target device table was not being passed to the mkcramfs
>  Jared> options. This patch fixes that
> 
> Thanks, committed as r24228.

Whoa! Has this been tested?

The device table is processed by running makedevs within the fakeroot
session, rather than relying on mkcramfs's device table support. (Same
as in many other buildroot targets, even though most of them have device
table support too.) Now the device table is being used twice, which may
or may not work?



Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>